public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/112795] [C++>=14] ICE pragma GCC unroll (n) cxx_eval_constant_expression Date: Fri, 01 Dec 2023 15:22:26 +0000 [thread overview] Message-ID: <bug-112795-4-J03If3b71I@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112795-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112795 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ebotcazou at gcc dot gnu.org, | |jakub at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- The bug is in calling expr = maybe_constant_value (expr); That is something that shouldn't be done in code possibly parsed in templates, unless !processing_template_decl. A quick fix would be to use expr = fold_non_dependent_expr (expr); and I guess I'll just submit a patch with that. That is e.g. what we do in OpenMP collapse clause parsing where we really want a constant already during parsing because how we parse the following code depends on that. If that is not the case in #pragma GCC unroll, the normal C++ way would be to only check if the result is INTEGER_CST etc. if it is not value dependent expr, otherwise pass down a tree and during instantiation instantiate that tree. That way template <int N> void foo () { #pragma GCC unroll(N) for (int i = 0; i != N; ++i) ; } would be possible.
next prev parent reply other threads:[~2023-12-01 15:22 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-30 23:20 [Bug c++/112795] New: " magnus.hegdahl at gmail dot com 2023-11-30 23:34 ` [Bug c++/112795] " magnus.hegdahl at gmail dot com 2023-12-01 14:10 ` mpolacek at gcc dot gnu.org 2023-12-01 15:22 ` jakub at gcc dot gnu.org [this message] 2023-12-01 15:55 ` jakub at gcc dot gnu.org 2023-12-01 17:13 ` ebotcazou at gcc dot gnu.org 2023-12-04 8:01 ` cvs-commit at gcc dot gnu.org 2023-12-04 8:02 ` jakub at gcc dot gnu.org 2023-12-05 16:32 ` cvs-commit at gcc dot gnu.org 2023-12-05 21:55 ` cvs-commit at gcc dot gnu.org 2023-12-05 22:38 ` jakub at gcc dot gnu.org 2023-12-16 0:37 ` cvs-commit at gcc dot gnu.org 2023-12-17 13:55 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112795-4-J03If3b71I@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).