public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/112795] [C++>=14] ICE pragma GCC unroll (n) cxx_eval_constant_expression Date: Tue, 05 Dec 2023 21:55:52 +0000 [thread overview] Message-ID: <bug-112795-4-yczrCYXx0f@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112795-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112795 --- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:59be79fd596ec8f8fbdf1479bc99e6aba9c52778 commit r14-6193-g59be79fd596ec8f8fbdf1479bc99e6aba9c52778 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Dec 5 22:54:08 2023 +0100 c++: Further #pragma GCC unroll C++ fix [PR112795] When committing the #pragma GCC unroll patch, I found I forgot one spot for diagnosting the invalid unrolls - if #pragma GCC unroll argument is dependent and the pragma is before a range for loop, the unroll tree (now, before one converted form ushort) is saved into RANGE_FOR_UNROLL and tsubst_stmt was RECURing on it, but didn't diagnose if it was invalid and so we ICEd later in the middle-end when ANNOTATE_EXPR had unexpected argument. The following patch fixes that. So that the diagnostics isn't done in 3 different places, the patch introduces a new function that both cp_parser_pragma_unroll and instantiation of ANNOTATE_EXPR and RANGE_FOR_STMT can use. 2023-12-05 Jakub Jelinek <jakub@redhat.com> PR c++/112795 * cp-tree.h (cp_check_pragma_unroll): Declare. * semantics.cc (cp_check_pragma_unroll): New function. * parser.cc (cp_parser_pragma_unroll): Use cp_check_pragma_unroll. * pt.cc (tsubst_expr) <case ANNOTATE_EXPR>: Likewise. (tsubst_stmt) <case RANGE_FOR_STMT>: Likwsie. * g++.dg/ext/unroll-2.C: Use { target c++11 } instead of dg-skip-if for -std=gnu++98. * g++.dg/ext/unroll-3.C: Likewise. * g++.dg/ext/unroll-7.C: New test. * g++.dg/ext/unroll-8.C: New test.
next prev parent reply other threads:[~2023-12-05 21:55 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-30 23:20 [Bug c++/112795] New: " magnus.hegdahl at gmail dot com 2023-11-30 23:34 ` [Bug c++/112795] " magnus.hegdahl at gmail dot com 2023-12-01 14:10 ` mpolacek at gcc dot gnu.org 2023-12-01 15:22 ` jakub at gcc dot gnu.org 2023-12-01 15:55 ` jakub at gcc dot gnu.org 2023-12-01 17:13 ` ebotcazou at gcc dot gnu.org 2023-12-04 8:01 ` cvs-commit at gcc dot gnu.org 2023-12-04 8:02 ` jakub at gcc dot gnu.org 2023-12-05 16:32 ` cvs-commit at gcc dot gnu.org 2023-12-05 21:55 ` cvs-commit at gcc dot gnu.org [this message] 2023-12-05 22:38 ` jakub at gcc dot gnu.org 2023-12-16 0:37 ` cvs-commit at gcc dot gnu.org 2023-12-17 13:55 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112795-4-yczrCYXx0f@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).