public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/112795] [C++>=14] ICE pragma GCC unroll (n) cxx_eval_constant_expression Date: Sun, 17 Dec 2023 13:55:16 +0000 [thread overview] Message-ID: <bug-112795-4-rH8LT4akTf@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112795-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112795 --- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-11 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:67762f3d76d42b2d9a436b6279fd111082f47c2b commit r11-11151-g67762f3d76d42b2d9a436b6279fd111082f47c2b Author: Jakub Jelinek <jakub@redhat.com> Date: Mon Dec 4 08:59:15 2023 +0100 c++: #pragma GCC unroll C++ fixes [PR112795] foo in the unroll-5.C testcase ICEs because cp_parser_pragma_unroll during parsing calls maybe_constant_value unconditionally, which is fine if !processing_template_decl, but can ICE otherwise. While just calling fold_non_dependent_expr there instead could be enough to fix the ICE (and I guess the right thing to do for backports if any), I don't see a reason why we couldn't handle a dependent #pragma GCC unroll argument as well, the unrolling isn't done in the FE and all the middle-end cares about is that ANNOTATE_EXPR has a 1..65534 last operand when it is annot_expr_unroll_kind. So, the following patch changes all the unsigned short unroll arguments to tree unroll (and thus avoids the tree -> unsigned short -> tree conversions), does the type and value checking during parsing only if the argument isn't dependent and repeats it during instantiation. 2023-12-04 Jakub Jelinek <jakub@redhat.com> PR c++/112795 gcc/cp/ * parser.c (cp_parser_pragma_unroll): Use fold_non_dependent_expr instead of maybe_constant_value. gcc/testsuite/ * g++.dg/ext/unroll-5.C: New test. (cherry picked from commit b6c78feea08c36e5754818c6a3d7536b3f8913dc)
prev parent reply other threads:[~2023-12-17 13:55 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-30 23:20 [Bug c++/112795] New: " magnus.hegdahl at gmail dot com 2023-11-30 23:34 ` [Bug c++/112795] " magnus.hegdahl at gmail dot com 2023-12-01 14:10 ` mpolacek at gcc dot gnu.org 2023-12-01 15:22 ` jakub at gcc dot gnu.org 2023-12-01 15:55 ` jakub at gcc dot gnu.org 2023-12-01 17:13 ` ebotcazou at gcc dot gnu.org 2023-12-04 8:01 ` cvs-commit at gcc dot gnu.org 2023-12-04 8:02 ` jakub at gcc dot gnu.org 2023-12-05 16:32 ` cvs-commit at gcc dot gnu.org 2023-12-05 21:55 ` cvs-commit at gcc dot gnu.org 2023-12-05 22:38 ` jakub at gcc dot gnu.org 2023-12-16 0:37 ` cvs-commit at gcc dot gnu.org 2023-12-17 13:55 ` cvs-commit at gcc dot gnu.org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112795-4-rH8LT4akTf@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).