[Bug tree-optimization/112818] New: [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[Bug tree-optimization/112818] New: [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

            Bug ID: 112818
           Summary: [14 regression] ICE when building accel-ppp (error:
                    conversion of register to a different size in
                    ‘view_convert_expr’, verify_gimple failed)
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 56762
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56762&action=edit
pppoe.c.i

Initially reported downstream in Gentoo by Toralf Förster at
https://bugs.gentoo.org/918991.

```
[...]
/var/tmp/portage/net-dialup/accel-ppp-1.12.0_p20230609/work/accel-pppd/ctrl/pppoe/pppoe.c:
In function ‘add_tag.constprop.isra’:
/var/tmp/portage/net-dialup/accel-ppp-1.12.0_p20230609/work/accel-pppd/ctrl/pppoe/pppoe.c:736:12:
error: conversion of register to a different size in ‘view_convert_expr’
  736 | static int add_tag(uint8_t *pack, size_t pack_size, int type, const
void *data, int len)
      |            ^~~~~~~
VIEW_CONVERT_EXPR<vector(2) short unsigned int>(_10);

_48 = VIEW_CONVERT_EXPR<vector(2) short unsigned int>(_10);
during GIMPLE pass: slp
/var/tmp/portage/net-dialup/accel-ppp-1.12.0_p20230609/work/accel-pppd/ctrl/pppoe/pppoe.c:736:12:
internal compiler error: verify_gimple failed
0x55e876bf0bf1 verify_gimple_in_cfg(function*, bool, bool)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-cfg.cc:5662
0x55e87813950c execute_function_todo
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/passes.cc:2088
0x55e87813950c do_per_function
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/passes.cc:1687
0x55e87813950c execute_todo
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

I can reproduce with 'gcc -c pppoe.c.i -O2 -march=znver2'.

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |14.0

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 56763
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56763&action=edit
start of reduction

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 56764
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56764&action=edit
A little more

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-12-01
             Status|UNCONFIRMED                 |NEW

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 56766
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56766&action=edit
reduced.i

cvise just finished here with this, not massaged it by hand though

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
I'll have a look, likely caused by r14-5068-g88aca917eb705b.

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
that's in my bisect range, yeah, got a few steps to go..

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed) since r14-5068-g88aca917eb705b

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pan2.li at intel dot com
            Summary|[14 regression] ICE when    |[14 regression] ICE when
                   |building accel-ppp (error:  |building accel-ppp (error:
                   |conversion of register to a |conversion of register to a
                   |different size in           |different size in
                   |‘view_convert_expr’,        |‘view_convert_expr’,
                   |verify_gimple failed)       |verify_gimple failed) since
                   |                            |r14-5068-g88aca917eb705b

--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
$ git bisect visualize --oneline
88aca917eb70 VECT: Refine the type size restriction of call vectorizer
1a0af6e5a99c RISC-V: Allow dest operand and accumulator operand overlap of
widen reduction instruction[PR112327]
c73d2d49f9be Daily bump.
4968e4844a3c (HEAD) Minor formatting fix for newly-added file from previous
commit
2b9778c8d9d3 Add files to discourage submissions of PRs to the GitHub mirror.
80b1a371008c PR target/110551: Tweak mulx register allocation using peephole2.

so yeah, let's call it r14-5068-g88aca917eb705b.

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed) since r14-5068-g88aca917eb705b

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
So the issue is we're having

  _8 = __builtin_bswap16 (type_6(D));

with short _8 and int type_6 due to C argument promotion applied because
of promote_prototypes.

Since the arg is an external_def we could have done better and actually
demoted it but vectorizable_call decided on a vector type already.

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed) since r14-5068-g88aca917eb705b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:80d67d8f682a6050a3bf4dcfa18a83f321986f2a

commit r14-6116-g80d67d8f682a6050a3bf4dcfa18a83f321986f2a
Author: Richard Biener <rguenther@suse.de>
Date:   Mon Dec 4 12:50:36 2023 +0100

    tree-optimization/112818 - re-instantiate vector type size check for bswap

    For __builtin_bswap vectorization we still require an equal vector
    type size.  Re-instantiate that check.

            PR tree-optimization/112818
            * tree-vect-stmts.cc (vectorizable_bswap): Check input and
            output vector types have the same size.

            * gcc.dg/vect/pr112818.c: New testcase.

[Bug tree-optimization/112818] [14 regression] ICE when building accel-ppp (error: conversion of register to a different size in ‘view_convert_expr’, verify_gimple failed) since r14-5068-g88aca917eb705b

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112818

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.