public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113059] [14 regression] fftw fails tests for -O3 -m32 -march=znver2 since r14-6210-ge44ed92dbbe9d4
Date: Wed, 10 Jan 2024 09:19:15 +0000	[thread overview]
Message-ID: <bug-113059-4-Uqeyso2oDB@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113059-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113059

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #11)
> IMHO REG_UNUSED notes should stay correct or be removed.  Instead of a full
> solution can we just wipe them in postreload-cse as we know that pass will
> break them?  Any user then should recompute the notes.  Originally pass
> properties were thought of a vehicle indicating these kind of IL features,
> so we
> could add PROP_rtl_unused_notes and if not set treat them as possibly
> invalid when present (instead of actively wiping them), and when a pass
> requires them re-compute them.
> 
> The problem with properties is that they are always set/unset irrespective
> of whether a pass did something destroying it.  That could be
> circumvented by postreload-cse only clearing the flag when it does
> something.
> 
> Not (re-)using pass properties for this but a flag in struct function
> works as well of course (or treat it as part of the DF state).

I was hoping we could have some df checking which would discover invalid
REG_UNUSED notes and so we would know which passes need tweaking, but I'm
afraid my df knowledge is insufficient for that.
Dunno how often postreload-cse actually extends life time of some register,
which should determine whether we want to drop REG_UNUSED notes unconditionally
at the end of postreload-cse, or whether we e.g. want just some flag whether
we've extended lifetime of something during it and only remove REG_UNUSED notes
if that flag is set.

  parent reply	other threads:[~2024-01-10  9:19 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18  9:12 [Bug target/113059] New: " sjames at gcc dot gnu.org
2023-12-18  9:30 ` [Bug target/113059] " rguenth at gcc dot gnu.org
2023-12-22  9:47 ` jakub at gcc dot gnu.org
2023-12-22 13:55 ` sjames at gcc dot gnu.org
2023-12-22 16:51 ` jakub at gcc dot gnu.org
2023-12-22 17:57 ` jakub at gcc dot gnu.org
2023-12-22 18:11 ` jakub at gcc dot gnu.org
2023-12-22 18:11 ` jakub at gcc dot gnu.org
2023-12-22 18:14 ` jakub at gcc dot gnu.org
2023-12-22 18:30 ` fw at gcc dot gnu.org
2023-12-22 18:40 ` jakub at gcc dot gnu.org
2023-12-22 18:41 ` jakub at gcc dot gnu.org
2024-01-09 16:03 ` jakub at gcc dot gnu.org
2024-01-10  9:10 ` rguenth at gcc dot gnu.org
2024-01-10  9:19 ` jakub at gcc dot gnu.org [this message]
2024-01-10  9:53 ` rguenther at suse dot de
2024-01-10 18:24 ` pinskia at gcc dot gnu.org
2024-01-30  7:59 ` sjames at gcc dot gnu.org
2024-01-30  9:23 ` jakub at gcc dot gnu.org
2024-01-30 10:25 ` rguenth at gcc dot gnu.org
2024-01-30 10:32 ` jakub at gcc dot gnu.org
2024-01-30 10:45 ` jakub at gcc dot gnu.org
2024-01-30 10:46 ` rguenther at suse dot de
2024-01-30 10:47 ` rguenth at gcc dot gnu.org
2024-01-30 11:17 ` jakub at gcc dot gnu.org
2024-01-30 11:39 ` jakub at gcc dot gnu.org
2024-02-05  8:36 ` cvs-commit at gcc dot gnu.org
2024-02-05  8:38 ` [Bug target/113059] [15 " jakub at gcc dot gnu.org
2024-02-23 15:49 ` sjames at gcc dot gnu.org
2024-02-23 15:49 ` sjames at gcc dot gnu.org
2024-03-06 16:44 ` sjames at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113059-4-Uqeyso2oDB@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).