public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/113059] [14 regression] fftw fails tests for -O3 -m32 -march=znver2 since r14-6210-ge44ed92dbbe9d4 Date: Mon, 05 Feb 2024 08:36:25 +0000 [thread overview] Message-ID: <bug-113059-4-Wavni9GqCP@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113059-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113059 --- Comment #24 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:d413df070ba5efadd2fb8b6c6aa6003b8cae617b commit r14-8797-gd413df070ba5efadd2fb8b6c6aa6003b8cae617b Author: Jakub Jelinek <jakub@redhat.com> Date: Mon Feb 5 09:33:26 2024 +0100 i386: Clear REG_UNUSED and REG_DEAD notes from the IL at the end of vzeroupper pass [PR113059] The move of the vzeroupper pass from after reload pass to after postreload_cse helped only partially, CSE-like passes can still invalidate those notes (especially REG_UNUSED) if they use some earlier register holding some value later on in the IL. So, either we could try to move it one pass further after gcse2 and hope no later pass invalidates the notes, or the following patch attempts to restore the REG_DEAD/REG_UNUSED state from GCC 13 and earlier, where the LRA or reload passes remove all REG_DEAD/REG_UNUSED notes and the notes reappear only at the start of dse2 pass when it calls df_note_add_problem (); df_analyze (); So, effectively NEXT_PASS (pass_postreload_cse); NEXT_PASS (pass_gcse2); NEXT_PASS (pass_split_after_reload); NEXT_PASS (pass_ree); NEXT_PASS (pass_compare_elim_after_reload); NEXT_PASS (pass_thread_prologue_and_epilogue); passes operate without those notes in the IL. While in GCC 14 mode switching computes the notes problem at the start of vzeroupper, the patch below removes them at the end of the pass again, so that the above passes continue to operate without them. 2024-02-05 Jakub Jelinek <jakub@redhat.com> PR target/113059 * config/i386/i386-features.cc (rest_of_handle_insert_vzeroupper): Remove REG_DEAD/REG_UNUSED notes at the end of the pass before df_analyze call.
next prev parent reply other threads:[~2024-02-05 8:37 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-18 9:12 [Bug target/113059] New: " sjames at gcc dot gnu.org 2023-12-18 9:30 ` [Bug target/113059] " rguenth at gcc dot gnu.org 2023-12-22 9:47 ` jakub at gcc dot gnu.org 2023-12-22 13:55 ` sjames at gcc dot gnu.org 2023-12-22 16:51 ` jakub at gcc dot gnu.org 2023-12-22 17:57 ` jakub at gcc dot gnu.org 2023-12-22 18:11 ` jakub at gcc dot gnu.org 2023-12-22 18:11 ` jakub at gcc dot gnu.org 2023-12-22 18:14 ` jakub at gcc dot gnu.org 2023-12-22 18:30 ` fw at gcc dot gnu.org 2023-12-22 18:40 ` jakub at gcc dot gnu.org 2023-12-22 18:41 ` jakub at gcc dot gnu.org 2024-01-09 16:03 ` jakub at gcc dot gnu.org 2024-01-10 9:10 ` rguenth at gcc dot gnu.org 2024-01-10 9:19 ` jakub at gcc dot gnu.org 2024-01-10 9:53 ` rguenther at suse dot de 2024-01-10 18:24 ` pinskia at gcc dot gnu.org 2024-01-30 7:59 ` sjames at gcc dot gnu.org 2024-01-30 9:23 ` jakub at gcc dot gnu.org 2024-01-30 10:25 ` rguenth at gcc dot gnu.org 2024-01-30 10:32 ` jakub at gcc dot gnu.org 2024-01-30 10:45 ` jakub at gcc dot gnu.org 2024-01-30 10:46 ` rguenther at suse dot de 2024-01-30 10:47 ` rguenth at gcc dot gnu.org 2024-01-30 11:17 ` jakub at gcc dot gnu.org 2024-01-30 11:39 ` jakub at gcc dot gnu.org 2024-02-05 8:36 ` cvs-commit at gcc dot gnu.org [this message] 2024-02-05 8:38 ` [Bug target/113059] [15 " jakub at gcc dot gnu.org 2024-02-23 15:49 ` sjames at gcc dot gnu.org 2024-02-23 15:49 ` sjames at gcc dot gnu.org 2024-03-06 16:44 ` sjames at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113059-4-Wavni9GqCP@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).