public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113059] [14 regression] fftw fails tests for -O3 -m32 -march=znver2 since r14-6210-ge44ed92dbbe9d4
Date: Tue, 30 Jan 2024 11:17:41 +0000 [thread overview]
Message-ID: <bug-113059-4-wKs3jMgoXV@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113059-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113059
--- Comment #22 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
BTW, I have quickly looked at REG_UNUSED notes on insn-recog.cc (as a randomly
picked large GCC object). Ignoring REG_UNUSED notes for flags register (which
are extremely common in lots of passes), seems we have just a few such notes
before RA and probably combiner kills them?
insn-recog.cc.292r.cse2: (expr_list:REG_UNUSED (reg:SI 207)
insn-recog.cc.293r.dse1: (expr_list:REG_UNUSED (reg:SI 207)
insn-recog.cc.294r.fwprop2: (expr_list:REG_UNUSED (reg:SI 207)
insn-recog.cc.296r.init-regs: (expr_list:REG_UNUSED (reg:SI 207)
insn-recog.cc.297r.ud_dce: (expr_list:REG_UNUSED (reg:SI 207)
insn-recog.cc.298r.combine: REG_UNUSED r207:SI
insn-recog.cc.298r.combine: REG_UNUSED r207:SI
Then I see tons of REG_UNUSED notes for non-flags in IRA dump (all new), but
they don't appear after it, so most likely LRA removes them. Even the flags
related REG_UNUSED don't appear in *.reload dump (except some details
comments), nor *.postreload etc.
And (note, this isn't a build with -mavx*, so no vzeroupper), they reappear
only in dse2 dump and keep appearing from that point onwards.
Similarly REG_DEAD notes don't appear in the IL between *.reload and
*.pro_and_epilogue inclusive.
Seems LRA does this in update_inc_notes, reload did that in reload function.
So, maybe safer than the above patch would be simply do that too in vzeroupper
pass (I guess we don't need to update the REG_INC notes).
Let me write another patch.
next prev parent reply other threads:[~2024-01-30 11:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 9:12 [Bug target/113059] New: " sjames at gcc dot gnu.org
2023-12-18 9:30 ` [Bug target/113059] " rguenth at gcc dot gnu.org
2023-12-22 9:47 ` jakub at gcc dot gnu.org
2023-12-22 13:55 ` sjames at gcc dot gnu.org
2023-12-22 16:51 ` jakub at gcc dot gnu.org
2023-12-22 17:57 ` jakub at gcc dot gnu.org
2023-12-22 18:11 ` jakub at gcc dot gnu.org
2023-12-22 18:11 ` jakub at gcc dot gnu.org
2023-12-22 18:14 ` jakub at gcc dot gnu.org
2023-12-22 18:30 ` fw at gcc dot gnu.org
2023-12-22 18:40 ` jakub at gcc dot gnu.org
2023-12-22 18:41 ` jakub at gcc dot gnu.org
2024-01-09 16:03 ` jakub at gcc dot gnu.org
2024-01-10 9:10 ` rguenth at gcc dot gnu.org
2024-01-10 9:19 ` jakub at gcc dot gnu.org
2024-01-10 9:53 ` rguenther at suse dot de
2024-01-10 18:24 ` pinskia at gcc dot gnu.org
2024-01-30 7:59 ` sjames at gcc dot gnu.org
2024-01-30 9:23 ` jakub at gcc dot gnu.org
2024-01-30 10:25 ` rguenth at gcc dot gnu.org
2024-01-30 10:32 ` jakub at gcc dot gnu.org
2024-01-30 10:45 ` jakub at gcc dot gnu.org
2024-01-30 10:46 ` rguenther at suse dot de
2024-01-30 10:47 ` rguenth at gcc dot gnu.org
2024-01-30 11:17 ` jakub at gcc dot gnu.org [this message]
2024-01-30 11:39 ` jakub at gcc dot gnu.org
2024-02-05 8:36 ` cvs-commit at gcc dot gnu.org
2024-02-05 8:38 ` [Bug target/113059] [15 " jakub at gcc dot gnu.org
2024-02-23 15:49 ` sjames at gcc dot gnu.org
2024-02-23 15:49 ` sjames at gcc dot gnu.org
2024-03-06 16:44 ` sjames at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-113059-4-wKs3jMgoXV@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).