public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3
@ 2024-01-18 19:38 zsojka at seznam dot cz
2024-01-18 19:44 ` [Bug ipa/113490] " pinskia at gcc dot gnu.org
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: zsojka at seznam dot cz @ 2024-01-18 19:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Bug ID: 113490
Summary: [14 Regression] ICE: in
propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425
at -O3
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: ice-on-valid-code
Severity: normal
Priority: P3
Component: ipa
Assignee: unassigned at gcc dot gnu.org
Reporter: zsojka at seznam dot cz
Target Milestone: ---
Host: x86_64-pc-linux-gnu
Target: x86_64-pc-linux-gnu
Created attachment 57145
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57145&action=edit
reduced testcase
Compiler output:
$ x86_64-pc-linux-gnu-gcc -O3 testcase.c -Wno-psabi
during IPA pass: cp
testcase.c:28:1: internal compiler error: in propagate_vals_across_arith_jfunc,
at ipa-cp.cc:2425
28 | }
| ^
0xda3a43 propagate_vals_across_arith_jfunc
/repo/gcc-trunk/gcc/ipa-cp.cc:2425
0x27d4b07 propagate_vals_across_pass_through
/repo/gcc-trunk/gcc/ipa-cp.cc:2481
0x27d4b07 propagate_scalar_across_jump_function
/repo/gcc-trunk/gcc/ipa-cp.cc:2563
0x27d4b07 propagate_constants_across_call
/repo/gcc-trunk/gcc/ipa-cp.cc:3281
0x27df470 propagate_constants_topo
/repo/gcc-trunk/gcc/ipa-cp.cc:4154
0x27df470 ipcp_propagate_stage
/repo/gcc-trunk/gcc/ipa-cp.cc:4361
0x27df470 ipcp_driver
/repo/gcc-trunk/gcc/ipa-cp.cc:6700
0x27df470 execute
/repo/gcc-trunk/gcc/ipa-cp.cc:6775
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-8251-20240118071416-g48c8d26d771-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-8251-20240118071416-g48c8d26d771-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240118 (experimental) (GCC)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
@ 2024-01-18 19:44 ` pinskia at gcc dot gnu.org
2024-01-18 19:50 ` pinskia at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-18 19:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
2024-01-18 19:44 ` [Bug ipa/113490] " pinskia at gcc dot gnu.org
@ 2024-01-18 19:50 ` pinskia at gcc dot gnu.org
2024-01-19 8:57 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-18 19:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |needs-bisection
Last reconfirmed| |2024-01-18
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
`--param=ipa-cp-value-list-size=16` allows it to not ICE.
Confirmed.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
2024-01-18 19:44 ` [Bug ipa/113490] " pinskia at gcc dot gnu.org
2024-01-18 19:50 ` pinskia at gcc dot gnu.org
@ 2024-01-19 8:57 ` rguenth at gcc dot gnu.org
2024-01-19 11:34 ` [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285 jakub at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-01-19 8:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jamborm at gcc dot gnu.org
Priority|P3 |P1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
` (2 preceding siblings ...)
2024-01-19 8:57 ` rguenth at gcc dot gnu.org
@ 2024-01-19 11:34 ` jakub at gcc dot gnu.org
2024-01-19 12:15 ` jamborm at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-01-19 11:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[14 Regression] ICE: in |[14 Regression] ICE: in
|propagate_vals_across_arith |propagate_vals_across_arith
|_jfunc, at ipa-cp.cc:2425 |_jfunc, at ipa-cp.cc:2425
|at -O3 |at -O3 since r14-285
Keywords|needs-bisection |
CC| |jakub at gcc dot gnu.org,
| |rguenth at gcc dot gnu.org
--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r14-285-g7bcdcf86e8272eeb524cc1dcb0ada8c8cfe6f27e
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
` (3 preceding siblings ...)
2024-01-19 11:34 ` [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285 jakub at gcc dot gnu.org
@ 2024-01-19 12:15 ` jamborm at gcc dot gnu.org
2024-01-19 13:36 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-01-19 12:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |jamborm at gcc dot gnu.org
--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Still, let me have a look.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
` (4 preceding siblings ...)
2024-01-19 12:15 ` jamborm at gcc dot gnu.org
@ 2024-01-19 13:36 ` rguenth at gcc dot gnu.org
2024-01-20 20:53 ` jamborm at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-01-19 13:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> Started with r14-285-g7bcdcf86e8272eeb524cc1dcb0ada8c8cfe6f27e
Should have only exposed this.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
` (5 preceding siblings ...)
2024-01-19 13:36 ` rguenth at gcc dot gnu.org
@ 2024-01-20 20:53 ` jamborm at gcc dot gnu.org
2024-01-24 15:21 ` cvs-commit at gcc dot gnu.org
2024-01-24 15:24 ` jamborm at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-01-20 20:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> ---
I have proposed a fix on the mailing list:
https://inbox.sourceware.org/gcc-patches/ri6cytv3eyy.fsf@/T/#u
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
` (6 preceding siblings ...)
2024-01-20 20:53 ` jamborm at gcc dot gnu.org
@ 2024-01-24 15:21 ` cvs-commit at gcc dot gnu.org
2024-01-24 15:24 ` jamborm at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-24 15:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Jambor <jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:bc4a20bc57ce71da0a96bcc6ec5683640b9004d6
commit r14-8392-gbc4a20bc57ce71da0a96bcc6ec5683640b9004d6
Author: Martin Jambor <mjambor@suse.cz>
Date: Wed Jan 24 16:19:48 2024 +0100
ipa-cp: Fix check for exceeding param_ipa_cp_value_list_size (PR 113490)
When the check for exceeding param_ipa_cp_value_list_size limit was
modified to be ignored for generating values from self-recursive
calls, it should have been changed from equal to, to equals to or is
greater than. This omission manifests itself as PR 113490.
When I examined the condition I also noticed that the parameter should
come from the callee rather than the caller, since the value list is
associated with the former and not the latter. In practice the limit
is of course very likely to be the same, but I fixed this aspect of
the condition too. I briefly audited all other uses of opt_for_fn in
ipa-cp.cc and all the others looked OK.
gcc/ChangeLog:
2024-01-19 Martin Jambor <mjambor@suse.cz>
PR ipa/113490
* ipa-cp.cc (ipcp_lattice<valtype>::add_value): Bail out if value
count is equal or greater than the limit. Use the limit from the
callee.
gcc/testsuite/ChangeLog:
2024-01-22 Martin Jambor <mjambor@suse.cz>
PR ipa/113490
* gcc.dg/ipa/pr113490.c: New test.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
` (7 preceding siblings ...)
2024-01-24 15:21 ` cvs-commit at gcc dot gnu.org
@ 2024-01-24 15:24 ` jamborm at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-01-24 15:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113490
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-01-24 15:24 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-18 19:38 [Bug ipa/113490] New: [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 zsojka at seznam dot cz
2024-01-18 19:44 ` [Bug ipa/113490] " pinskia at gcc dot gnu.org
2024-01-18 19:50 ` pinskia at gcc dot gnu.org
2024-01-19 8:57 ` rguenth at gcc dot gnu.org
2024-01-19 11:34 ` [Bug ipa/113490] [14 Regression] ICE: in propagate_vals_across_arith_jfunc, at ipa-cp.cc:2425 at -O3 since r14-285 jakub at gcc dot gnu.org
2024-01-19 12:15 ` jamborm at gcc dot gnu.org
2024-01-19 13:36 ` rguenth at gcc dot gnu.org
2024-01-20 20:53 ` jamborm at gcc dot gnu.org
2024-01-24 15:21 ` cvs-commit at gcc dot gnu.org
2024-01-24 15:24 ` jamborm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).