public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug testsuite/113502] New: gcc.target/aarch64/vect-early-break-cbranch.c testcase is too sensitive @ 2024-01-19 11:07 pinskia at gcc dot gnu.org 2024-01-19 11:12 ` [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are " pinskia at gcc dot gnu.org ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: pinskia at gcc dot gnu.org @ 2024-01-19 11:07 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113502 Bug ID: 113502 Summary: gcc.target/aarch64/vect-early-break-cbranch.c testcase is too sensitive Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords: testsuite-fail Severity: normal Priority: P3 Component: testsuite Assignee: unassigned at gcc dot gnu.org Reporter: pinskia at gcc dot gnu.org Target Milestone: --- Target: aarch64 Currently vect-early-break-cbranch.c fails. For the failure we have: ``` FAIL: gcc.target/aarch64/vect-early-break-cbranch.c check-function-bodies f1 body: .*\tcmge v[0-9]+.4s, v[0-9]+.4s, #0 \tumaxp v[0-9]+.4s, v[0-9]+.4s, v[0-9]+.4s \tfmov x[0-9]+, d[0-9]+ \tcbnz x[0-9]+, \.L[0-9]+ .* ... cmge v31.4s, v31.4s, #0 umaxp v31.4s, v31.4s, v31.4s fmov x3, d31 cbz x3, .L11 ``` As you can see it does not match as it is trying to match cbnz but cbz is emitted. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are too sensitive 2024-01-19 11:07 [Bug testsuite/113502] New: gcc.target/aarch64/vect-early-break-cbranch.c testcase is too sensitive pinskia at gcc dot gnu.org @ 2024-01-19 11:12 ` pinskia at gcc dot gnu.org 2024-01-31 14:53 ` cvs-commit at gcc dot gnu.org 2024-01-31 14:55 ` tnfchris at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: pinskia at gcc dot gnu.org @ 2024-01-19 11:12 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113502 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|gcc.target/aarch64/vect-ear |gcc.target/aarch64/vect-ear |ly-break-cbranch.c testcase |ly-break-cbranch.c and |is too sensitive |gcc.target/aarch64/sve/vect | |-early-break-cbranch.c | |testcase are too sensitive --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- gcc.target/aarch64/sve/vect-early-break-cbranch.c has a similar issue with `b.any` vs `b.none`. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are too sensitive 2024-01-19 11:07 [Bug testsuite/113502] New: gcc.target/aarch64/vect-early-break-cbranch.c testcase is too sensitive pinskia at gcc dot gnu.org 2024-01-19 11:12 ` [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are " pinskia at gcc dot gnu.org @ 2024-01-31 14:53 ` cvs-commit at gcc dot gnu.org 2024-01-31 14:55 ` tnfchris at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2024-01-31 14:53 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113502 --- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>: https://gcc.gnu.org/g:f7935beef7b02fbba0adf33fb2ba5c0a27d7e9ff commit r14-8662-gf7935beef7b02fbba0adf33fb2ba5c0a27d7e9ff Author: Tamar Christina <tamar.christina@arm.com> Date: Wed Jan 31 14:52:59 2024 +0000 AArch64: relax cbranch tests to accepted inverted branches [PR113502] Recently something in the midend had started inverting the branches by inverting the condition and the branches. While this is fine, it makes it hard to actually test. In RTL I disable scheduling and BB reordering to prevent this. But in GIMPLE there seems to be nothing I can do. __builtin_expect seems to have no impact on the change since I suspect this is happening during expand where conditions can be flipped regardless of probability during compare_and_branch. Since the mid-end has plenty of correctness tests, this weakens the backend tests to just check that a correct looking sequence is emitted. gcc/testsuite/ChangeLog: PR testsuite/113502 * gcc.target/aarch64/sve/vect-early-break-cbranch.c: Ignore exact branch. * gcc.target/aarch64/vect-early-break-cbranch.c: Likewise. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are too sensitive 2024-01-19 11:07 [Bug testsuite/113502] New: gcc.target/aarch64/vect-early-break-cbranch.c testcase is too sensitive pinskia at gcc dot gnu.org 2024-01-19 11:12 ` [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are " pinskia at gcc dot gnu.org 2024-01-31 14:53 ` cvs-commit at gcc dot gnu.org @ 2024-01-31 14:55 ` tnfchris at gcc dot gnu.org 2 siblings, 0 replies; 4+ messages in thread From: tnfchris at gcc dot gnu.org @ 2024-01-31 14:55 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113502 Tamar Christina <tnfchris at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |tnfchris at gcc dot gnu.org Status|UNCONFIRMED |RESOLVED --- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> --- Fixed, thanks ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-31 14:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-01-19 11:07 [Bug testsuite/113502] New: gcc.target/aarch64/vect-early-break-cbranch.c testcase is too sensitive pinskia at gcc dot gnu.org 2024-01-19 11:12 ` [Bug testsuite/113502] gcc.target/aarch64/vect-early-break-cbranch.c and gcc.target/aarch64/sve/vect-early-break-cbranch.c testcase are " pinskia at gcc dot gnu.org 2024-01-31 14:53 ` cvs-commit at gcc dot gnu.org 2024-01-31 14:55 ` tnfchris at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).