[Bug testsuite/113558] New: [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[Bug testsuite/113558] New: [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

            Bug ID: 113558
           Summary: [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c
                    etc. FAIL
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: rdapp at gcc dot gnu.org
  Target Milestone: ---
            Target: sparc*-sun-solaris2.11

Since 20230905, quite a number of tests regressed on 32 and 64-bit
Solaris/SPARC:

FAIL: gcc.dg/vect/vect-outer-4c-big-array.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "zero step in outer
loop.(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-outer-4c-big-array.c scan-tree-dump-times vect "zero
step in outer loop.(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s16a.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_dot_prod_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s16a.c scan-tree-dump-times vect
"vect_recog_dot_prod_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s8a.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_dot_prod_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s8a.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_widen_mult_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s8a.c scan-tree-dump-times vect
"vect_recog_dot_prod_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s8a.c scan-tree-dump-times vect
"vect_recog_widen_mult_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded"
1
FAIL: gcc.dg/vect/vect-reduc-dot-s8b.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_widen_mult_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-s8b.c scan-tree-dump-times vect
"vect_recog_widen_mult_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded"
1
FAIL: gcc.dg/vect/vect-reduc-dot-u16b.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_dot_prod_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-u16b.c scan-tree-dump-times vect
"vect_recog_dot_prod_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-u8a.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_dot_prod_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-u8a.c scan-tree-dump-times vect
"vect_recog_dot_prod_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-u8b.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_dot_prod_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-dot-u8b.c scan-tree-dump-times vect
"vect_recog_dot_prod_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-pattern-1a.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_widen_sum_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-pattern-1b-big-array.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_widen_sum_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-pattern-1b-big-array.c scan-tree-dump-times vect
"vect_recog_widen_sum_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded"
1
FAIL: gcc.dg/vect/vect-reduc-pattern-1c-big-array.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_widen_sum_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/vect-reduc-pattern-1c-big-array.c scan-tree-dump-times vect
"vect_recog_widen_sum_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded"
1
FAIL: gcc.dg/vect/vect-reduc-pattern-2a.c -flto -ffat-lto-objects 
scan-tree-dump-times vect "vect_recog_widen_sum_pattern:
detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c scan-tree-dump-times vect
"vect_recog_dot_prod_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded" 1
FAIL: gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c scan-tree-dump-times vect
"vect_recog_widen_mult_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded"
1

This is no doubt due to

commit e40edf6499576993862801640227e076b868241b
Author: Robin Dapp <rdapp@ventanamicro.com>
Date:   Thu Aug 31 09:16:35 2023 +0200

    testsuite/vect: Make match patterns more accurate.

The first scan (for "OUTER LOOP VECTORIZED") isn't run.  Before your patch,
the second scan matched

/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/vect/vect-outer-4c-big-array.c:17:17:
note:   zero step in outer loop.

but there's no line matching "succeeded" on this target.

[Bug testsuite/113558] [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 57193
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57193&action=edit
32-bit sparc-sun-solaris2.11 vect-outer-4c-big-array.c.179t.vect

[Bug testsuite/113558] [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug testsuite/113558] [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[rdapp at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

--- Comment #2 from Robin Dapp <rdapp at gcc dot gnu.org> ---
Created attachment 57195
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57195&action=edit
Tentative patch

Ah, it looks like nothing is being vectorized at all and the second check just
happened to match as part of the unsuccessful vectorization attempt.  It would
seem that we need the same condition as for the first check as well.

Would you mind giving the attached patch a try?  I ran it on riscv and power10
so far, x86 and aarch64 are still in progress.

[Bug testsuite/113558] [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #2 from Robin Dapp <rdapp at gcc dot gnu.org> ---
> Would you mind giving the attached patch a try?  I ran it on riscv and power10
> so far, x86 and aarch64 are still in progress.

Sure: I tested the patch on sparc-sun-solaris2.11 last night and all but
one of the failures are gone.  Seems you missed

FAIL: gcc.dg/vect/vect-reduc-pattern-2a.c scan-tree-dump-times vect
"vect_recog_widen_sum_pattern: detected(?:(?!failed)(?!Re-trying).)*succeeded"
1

Thanks for the quick fix.

[Bug testsuite/113558] [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Robin Dapp <rdapp@gcc.gnu.org>:

https://gcc.gnu.org/g:90880e117aa70a5ecd9b7df4381410c2ea0dcfdb

commit r14-8429-g90880e117aa70a5ecd9b7df4381410c2ea0dcfdb
Author: Robin Dapp <rdapp@ventanamicro.com>
Date:   Tue Jan 23 12:44:20 2024 +0100

    testsuite/vect: Add target checks to refined patterns.

    On Solaris/SPARC several vector tests appeared to be regressing.  They
    were never vectorized but the checks before r14-3612-ge40edf64995769
    would match regardless if a loop was actually vectorized or not.
    The refined checks only match a successful vectorization attempt
    but are run unconditionally.  This patch adds target checks to them.

    gcc/testsuite/ChangeLog:

            PR testsuite/113558

            * gcc.dg/vect/no-scevccp-outer-7.c: Add target check.
            * gcc.dg/vect/vect-outer-4c-big-array.c: Ditto.
            * gcc.dg/vect/vect-reduc-dot-s16a.c: Ditto.
            * gcc.dg/vect/vect-reduc-dot-s8a.c: Ditto.
            * gcc.dg/vect/vect-reduc-dot-s8b.c: Ditto.
            * gcc.dg/vect/vect-reduc-dot-u16b.c: Ditto.
            * gcc.dg/vect/vect-reduc-dot-u8a.c: Ditto.
            * gcc.dg/vect/vect-reduc-dot-u8b.c: Ditto.
            * gcc.dg/vect/vect-reduc-pattern-1a.c: Ditto.
            * gcc.dg/vect/vect-reduc-pattern-1b-big-array.c: Ditto.
            * gcc.dg/vect/vect-reduc-pattern-1c-big-array.c: Ditto.
            * gcc.dg/vect/vect-reduc-pattern-2a.c: Ditto.
            * gcc.dg/vect/vect-reduc-pattern-2b-big-array.c: Ditto.
            * gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c: Ditto.

[Bug testsuite/113558] [14 regression] gcc.dg/vect/vect-outer-4c-big-array.c etc. FAIL

[law at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113558

Jeffrey A. Law <law at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |law at gcc dot gnu.org

--- Comment #5 from Jeffrey A. Law <law at gcc dot gnu.org> ---
Should be fixed on the trunk now.