[Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3

[Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

            Bug ID: 113759
           Summary: [14 regression] ICE when building fdk-aac-2.0.3
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 57320
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57320&action=edit
rvlcconceal.ii

```
$ aarch64-unknown-linux-gnu-g++ -DPACKAGE_NAME=\"fdk-aac\"
-DPACKAGE_TARNAME=\"fdk-aac\" -DPACKAGE_VERSION=\"2.0.3\"
"-DPACKAGE_STRING=\"fdk-aac 2.0.3\""
-DPACKAGE_BUGREPORT=\"http://sourceforge.net/projects/opencore-amr/\"
-DPACKAGE_URL=\"\" -DPACKAGE=\"fdk-aac\" -DVERSION=\"2.0.3\" -DHAVE_STDIO_H=1
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1
-DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I.
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libAACdec/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libAACenc/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libArithCoding/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libDRCdec/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libSACdec/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libSACenc/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libSBRdec/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libSBRenc/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libMpegTPDec/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libMpegTPEnc/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libSYS/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libFDK/include
-I/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libPCMutils/include
-fno-exceptions -fno-rtti -O2 -pipe -mcpu=native -fdiagnostics-color=always
-ggdb3 -c
/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libAACdec/src/rvlcconceal.cpp
 -fPIC -DPIC -o libAACdec/src/.libs/rvlcconceal.o
/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libAACdec/src/rvlcconceal.cpp:
In function ‘void
BidirectionalEstimation_UseLowerScfOfCurrentFrame(CAacDecoderChannelInfo*)’:
/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libAACdec/src/rvlcconceal.cpp:286:6:
error: type mismatch in ‘widen_mult_plus_expr’
  286 | void BidirectionalEstimation_UseLowerScfOfCurrentFrame(
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
unsigned long
int
unsigned int
unsigned long
_364 = WIDEN_MULT_PLUS_EXPR <_189, 2, _237>;
during GIMPLE pass: widening_mul
/var/tmp/portage/media-libs/fdk-aac-2.0.3/work/fdk-aac-2.0.3/libAACdec/src/rvlcconceal.cpp:286:6:
internal compiler error: verify_gimple failed
0xaaaab3183277 verify_gimple_in_cfg(function*, bool, bool)
       
/usr/src/debug/sys-devel/gcc-14.0.1.9999/gcc-14.0.1.9999/gcc/tree-cfg.cc:5666
0xaaaab2fa196b execute_function_todo
       
/usr/src/debug/sys-devel/gcc-14.0.1.9999/gcc-14.0.1.9999/gcc/passes.cc:2088
0xaaaab2fa207f execute_todo
       
/usr/src/debug/sys-devel/gcc-14.0.1.9999/gcc-14.0.1.9999/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/aarch64-unknown-linux-gnu/14/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/configure
--host=aarch64-unknown-linux-gnu --build=aarch64-unknown-linux-gnu
--prefix=/usr --bindir=/usr/aarch64-unknown-linux-gnu/gcc-bin/14
--includedir=/usr/lib/gcc/aarch64-unknown-linux-gnu/14/include
--datadir=/usr/share/gcc-data/aarch64-unknown-linux-gnu/14
--mandir=/usr/share/gcc-data/aarch64-unknown-linux-gnu/14/man
--infodir=/usr/share/gcc-data/aarch64-unknown-linux-gnu/14/info
--with-gxx-include-dir=/usr/lib/gcc/aarch64-unknown-linux-gnu/14/include/g++-v14
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/aarch64-unknown-linux-gnu/14/python
--enable-languages=c,c++,fortran --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --enable-nls --without-included-gettext
--disable-libunwind-exceptions --enable-checking=yes,extra,rtl
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened
14.0.1 p, commit 3ab6b70bf9ee185da7e092e1df20753cdc35d710'
--with-gcc-major-version-only --enable-libstdcxx-time --enable-lto
--disable-libstdcxx-pch --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --disable-multilib
--disable-fixed-point --enable-libgomp --disable-libssp --disable-libada
--disable-cet --disable-systemtap --disable-valgrind-annotations
--disable-vtable-verify --disable-libvtv --with-zstd --without-isl
--enable-default-pie --enable-host-pie --enable-host-bind-now
--enable-default-ssp
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240204 (experimental)
2ada8bc53e1924b805d5a623d7ce79b20c2a9feb (Gentoo Hardened 14.0.1 p, commit
3ab6b70bf9ee185da7e092e1df20753cdc35d710)
```

I can reproduce with just g++ -c rvlcconceal.ii -O2.

[Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |14.0

[Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I suspect r14-8680-g2f14c0dbb78985 .

[Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 regression] ICE when    |[14 regression] ICE when
                   |building fdk-aac-2.0.3      |building fdk-aac-2.0.3
                   |                            |since r14-8680
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |jakub at gcc dot gnu.org
   Last reconfirmed|                            |2024-02-04
     Ever confirmed|0                           |1

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Your suspection is right.  I'll have a look tomorrow^H^H^H^H^H^H^Hlater today.

[Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
reduced:
```
typedef struct {
  struct {
    struct {
      int erRvlcInfo;
      short aRvlcScfFwd[];
    } aac;
  } overlay;
} CAacDecoderCommonData;
int calcRefValFwd_refNrgFwd, calcRefValFwd_conceal_group_min,
    calcRefValFwd_bnds, calcRefValFwd_startBand;
CAacDecoderCommonData calcRefValFwd_pAacDecoderChannelInfo_1;
void calcRefValFwd() {
  for (; calcRefValFwd_conceal_group_min >= 0;
       calcRefValFwd_conceal_group_min--) {
    for (; calcRefValFwd_startBand >= 0; calcRefValFwd_startBand--) {
      calcRefValFwd_bnds =
          calcRefValFwd_conceal_group_min + calcRefValFwd_startBand;
      calcRefValFwd_refNrgFwd = calcRefValFwd_pAacDecoderChannelInfo_1.overlay
                                    .aac.aRvlcScfFwd[calcRefValFwd_bnds];
      calcRefValFwd_pAacDecoderChannelInfo_1.overlay.aac
          .aRvlcScfFwd[calcRefValFwd_bnds] = 0;
    }
    calcRefValFwd_startBand = 1;
  }
}
```

[Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced slightly further:
```
extern short t[];
int f(int c, int b) {
  if (b < 0)  __builtin_unreachable();
  if (c <= 0)  __builtin_unreachable();
  int d;
  for (; c >= 0; c--) 
    {
      int a = b + c;
      d = t[a];
      t[a] = 0;
    }
    return d;
}
```

Note this requires IV-OPTS to get the IR that fails. It might be best if that
IR is converted into a gimple testcase too.

[Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
in future, I really need to rename variables too, as it's way easier to see
what's going on then

[Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 57321
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57321&action=edit
gcc14-pr113759.patch

Ugh, already the preexisting handling in convert_*_to_widen is just weird and
the new patch inconsistently changed just convert_mult_to_widen and not
convert_plusminus_to_widen.
In my limited understanding of the code, if actual_precision or from_unsignedN
are different from the properties of typeN, we want to cast, and similarly
we want to cast if TREE_TYPE (rhsN) is not uselessly convertible to typeN.
For INTEGER_CSTs, such casts should be done using fold_convert always,
otherwise build_and_insert_cast.

[Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:760a1a5b5e427707357ca1fa858c4561258972df

commit r14-8823-g760a1a5b5e427707357ca1fa858c4561258972df
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 6 12:57:53 2024 +0100

    tree-ssa-math-opts: Fix up convert_{mult,plusminus}_to_widen [PR113759]

    On the following testcase we emit invalid stmt:
    error: type mismatch in âwiden_mult_plus_exprâ
        6 | foo (int c, int b)
          | ^~~
    unsigned long
    int
    unsigned int
    unsigned long
    _31 = WIDEN_MULT_PLUS_EXPR <b_5(D), 2, _30>;

    The recent PR113560 r14-8680 changes tweaked convert_mult_to_widen,
    but didn't change convert_plusminus_to_widen for the
    TREE_TYPE (rhsN) != typeN cases, but looking at this, it was already
    before that change quite weird.

    Earlier in those functions it determines actual_precision and
from_unsignedN
    and wants to use that precision and signedness for the operands and
    it used build_and_insert_cast for that (which emits a cast stmt, even for
    INTEGER_CSTs) and later on for INTEGER_CST arguments fold_converted them
    to typeN (which is unclear to me why, because it seems to have assumed
    that TREE_TYPE (rhsN) is typeN, for the actual_precision or from_unsignedN
    cases it would be wrong except that build_and_insert_cast forced a SSA_NAME
    and so it doesn't trigger anymore).
    Now, since r14-8680 it is possible that rhsN also has some other type from
    typeN and we again want to cast.

    The following patch changes this, so that for the differences in
    actual_precision and/or from_unsignedN we actually update typeN and then
use
    it as the type to convert the arguments to if it isn't useless, for
    INTEGER_CSTs by just fold_converting, otherwise using
build_and_insert_cast.
    And uses useless_type_conversion_p test so that we don't convert unless
    necessary.  Plus by doing that effectively also doing the important part of
    the r14-8680 convert_mult_to_widen changes in convert_plusminus_to_widen.

    2024-02-06  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/113759
            * tree-ssa-math-opts.cc (convert_mult_to_widen): If
actual_precision
            or from_unsignedN differs from properties of typeN, update typeN
            to build_nonstandard_integer_type.  If TREE_TYPE (rhsN) is not
            uselessly convertible to typeN, convert it using fold_convert or
            build_and_insert_cast depending on if rhsN is INTEGER_CST or not.
            (convert_plusminus_to_widen): Likewise.

            * gcc.c-torture/compile/pr113759.c: New test.

[Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680

[roger at nextmovesoftware dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759

--- Comment #9 from Roger Sayle <roger at nextmovesoftware dot com> ---
Many thanks Jakub.  Sorry again for the inconvenience.