* [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
@ 2024-02-04 23:33 ` pinskia at gcc dot gnu.org
2024-02-04 23:33 ` pinskia at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-04 23:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pinskia at gcc dot gnu.org
Keywords| |ice-on-valid-code
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
2024-02-04 23:33 ` [Bug middle-end/113759] " pinskia at gcc dot gnu.org
@ 2024-02-04 23:33 ` pinskia at gcc dot gnu.org
2024-02-04 23:43 ` [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680 jakub at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-04 23:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I suspect r14-8680-g2f14c0dbb78985 .
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
2024-02-04 23:33 ` [Bug middle-end/113759] " pinskia at gcc dot gnu.org
2024-02-04 23:33 ` pinskia at gcc dot gnu.org
@ 2024-02-04 23:43 ` jakub at gcc dot gnu.org
2024-02-05 0:31 ` sjames at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-02-04 23:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[14 regression] ICE when |[14 regression] ICE when
|building fdk-aac-2.0.3 |building fdk-aac-2.0.3
| |since r14-8680
Priority|P3 |P1
Status|UNCONFIRMED |NEW
CC| |jakub at gcc dot gnu.org
Last reconfirmed| |2024-02-04
Ever confirmed|0 |1
--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Your suspection is right. I'll have a look tomorrow^H^H^H^H^H^H^Hlater today.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (2 preceding siblings ...)
2024-02-04 23:43 ` [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680 jakub at gcc dot gnu.org
@ 2024-02-05 0:31 ` sjames at gcc dot gnu.org
2024-02-05 0:45 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-02-05 0:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
reduced:
```
typedef struct {
struct {
struct {
int erRvlcInfo;
short aRvlcScfFwd[];
} aac;
} overlay;
} CAacDecoderCommonData;
int calcRefValFwd_refNrgFwd, calcRefValFwd_conceal_group_min,
calcRefValFwd_bnds, calcRefValFwd_startBand;
CAacDecoderCommonData calcRefValFwd_pAacDecoderChannelInfo_1;
void calcRefValFwd() {
for (; calcRefValFwd_conceal_group_min >= 0;
calcRefValFwd_conceal_group_min--) {
for (; calcRefValFwd_startBand >= 0; calcRefValFwd_startBand--) {
calcRefValFwd_bnds =
calcRefValFwd_conceal_group_min + calcRefValFwd_startBand;
calcRefValFwd_refNrgFwd = calcRefValFwd_pAacDecoderChannelInfo_1.overlay
.aac.aRvlcScfFwd[calcRefValFwd_bnds];
calcRefValFwd_pAacDecoderChannelInfo_1.overlay.aac
.aRvlcScfFwd[calcRefValFwd_bnds] = 0;
}
calcRefValFwd_startBand = 1;
}
}
```
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (3 preceding siblings ...)
2024-02-05 0:31 ` sjames at gcc dot gnu.org
@ 2024-02-05 0:45 ` pinskia at gcc dot gnu.org
2024-02-05 0:46 ` sjames at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-05 0:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced slightly further:
```
extern short t[];
int f(int c, int b) {
if (b < 0) __builtin_unreachable();
if (c <= 0) __builtin_unreachable();
int d;
for (; c >= 0; c--)
{
int a = b + c;
d = t[a];
t[a] = 0;
}
return d;
}
```
Note this requires IV-OPTS to get the IR that fails. It might be best if that
IR is converted into a gimple testcase too.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug middle-end/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (4 preceding siblings ...)
2024-02-05 0:45 ` pinskia at gcc dot gnu.org
@ 2024-02-05 0:46 ` sjames at gcc dot gnu.org
2024-02-05 9:46 ` [Bug tree-optimization/113759] " jakub at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-02-05 0:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
in future, I really need to rename variables too, as it's way easier to see
what's going on then
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (5 preceding siblings ...)
2024-02-05 0:46 ` sjames at gcc dot gnu.org
@ 2024-02-05 9:46 ` jakub at gcc dot gnu.org
2024-02-06 12:00 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-02-05 9:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 57321
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57321&action=edit
gcc14-pr113759.patch
Ugh, already the preexisting handling in convert_*_to_widen is just weird and
the new patch inconsistently changed just convert_mult_to_widen and not
convert_plusminus_to_widen.
In my limited understanding of the code, if actual_precision or from_unsignedN
are different from the properties of typeN, we want to cast, and similarly
we want to cast if TREE_TYPE (rhsN) is not uselessly convertible to typeN.
For INTEGER_CSTs, such casts should be done using fold_convert always,
otherwise build_and_insert_cast.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (6 preceding siblings ...)
2024-02-05 9:46 ` [Bug tree-optimization/113759] " jakub at gcc dot gnu.org
@ 2024-02-06 12:00 ` cvs-commit at gcc dot gnu.org
2024-02-06 12:02 ` jakub at gcc dot gnu.org
2024-02-06 12:33 ` roger at nextmovesoftware dot com
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-02-06 12:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:760a1a5b5e427707357ca1fa858c4561258972df
commit r14-8823-g760a1a5b5e427707357ca1fa858c4561258972df
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Feb 6 12:57:53 2024 +0100
tree-ssa-math-opts: Fix up convert_{mult,plusminus}_to_widen [PR113759]
On the following testcase we emit invalid stmt:
error: type mismatch in âwiden_mult_plus_exprâ
6 | foo (int c, int b)
| ^~~
unsigned long
int
unsigned int
unsigned long
_31 = WIDEN_MULT_PLUS_EXPR <b_5(D), 2, _30>;
The recent PR113560 r14-8680 changes tweaked convert_mult_to_widen,
but didn't change convert_plusminus_to_widen for the
TREE_TYPE (rhsN) != typeN cases, but looking at this, it was already
before that change quite weird.
Earlier in those functions it determines actual_precision and
from_unsignedN
and wants to use that precision and signedness for the operands and
it used build_and_insert_cast for that (which emits a cast stmt, even for
INTEGER_CSTs) and later on for INTEGER_CST arguments fold_converted them
to typeN (which is unclear to me why, because it seems to have assumed
that TREE_TYPE (rhsN) is typeN, for the actual_precision or from_unsignedN
cases it would be wrong except that build_and_insert_cast forced a SSA_NAME
and so it doesn't trigger anymore).
Now, since r14-8680 it is possible that rhsN also has some other type from
typeN and we again want to cast.
The following patch changes this, so that for the differences in
actual_precision and/or from_unsignedN we actually update typeN and then
use
it as the type to convert the arguments to if it isn't useless, for
INTEGER_CSTs by just fold_converting, otherwise using
build_and_insert_cast.
And uses useless_type_conversion_p test so that we don't convert unless
necessary. Plus by doing that effectively also doing the important part of
the r14-8680 convert_mult_to_widen changes in convert_plusminus_to_widen.
2024-02-06 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/113759
* tree-ssa-math-opts.cc (convert_mult_to_widen): If
actual_precision
or from_unsignedN differs from properties of typeN, update typeN
to build_nonstandard_integer_type. If TREE_TYPE (rhsN) is not
uselessly convertible to typeN, convert it using fold_convert or
build_and_insert_cast depending on if rhsN is INTEGER_CST or not.
(convert_plusminus_to_widen): Likewise.
* gcc.c-torture/compile/pr113759.c: New test.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (7 preceding siblings ...)
2024-02-06 12:00 ` cvs-commit at gcc dot gnu.org
@ 2024-02-06 12:02 ` jakub at gcc dot gnu.org
2024-02-06 12:33 ` roger at nextmovesoftware dot com
9 siblings, 0 replies; 11+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-02-06 12:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/113759] [14 regression] ICE when building fdk-aac-2.0.3 since r14-8680
2024-02-04 23:13 [Bug middle-end/113759] New: [14 regression] ICE when building fdk-aac-2.0.3 sjames at gcc dot gnu.org
` (8 preceding siblings ...)
2024-02-06 12:02 ` jakub at gcc dot gnu.org
@ 2024-02-06 12:33 ` roger at nextmovesoftware dot com
9 siblings, 0 replies; 11+ messages in thread
From: roger at nextmovesoftware dot com @ 2024-02-06 12:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113759
--- Comment #9 from Roger Sayle <roger at nextmovesoftware dot com> ---
Many thanks Jakub. Sorry again for the inconvenience.
^ permalink raw reply [flat|nested] 11+ messages in thread