public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113915] [14 regression] glibc's _dl_find_object_update_1 miscompiled for armv7a since r14-4365-g0731889c026bfe
Date: Wed, 14 Feb 2024 07:26:32 +0000	[thread overview]
Message-ID: <bug-113915-4-Tsl6ZxWeYj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113915-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113915

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #8)
> (In reply to Andrew Pinski from comment #7)
> > cannot be conditional executed.
> 
> That is because most of the insn patterns in sync.md don't have 
>   [(set_attr "conds" "nocond")])
> 
> on them ....
> 
> Someone will have to submit that patch after testing, I don't have the
> bandwidth to do it though.

Actually wait that is the not fix.

This should work, I think:
```
diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc
index c44047c377a..d55ea59a727 100644
--- a/gcc/config/arm/arm.cc
+++ b/gcc/config/arm/arm.cc
@@ -25611,11 +25611,12 @@ arm_final_prescan_insn (rtx_insn *insn)

            case INSN:
              /* Instructions using or affecting the condition codes make it
-                fail.  */
+                fail or ones which cannot be predicable.  */
              scanbody = PATTERN (this_insn);
              if (!(GET_CODE (scanbody) == SET
                    || GET_CODE (scanbody) == PARALLEL)
-                 || get_attr_conds (this_insn) != CONDS_NOCOND)
+                 || get_attr_conds (this_insn) != CONDS_NOCOND
+                 || get_attr_predicable (this_insn) != PREDICABLE_YES)
                fail = TRUE;
              break;

```

  parent reply	other threads:[~2024-02-14  7:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14  2:41 [Bug target/113915] New: [14 regression] glibc " sjames at gcc dot gnu.org
2024-02-14  2:42 ` [Bug target/113915] " sjames at gcc dot gnu.org
2024-02-14  2:48 ` sjames at gcc dot gnu.org
2024-02-14  2:53 ` sjames at gcc dot gnu.org
2024-02-14  3:10 ` sjames at gcc dot gnu.org
2024-02-14  3:14 ` sjames at gcc dot gnu.org
2024-02-14  6:59 ` pinskia at gcc dot gnu.org
2024-02-14  6:59 ` pinskia at gcc dot gnu.org
2024-02-14  7:05 ` [Bug target/113915] [14 regression] glibc's _dl_find_object_update_1 " pinskia at gcc dot gnu.org
2024-02-14  7:16 ` pinskia at gcc dot gnu.org
2024-02-14  7:21 ` pinskia at gcc dot gnu.org
2024-02-14  7:26 ` pinskia at gcc dot gnu.org [this message]
2024-02-14  7:38 ` pinskia at gcc dot gnu.org
2024-02-14 10:07 ` rguenth at gcc dot gnu.org
2024-02-14 11:01 ` wilco at gcc dot gnu.org
2024-02-18  9:32 ` sjames at gcc dot gnu.org
2024-02-21 14:38 ` wilco at gcc dot gnu.org
2024-03-06 17:42 ` cvs-commit at gcc dot gnu.org
2024-03-06 18:00 ` wilco at gcc dot gnu.org
2024-03-08 15:05 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113915-4-Tsl6ZxWeYj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).