public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/113915] [14 regression] glibc's _dl_find_object_update_1 miscompiled for armv7a since r14-4365-g0731889c026bfe Date: Wed, 06 Mar 2024 17:42:21 +0000 [thread overview] Message-ID: <bug-113915-4-WQgRIhqhxa@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113915-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113915 --- Comment #14 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Wilco Dijkstra <wilco@gcc.gnu.org>: https://gcc.gnu.org/g:b575f37a342cebb954aa85fa45df0604bfa1ada9 commit r14-9343-gb575f37a342cebb954aa85fa45df0604bfa1ada9 Author: Wilco Dijkstra <wilco.dijkstra@arm.com> Date: Wed Mar 6 17:35:16 2024 +0000 ARM: Fix conditional execution [PR113915] By default most patterns can be conditionalized on Arm targets. However Thumb-2 predication requires the "predicable" attribute be explicitly set to "yes". Most patterns are shared between Arm and Thumb(-2) and are marked with "predicable". Given this sharing, it does not make sense to use a different default for Arm. So only consider conditional execution of instructions that have the predicable attribute set to yes. This ensures that patterns not explicitly marked as such are never conditionally executed. gcc/ChangeLog: PR target/113915 * config/arm/arm.md (NOCOND): Improve comment. (arm_rev*) Add predicable. * config/arm/arm.cc (arm_final_prescan_insn): Add check for PREDICABLE_YES. gcc/testsuite/ChangeLog: PR target/113915 * gcc.target/arm/builtin-bswap-1.c: Fix test to allow conditional execution both for Arm and Thumb-2.
next prev parent reply other threads:[~2024-03-06 17:42 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-14 2:41 [Bug target/113915] New: [14 regression] glibc " sjames at gcc dot gnu.org 2024-02-14 2:42 ` [Bug target/113915] " sjames at gcc dot gnu.org 2024-02-14 2:48 ` sjames at gcc dot gnu.org 2024-02-14 2:53 ` sjames at gcc dot gnu.org 2024-02-14 3:10 ` sjames at gcc dot gnu.org 2024-02-14 3:14 ` sjames at gcc dot gnu.org 2024-02-14 6:59 ` pinskia at gcc dot gnu.org 2024-02-14 6:59 ` pinskia at gcc dot gnu.org 2024-02-14 7:05 ` [Bug target/113915] [14 regression] glibc's _dl_find_object_update_1 " pinskia at gcc dot gnu.org 2024-02-14 7:16 ` pinskia at gcc dot gnu.org 2024-02-14 7:21 ` pinskia at gcc dot gnu.org 2024-02-14 7:26 ` pinskia at gcc dot gnu.org 2024-02-14 7:38 ` pinskia at gcc dot gnu.org 2024-02-14 10:07 ` rguenth at gcc dot gnu.org 2024-02-14 11:01 ` wilco at gcc dot gnu.org 2024-02-18 9:32 ` sjames at gcc dot gnu.org 2024-02-21 14:38 ` wilco at gcc dot gnu.org 2024-03-06 17:42 ` cvs-commit at gcc dot gnu.org [this message] 2024-03-06 18:00 ` wilco at gcc dot gnu.org 2024-03-08 15:05 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113915-4-WQgRIhqhxa@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).