public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/113959] New: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)`
@ 2024-02-16 14:16 antoshkka at gmail dot com
  2024-02-17  0:32 ` [Bug middle-end/113959] " pinskia at gcc dot gnu.org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: antoshkka at gmail dot com @ 2024-02-16 14:16 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113959

            Bug ID: 113959
           Summary: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to
                    `__builtin_isfinite(x)`
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: antoshkka at gmail dot com
  Target Milestone: ---

Sometimes people check for finite number using `__builtin_isnan(x) ||
__builtin_isinf(x)`. However `__builtin_isfinite(x)` produces a better
assembly.

Please, add the optimization.

Godbolt playground: https://godbolt.org/z/5r38169fn

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug middle-end/113959] Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)`
  2024-02-16 14:16 [Bug middle-end/113959] New: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)` antoshkka at gmail dot com
@ 2024-02-17  0:32 ` pinskia at gcc dot gnu.org
  2024-02-17  0:33 ` pinskia at gcc dot gnu.org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-17  0:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113959

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug middle-end/113959] Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)`
  2024-02-16 14:16 [Bug middle-end/113959] New: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)` antoshkka at gmail dot com
  2024-02-17  0:32 ` [Bug middle-end/113959] " pinskia at gcc dot gnu.org
@ 2024-02-17  0:33 ` pinskia at gcc dot gnu.org
  2024-02-17  2:17 ` harald at gigawatt dot nl
  2024-02-19  7:48 ` rguenth at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-17  0:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113959

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 57440
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57440&action=edit
testcase from the godbolt link

Next time attach the testcase or put it in line instead of just linking to
godbolt.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug middle-end/113959] Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)`
  2024-02-16 14:16 [Bug middle-end/113959] New: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)` antoshkka at gmail dot com
  2024-02-17  0:32 ` [Bug middle-end/113959] " pinskia at gcc dot gnu.org
  2024-02-17  0:33 ` pinskia at gcc dot gnu.org
@ 2024-02-17  2:17 ` harald at gigawatt dot nl
  2024-02-19  7:48 ` rguenth at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: harald at gigawatt dot nl @ 2024-02-17  2:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113959

Harald van Dijk <harald at gigawatt dot nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |harald at gigawatt dot nl

--- Comment #2 from Harald van Dijk <harald at gigawatt dot nl> ---
See also bug #66462: the code currently generated is wrong under
-fsignaling-nans, a patch has been posted to fix that, and had then been
forgotten. The patch may possibly improve codegen regardless of
-fsignaling-nans.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug middle-end/113959] Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)`
  2024-02-16 14:16 [Bug middle-end/113959] New: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)` antoshkka at gmail dot com
                   ` (2 preceding siblings ...)
  2024-02-17  2:17 ` harald at gigawatt dot nl
@ 2024-02-19  7:48 ` rguenth at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-02-19  7:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113959

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-02-19
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-02-19  7:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-16 14:16 [Bug middle-end/113959] New: Optimize `__builtin_isnan(x) || __builtin_isinf(x)` to `__builtin_isfinite(x)` antoshkka at gmail dot com
2024-02-17  0:32 ` [Bug middle-end/113959] " pinskia at gcc dot gnu.org
2024-02-17  0:33 ` pinskia at gcc dot gnu.org
2024-02-17  2:17 ` harald at gigawatt dot nl
2024-02-19  7:48 ` rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).