[Bug c++/114078] New: operator new and operator delete are incorrectly acceptable as explicit object member functions

[Bug c++/114078] New: operator new and operator delete are incorrectly acceptable as explicit object member functions

[de34 at live dot cn]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114078

            Bug ID: 114078
           Summary: operator new and operator delete are incorrectly
                    acceptable as explicit object member functions
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: de34 at live dot cn
  Target Milestone: ---

GCC currently accepts this wrong program while it shouldn't
(https://godbolt.org/z/7jGnGqYPM), because member operator new/operator delete
are always static member functions.

#include <cstddef>
#include <new>

struct S {
    void* operator new(this std::size_t);
    void operator delete(this S*, std::destroying_delete_t);

    operator S*() const;
    operator std::size_t() const;
};

int main()
{
    S{}.operator new();
    S{}.operator delete(std::destroying_delete);
}

Similar to https://github.com/llvm/llvm-project/issues/82249 which is fixed
recently.

[Bug c++/114078] operator new and operator delete are incorrectly acceptable as explicit object member functions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114078

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-02-23

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed, I thought I had saw one that was exactly the same as this but it
seems maybe I was wrong.

[Bug c++/114078] operator new and operator delete are incorrectly acceptable as explicit object member functions

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114078

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:cf51fe706ea0219beb5bb85e81606d372ca9635e

commit r14-10085-gcf51fe706ea0219beb5bb85e81606d372ca9635e
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Sat Apr 20 15:08:02 2024 +1000

    c++: Check if allocation functions are xobj members [PR114078]

    A class allocation member function is implicitly 'static' by
    [class.free] p3, so cannot have an explicit object parameter.

            PR c++/114078

    gcc/cp/ChangeLog:

            * decl.cc (grokdeclarator): Check allocation functions for xobj
            parameters.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp23/explicit-obj-ops-alloc.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

[Bug c++/114078] operator new and operator delete are incorrectly acceptable as explicit object member functions

[nshead at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114078

Nathaniel Shead <nshead at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |nshead at gcc dot gnu.org
                 CC|                            |nshead at gcc dot gnu.org
             Status|NEW                         |RESOLVED

--- Comment #3 from Nathaniel Shead <nshead at gcc dot gnu.org> ---
Fixed for GCC 14.