* [Bug lto/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
@ 2024-04-09 18:54 ` ewlu at rivosinc dot com
2024-04-10 5:56 ` linkw at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ewlu at rivosinc dot com @ 2024-04-09 18:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
Edwin Lu <ewlu at rivosinc dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ewlu at rivosinc dot com,
| |patrick at rivosinc dot com
--- Comment #1 from Edwin Lu <ewlu at rivosinc dot com> ---
We are also seeing this for rv32 targets on linux and newlib
https://github.com/patrick-rivos/gcc-postcommit-ci/issues/746#issuecomment-2045727038
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
2024-04-09 18:54 ` [Bug lto/114662] " ewlu at rivosinc dot com
@ 2024-04-10 5:56 ` linkw at gcc dot gnu.org
2024-04-10 6:26 ` [Bug testsuite/114662] " linkw at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: linkw at gcc dot gnu.org @ 2024-04-10 5:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
Kewen Lin <linkw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |linkw at gcc dot gnu.org
CC| |linkw at gcc dot gnu.org
Last reconfirmed| |2024-04-10
Status|UNCONFIRMED |ASSIGNED
--- Comment #2 from Kewen Lin <linkw at gcc dot gnu.org> ---
I think this is a test issue, with -m32 unsigned long is 4 bytes while CL1,CL2
are 8 bytes constants, then it considers some checks would always fail and the
abort will happen, since the optimization aggressively optimize away the call
to getb, there is no chance to further check "semantic equality". The IR for
main at *.015t.cfg looks like:
int main (int argc, char * * argv)
{
struct SB b;
struct SA a;
int D.3983;
<bb 2> :
init ();
geta (&a, &ga);
_1 = a.ax;
if (_1 != 3735928559)
goto <bb 3>; [INV]
else
goto <bb 4>; [INV]
<bb 3> :
__builtin_abort ();
<bb 4> :
__builtin_abort ();
}
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
2024-04-09 18:54 ` [Bug lto/114662] " ewlu at rivosinc dot com
2024-04-10 5:56 ` linkw at gcc dot gnu.org
@ 2024-04-10 6:26 ` linkw at gcc dot gnu.org
2024-04-10 8:01 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: linkw at gcc dot gnu.org @ 2024-04-10 6:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
Kewen Lin <linkw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|lto |testsuite
Target Milestone|--- |14.0
Keywords| |testsuite-fail
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2024-04-10 6:26 ` [Bug testsuite/114662] " linkw at gcc dot gnu.org
@ 2024-04-10 8:01 ` cvs-commit at gcc dot gnu.org
2024-04-10 8:04 ` linkw at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-04-10 8:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:
https://gcc.gnu.org/g:4923ed49b93352bcf9e43cafac38345e4a54c3f8
commit r14-9886-g4923ed49b93352bcf9e43cafac38345e4a54c3f8
Author: Kewen Lin <linkw@linux.ibm.com>
Date: Wed Apr 10 02:59:43 2024 -0500
testsuite: Adjust pr113359-2_*.c with unsigned long long [PR114662]
pr113359-2_*.c define a struct having unsigned long type
members ay and az which have 4 bytes size at -m32, while
the related constants CL1 and CL2 used for equality check
are always 8 bytes, it makes compiler consider the below
69 if (a.ay != CL1)
70 __builtin_abort ();
always to abort and optimize away the following call to
getb, which leads to the expected wpa dumping on
"Semantic equality" missing.
This patch is to modify the types with unsigned long long
accordingly.
PR testsuite/114662
gcc/testsuite/ChangeLog:
* gcc.dg/lto/pr113359-2_0.c: Use unsigned long long instead of
unsigned long.
* gcc.dg/lto/pr113359-2_1.c: Likewise.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2024-04-10 8:01 ` cvs-commit at gcc dot gnu.org
@ 2024-04-10 8:04 ` linkw at gcc dot gnu.org
2024-04-10 9:24 ` jamborm at gcc dot gnu.org
2024-05-21 15:47 ` cvs-commit at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: linkw at gcc dot gnu.org @ 2024-04-10 8:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
Kewen Lin <linkw at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Kewen Lin <linkw at gcc dot gnu.org> ---
Should be fixed on latest trunk.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2024-04-10 8:04 ` linkw at gcc dot gnu.org
@ 2024-04-10 9:24 ` jamborm at gcc dot gnu.org
2024-05-21 15:47 ` cvs-commit at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-04-10 9:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Thanks a lot for taking care of it before I had a chance to.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails
2024-04-09 18:22 [Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails seurer at gcc dot gnu.org
` (5 preceding siblings ...)
2024-04-10 9:24 ` jamborm at gcc dot gnu.org
@ 2024-05-21 15:47 ` cvs-commit at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-05-21 15:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662
--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:
https://gcc.gnu.org/g:c827f46d8652d7a089e614302a4cffb6b192284d
commit r13-8785-gc827f46d8652d7a089e614302a4cffb6b192284d
Author: Kewen Lin <linkw@linux.ibm.com>
Date: Wed Apr 10 02:59:43 2024 -0500
testsuite: Adjust pr113359-2_*.c with unsigned long long [PR114662]
pr113359-2_*.c define a struct having unsigned long type
members ay and az which have 4 bytes size at -m32, while
the related constants CL1 and CL2 used for equality check
are always 8 bytes, it makes compiler consider the below
69 if (a.ay != CL1)
70 __builtin_abort ();
always to abort and optimize away the following call to
getb, which leads to the expected wpa dumping on
"Semantic equality" missing.
This patch is to modify the types with unsigned long long
accordingly.
PR testsuite/114662
gcc/testsuite/ChangeLog:
* gcc.dg/lto/pr113359-2_0.c: Use unsigned long long instead of
unsigned long.
* gcc.dg/lto/pr113359-2_1.c: Likewise.
(cherry picked from commit 4923ed49b93352bcf9e43cafac38345e4a54c3f8)
^ permalink raw reply [flat|nested] 8+ messages in thread