[Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[Bug lto/114662] New: [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

            Bug ID: 114662
           Summary: [14 regression] new test case c_lto_pr113359-2 from
                    r14-9841-g1e3312a25a7b34 fails
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:1e3312a25a7b34d6e3f549273e1674c7114e4408, r14-9841-g1e3312a25a7b34

I am seeing this on our big endian machines for -m32


 make  -k check-gcc RUNTESTFLAGS="--target_board=unix'{-m32}' lto.exp=*"

FAIL: gcc-dg-lto-pr113359-2-01.exe scan-wpa-ipa-dump icf "Semantic equality
hit:geta/.*getb/"
FAIL: gcc.dg/lto/pr113359-2 c_lto_pr113359-2_0.o assemble, -O2 -flto
-fno-strict-aliasing -fno-ipa-cp  --disable-tree-esra -fdump-ipa-icf-details 
FAIL: gcc.dg/lto/pr113359-2 c_lto_pr113359-2_0.o-c_lto_pr113359-2_1.o execute
-O2 -flto -fno-strict-aliasing -fno-ipa-cp  --disable-tree-esra
-fdump-ipa-icf-details 


commit 1e3312a25a7b34d6e3f549273e1674c7114e4408 (HEAD)
Author: Martin Jambor <mjambor@suse.cz>
Date:   Mon Apr 8 18:53:23 2024 +0200

    ICF&SRA: Make ICF and SRA agree on padding

[Bug lto/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[ewlu at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

Edwin Lu <ewlu at rivosinc dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ewlu at rivosinc dot com,
                   |                            |patrick at rivosinc dot com

--- Comment #1 from Edwin Lu <ewlu at rivosinc dot com> ---
We are also seeing this for rv32 targets on linux and newlib
https://github.com/patrick-rivos/gcc-postcommit-ci/issues/746#issuecomment-2045727038

[Bug lto/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |linkw at gcc dot gnu.org
                 CC|                            |linkw at gcc dot gnu.org
   Last reconfirmed|                            |2024-04-10
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #2 from Kewen Lin <linkw at gcc dot gnu.org> ---
I think this is a test issue, with -m32 unsigned long is 4 bytes while CL1,CL2
are 8 bytes constants, then it considers some checks would always fail and the
abort will happen, since the optimization aggressively optimize away the call
to getb, there is no chance to further check "semantic equality". The IR for
main at *.015t.cfg looks like:

int main (int argc, char * * argv)
{
  struct SB b;
  struct SA a;
  int D.3983;

  <bb 2> :
  init ();
  geta (&a, &ga);
  _1 = a.ax;
  if (_1 != 3735928559)
    goto <bb 3>; [INV]
  else
    goto <bb 4>; [INV]

  <bb 3> :
  __builtin_abort ();

  <bb 4> :
  __builtin_abort ();

}

[Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|lto                         |testsuite
   Target Milestone|---                         |14.0
           Keywords|                            |testsuite-fail

[Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:4923ed49b93352bcf9e43cafac38345e4a54c3f8

commit r14-9886-g4923ed49b93352bcf9e43cafac38345e4a54c3f8
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Wed Apr 10 02:59:43 2024 -0500

    testsuite: Adjust pr113359-2_*.c with unsigned long long [PR114662]

    pr113359-2_*.c define a struct having unsigned long type
    members ay and az which have 4 bytes size at -m32, while
    the related constants CL1 and CL2 used for equality check
    are always 8 bytes, it makes compiler consider the below

      69   if (a.ay != CL1)
      70     __builtin_abort ();

    always to abort and optimize away the following call to
    getb, which leads to the expected wpa dumping on
    "Semantic equality" missing.

    This patch is to modify the types with unsigned long long
    accordingly.

            PR testsuite/114662

    gcc/testsuite/ChangeLog:

            * gcc.dg/lto/pr113359-2_0.c: Use unsigned long long instead of
            unsigned long.
            * gcc.dg/lto/pr113359-2_1.c: Likewise.

[Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Kewen Lin <linkw at gcc dot gnu.org> ---
Should be fixed on latest trunk.

[Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Thanks a lot for taking care of it before I had a chance to.

[Bug testsuite/114662] [14 regression] new test case c_lto_pr113359-2 from r14-9841-g1e3312a25a7b34 fails

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114662

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:c827f46d8652d7a089e614302a4cffb6b192284d

commit r13-8785-gc827f46d8652d7a089e614302a4cffb6b192284d
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Wed Apr 10 02:59:43 2024 -0500

    testsuite: Adjust pr113359-2_*.c with unsigned long long [PR114662]

    pr113359-2_*.c define a struct having unsigned long type
    members ay and az which have 4 bytes size at -m32, while
    the related constants CL1 and CL2 used for equality check
    are always 8 bytes, it makes compiler consider the below

      69   if (a.ay != CL1)
      70     __builtin_abort ();

    always to abort and optimize away the following call to
    getb, which leads to the expected wpa dumping on
    "Semantic equality" missing.

    This patch is to modify the types with unsigned long long
    accordingly.

            PR testsuite/114662

    gcc/testsuite/ChangeLog:

            * gcc.dg/lto/pr113359-2_0.c: Use unsigned long long instead of
            unsigned long.
            * gcc.dg/lto/pr113359-2_1.c: Likewise.

    (cherry picked from commit 4923ed49b93352bcf9e43cafac38345e4a54c3f8)