* [Bug tree-optimization/114792] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
@ 2024-04-21 15:33 ` hjl.tools at gmail dot com
2024-04-21 20:25 ` [Bug tree-optimization/114792] [14 Regression] " pinskia at gcc dot gnu.org
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: hjl.tools at gmail dot com @ 2024-04-21 15:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2024-04-21
CC| |jh at suse dot cz
Ever confirmed|0 |1
Version|unknown |14.0
Status|UNCONFIRMED |NEW
--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
It is caused by r14-301.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
2024-04-21 15:33 ` [Bug tree-optimization/114792] " hjl.tools at gmail dot com
@ 2024-04-21 20:25 ` pinskia at gcc dot gnu.org
2024-04-21 20:26 ` pinskia at gcc dot gnu.org
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-04-21 20:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pinskia at gcc dot gnu.org
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
2024-04-21 15:33 ` [Bug tree-optimization/114792] " hjl.tools at gmail dot com
2024-04-21 20:25 ` [Bug tree-optimization/114792] [14 Regression] " pinskia at gcc dot gnu.org
@ 2024-04-21 20:26 ` pinskia at gcc dot gnu.org
2024-04-22 7:17 ` jakub at gcc dot gnu.org
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-04-21 20:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (2 preceding siblings ...)
2024-04-21 20:26 ` pinskia at gcc dot gnu.org
@ 2024-04-22 7:17 ` jakub at gcc dot gnu.org
2024-04-24 13:04 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-04-22 7:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
Priority|P3 |P1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (3 preceding siblings ...)
2024-04-22 7:17 ` jakub at gcc dot gnu.org
@ 2024-04-24 13:04 ` rguenth at gcc dot gnu.org
2024-04-24 13:05 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-04-24 13:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rguenth at gcc dot gnu.org
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
The issue is that unloop_loops doesn't work when to unloop loops are nested.
The unroller takes great care of working on a single loop level at a time,
cleaning up the CFG and fixing loops inbetween but we fail to ensure this here.
unlooping in CH is somewhat a wrong tool for the wrong task as it doesn't
adhere to constraints present. There's the possibility this can be salvaged by
making unloop_loops more robust, in particular computing loop bodies (Which is
fragile) up-front.
But it would be much nicer if unlooping would simply add __builtin_unreachable
() as the first stmt into the latch and leave the rest to CFG cleanup.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (4 preceding siblings ...)
2024-04-24 13:04 ` rguenth at gcc dot gnu.org
@ 2024-04-24 13:05 ` rguenth at gcc dot gnu.org
2024-04-25 5:45 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-04-24 13:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 58024
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58024&action=edit
patch
I quickly tried this which works for the testcase but I'm sure it'll break
quickly.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (5 preceding siblings ...)
2024-04-24 13:05 ` rguenth at gcc dot gnu.org
@ 2024-04-25 5:45 ` rguenth at gcc dot gnu.org
2024-04-25 6:13 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-04-25 5:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #4)
> Created attachment 58024 [details]
> patch
>
> I quickly tried this which works for the testcase but I'm sure it'll break
> quickly.
during GIMPLE pass: cunrolli
../../../../gcc/libgcc/soft-fp/floatsitf.c: In function '__floatsitf':
../../../../gcc/libgcc/soft-fp/floatsitf.c:34:1: internal compiler error: in
unloop_loops, at tree-ssa-loop-ivcanon.cc:721
34 | __floatsitf (SItype i)
| ^~~~~~~~~~~
0x76cde9 _start
../sysdeps/x86_64/start.S:120
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (6 preceding siblings ...)
2024-04-25 5:45 ` rguenth at gcc dot gnu.org
@ 2024-04-25 6:13 ` rguenth at gcc dot gnu.org
2024-04-25 6:14 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-04-25 6:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Status|NEW |ASSIGNED
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (7 preceding siblings ...)
2024-04-25 6:13 ` rguenth at gcc dot gnu.org
@ 2024-04-25 6:14 ` rguenth at gcc dot gnu.org
2024-04-25 13:20 ` cvs-commit at gcc dot gnu.org
2024-04-25 13:21 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-04-25 6:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #58024|0 |1
is obsolete| |
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 58033
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=58033&action=edit
patch
I'm now testing this which is more minimal surgery at least making sure we
process loops in similar order as unrolling does. I'm not 100% convinced this
is enough but it restores part of the consistency (unroll also doesn't unloop
an outer loop before cleaning up the CFG and rebuilding loops after unlooping
an inner loop).
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (8 preceding siblings ...)
2024-04-25 6:14 ` rguenth at gcc dot gnu.org
@ 2024-04-25 13:20 ` cvs-commit at gcc dot gnu.org
2024-04-25 13:21 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-04-25 13:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:59ff81835fee22a9d4c9a481a4d1814583aae945
commit r14-10120-g59ff81835fee22a9d4c9a481a4d1814583aae945
Author: Richard Biener <rguenther@suse.de>
Date: Thu Apr 25 08:08:24 2024 +0200
tree-optimization/114792 - order loops to unloops in CH
When we use unloop_loops we have to make sure to have loops ordered
inner to outer as otherwise we can wreck inner loop structure where
unlooping relies on that being intact. The following re-sorts the
vector of to unloop loops after copy-header as that adds to the
vector in two places and the wrong order.
PR tree-optimization/114792
* tree-ssa-loop-ch.cc (ch_order_loops): New function.
(ch_base::copy_headers): Sort loops to unloop inner-to-outer.
* gcc.dg/torture/pr114792.c: New testcase.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Bug tree-optimization/114792] [14 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903
2024-04-21 11:39 [Bug tree-optimization/114792] New: ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-copy-prop" on x86_64-linux-gnu: in get_loop_body, at cfgloop.cc:903 zhendong.su at inf dot ethz.ch
` (9 preceding siblings ...)
2024-04-25 13:20 ` cvs-commit at gcc dot gnu.org
@ 2024-04-25 13:21 ` rguenth at gcc dot gnu.org
10 siblings, 0 replies; 12+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-04-25 13:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114792
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 12+ messages in thread