[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I would like to suggest closing this bug. I don't think we should rename
__gnu_cxx::char_traits, it uses a reserved name. I don't think there is
anything wrong with e.g. __debug::vector or __gnu_cxx::char_traits and we
shouldn't pick ugly names to avoid problems for users who abuse
using-directives.

Changing status to WAITING to start the timer, but if I don't hear otherwise
then I'll close it.

[Bug libstdc++/24537] New: Non-uglified names inside namespace __gnu_cxx

[pcarlini at suse dot de]

This is to keep track of this issue:

  http://gcc.gnu.org/ml/libstdc++/2005-10/msg00077.html

In short, there is a small issue, with __gnu_cxx::char_traits (actually, we
should do an audit), and a larger issue with the legacy HP/SGI free functions
included via headers like <ext/algorithm>, <ext/memory>...


-- 
           Summary: Non-uglified names inside namespace __gnu_cxx
           Product: gcc
           Version: 4.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: pcarlini at suse dot de


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[pinskia at gcc dot gnu dot org]

------- Comment #1 from pinskia at gcc dot gnu dot org  2005-10-26 12:34 -------
Seems like to me, this is what namespaces are for anyways?  and non-uglified
names are correct, maybe it needs to be a different namespace like
__gnu_cxx::__implemenation instead which seems like the more correct thing to
do than uglify names.  I think this is what Boost does too.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[pcarlini at suse dot de]

------- Comment #2 from pcarlini at suse dot de  2005-10-26 12:37 -------
(In reply to comment #1)
> Seems like to me, this is what namespaces are for anyways?  and non-uglified
> names are correct, maybe it needs to be a different namespace like
> __gnu_cxx::__implemenation instead which seems like the more correct thing to
> do than uglify names.  I think this is what Boost does too.

Indeed, the idea is using namespaces. But seems much more clean to me using
separate namespaces, not nested ones, for our problem: __gnu_cxx for new
extensions and __gnu_legacy for legacy extensions. The implementation proper
bits are instead already inside __gnu_internal.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[bkoz at gcc dot gnu dot org]

------- Comment #3 from bkoz at gcc dot gnu dot org  2005-10-27 06:04 -------

Naming wise I think __gnu_ext makes more sense. It's what we should have used
for the extension namespace from the beginning.

-benjamin


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[pcarlini at suse dot de]

------- Comment #4 from pcarlini at suse dot de  2005-10-27 09:07 -------
(In reply to comment #3)
> Naming wise I think __gnu_ext makes more sense. It's what we should have used
> for the extension namespace from the beginning.

Of course I'm ok with __gnu_ext. Actually, I'm ok with anything you would
rather prefer, __gnu_legacy was just an example, meant to make totally
clear (for argumentation purposes too) that we are talking about legacy
stuff, indeed.

Anyway, when I will actually prepare a patch, it will move the old HP/SGI
facilities to namespace __gnu_ext, agreed.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[pinskia at gcc dot gnu dot org]

------- Comment #5 from pinskia at gcc dot gnu dot org  2005-10-27 21:55 -------
Confirmed.


-- 

pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1
   Last reconfirmed|0000-00-00 00:00:00         |2005-10-27 21:55:03
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537

[Bug libstdc++/24537] Non-uglified names inside namespace __gnu_cxx

[bkoz at gcc dot gnu dot org]

------- Comment #6 from bkoz at gcc dot gnu dot org  2006-11-21 10:48 -------

Thanks P for this. 

I would be interested in seeing this audit.

I think moving __gnu_cxx::char_traits to __gnu_cxx::__char_traits is something
that should be seriously considered for gcc/gcc-4_2-branch. 

I'm currently working through the issues with new doxygen, as part of this I've
made some documentation changes WRT namespace usage that will hopefully make
things easier to understand.

I'm hoping to have this done soon-ish.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24537