public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/30271] -mstrict-align can an store extra for struct agrument passing [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/> @ 2020-05-21 6:15 ` luoxhu at gcc dot gnu.org 2023-12-08 11:01 ` guojiufu at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 5+ messages in thread From: luoxhu at gcc dot gnu.org @ 2020-05-21 6:15 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271 luoxhu at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luoxhu at gcc dot gnu.org --- Comment #12 from luoxhu at gcc dot gnu.org --- Fixed at least from GCC 4.9.4? $ /opt/at8.0/bin/gcc -O3 -c -S pr30271.c -mstrict-align $ cat pr30271.s .file "pr30271.c" .abiversion 2 .section ".toc","aw" .section ".text" .align 2 .p2align 4,,15 .globl f .type f, @function f: extsh 9,3 srawi 3,3,16 add 3,9,3 extsw 3,3 blr .long 0 .byte 0,0,0,0,0,0,0,0 .size f,.-f .ident "GCC: (GNU) 4.9.4 20150824 (Advance-Toolchain-at8.0) [ibm/gcc-4_9-branch, revision: 227153 merged from gcc-4_9-branch, revision 227151]" .section .note.GNU-stack,"",@progbits ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/30271] -mstrict-align can an store extra for struct agrument passing [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/> 2020-05-21 6:15 ` [Bug target/30271] -mstrict-align can an store extra for struct agrument passing luoxhu at gcc dot gnu.org @ 2023-12-08 11:01 ` guojiufu at gcc dot gnu.org 2023-12-19 5:18 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 5+ messages in thread From: guojiufu at gcc dot gnu.org @ 2023-12-08 11:01 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271 Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guojiufu at gcc dot gnu.org --- Comment #13 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> --- (In reply to Andrew Pinski from comment #10) > (In reply to comment #9) > > Andrew, > > > > What is your point here? > > My point here is that currently we do: > gi->frame_related = > (base == frame_pointer_rtx) || (base == hard_frame_pointer_rtx); > > But if we change it to be: > gi->frame_related = > (base == frame_pointer_rtx) || (base == hard_frame_pointer_rtx) > || (base == arg_pointer_rtx && fixed_regs[ARG_POINTER_REGNUM]); > > It would delete the store (at least in a 4.3 based compiler). > arg_pointer_rtx is the incoming argument space so if it is a fixed register > it will be also frame related and we can safely delete the stores to this > space. https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639550.html is using this idea too. And the 'std' in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271#c2 disappeared. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/30271] -mstrict-align can an store extra for struct agrument passing [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/> 2020-05-21 6:15 ` [Bug target/30271] -mstrict-align can an store extra for struct agrument passing luoxhu at gcc dot gnu.org 2023-12-08 11:01 ` guojiufu at gcc dot gnu.org @ 2023-12-19 5:18 ` cvs-commit at gcc dot gnu.org 2024-01-04 1:06 ` [Bug target/30271] -mstrict-align can add an store extra for struct argument passing guojiufu at gcc dot gnu.org 2024-01-20 17:13 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 5+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2023-12-19 5:18 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271 --- Comment #14 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jiu Fu Guo <guojiufu@gcc.gnu.org>: https://gcc.gnu.org/g:4759383245ac97a5c83c0272f0a831f2a26ea5c1 commit r14-6674-g4759383245ac97a5c83c0272f0a831f2a26ea5c1 Author: Jiufu Guo <guojiufu@linux.ibm.com> Date: Tue Dec 19 13:03:06 2023 +0800 treat argp-based mem as frame related in dse The issue mentioned in PR112525 would be able to be handled by updating dse.cc to treat arg_pointer_rtx similarly with frame_pointer_rtx. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271#c10 also mentioned this idea. And arpg area may be used to pass argument to callee. So, it would be needed to check if call insns are using that mem. PR rtl-optimization/112525 PR target/30271 gcc/ChangeLog: * dse.cc (get_group_info): Add arg_pointer_rtx as frame_related. (check_mem_read_rtx): Add parameter to indicate if it is checking mem for call insn. (scan_insn): Add mem checking on call usage. gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr112525.c: New test. * gcc.target/powerpc/pr30271.c: New test. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/30271] -mstrict-align can add an store extra for struct argument passing [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/> ` (2 preceding siblings ...) 2023-12-19 5:18 ` cvs-commit at gcc dot gnu.org @ 2024-01-04 1:06 ` guojiufu at gcc dot gnu.org 2024-01-20 17:13 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 5+ messages in thread From: guojiufu at gcc dot gnu.org @ 2024-01-04 1:06 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271 Jiu Fu Guo <guojiufu at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #15 from Jiu Fu Guo <guojiufu at gcc dot gnu.org> --- Fix was committed. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/30271] -mstrict-align can add an store extra for struct argument passing [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/> ` (3 preceding siblings ...) 2024-01-04 1:06 ` [Bug target/30271] -mstrict-align can add an store extra for struct argument passing guojiufu at gcc dot gnu.org @ 2024-01-20 17:13 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 5+ messages in thread From: pinskia at gcc dot gnu.org @ 2024-01-20 17:13 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30271 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |14.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-20 17:13 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <bug-30271-4@http.gcc.gnu.org/bugzilla/> 2020-05-21 6:15 ` [Bug target/30271] -mstrict-align can an store extra for struct agrument passing luoxhu at gcc dot gnu.org 2023-12-08 11:01 ` guojiufu at gcc dot gnu.org 2023-12-19 5:18 ` cvs-commit at gcc dot gnu.org 2024-01-04 1:06 ` [Bug target/30271] -mstrict-align can add an store extra for struct argument passing guojiufu at gcc dot gnu.org 2024-01-20 17:13 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).