[Bug middle-end/44102] ICE with asm goto + __builtin_unreachable () in C++

[Bug middle-end/44102] ICE with asm goto + __builtin_unreachable () in C++

[steven at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44102

Steven Bosscher <steven at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2012-11-30
                 CC|                            |steven at gcc dot gnu.org
         Resolution|FIXED                       |
     Ever Confirmed|0                           |1

--- Comment #3 from Steven Bosscher <steven at gcc dot gnu.org> 2012-11-30 14:19:29 UTC ---
This fix is wrong.
(http://gcc.gnu.org/viewcvs?view=revision&revision=159495)

There is a check at the start of cleanup_cfg to always set the
CLEANUP_CFGLAYOUT flag whenever we're in cfglayout mode:

120893     steven   /* Set the cfglayout mode flag here.  We could update all
the callers
120893     steven      but that is just inconvenient, especially given that we
eventually
120893     steven      want to have cfglayout mode as the default.  */
120893     steven   if (current_ir_type () == IR_RTL_CFGLAYOUT)
120893     steven     mode |= CLEANUP_CFGLAYOUT;
120893     steven


So this part of your fix:

-          if ((mode & CLEANUP_CFGLAYOUT)
+              if (current_ir_type () == IR_RTL_CFGLAYOUT)

is incorrect.

[Bug middle-end/44102] ICE with asm goto + __builtin_unreachable () in C++

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44102

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Steven Bosscher from comment #3)
> This fix is wrong.
> (http://gcc.gnu.org/viewcvs?view=revision&revision=159495)
> 
> There is a check at the start of cleanup_cfg to always set the
> CLEANUP_CFGLAYOUT flag whenever we're in cfglayout mode:
> 
> 120893     steven   /* Set the cfglayout mode flag here.  We could update
> all the callers
> 120893     steven      but that is just inconvenient, especially given that
> we eventually
> 120893     steven      want to have cfglayout mode as the default.  */
> 120893     steven   if (current_ir_type () == IR_RTL_CFGLAYOUT)
> 120893     steven     mode |= CLEANUP_CFGLAYOUT;
> 120893     steven
> 
> 
> So this part of your fix:
> 
> -		  if ((mode & CLEANUP_CFGLAYOUT)
> +		      if (current_ir_type () == IR_RTL_CFGLAYOUT)
> 
> is incorrect.

So the way I read this is that the fix is not wrong, just it uses the new check
instead of the old way. Now I am not sure what about the status of always using
cfglayout because what I remember is that is used all the way until post
reload(RA) now.

[Bug middle-end/44102] ICE with asm goto + __builtin_unreachable () in C++

[jakub at gcc dot gnu dot org]

------- Comment #2 from jakub at gcc dot gnu dot org  2010-05-17 17:34 -------
On branches/gcc-4_5-branch fixed by
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=159499


-- 

jakub at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44102

[Bug middle-end/44102] ICE with asm goto + __builtin_unreachable () in C++

[jakub at gcc dot gnu dot org]

------- Comment #1 from jakub at gcc dot gnu dot org  2010-05-17 17:18 -------
Subject: Bug 44102

Author: jakub
Date: Mon May 17 17:18:24 2010
New Revision: 159495

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=159495
Log:
        PR middle-end/44102
        * cfgcleanup.c (try_optimize_cfg): When removing trivially empty
        bb with no successors, move footer whenever in IR_RTL_CFGLAYOUT
        mode, not just when CLEANUP_CFGLAYOUT, and when in IR_RTL_CFGRTL
        add BARRIER after previous bb if needed.

        * g++.dg/ext/asmgoto1.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/ext/asmgoto1.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgcleanup.c
    trunk/gcc/testsuite/ChangeLog


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44102