public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug preprocessor/44652] Column numbers in error messages are wrong
[not found] <bug-44652-4@http.gcc.gnu.org/bugzilla/>
@ 2021-09-02 1:48 ` pinskia at gcc dot gnu.org
2021-09-02 1:52 ` pinskia at gcc dot gnu.org
2021-09-02 2:07 ` pinskia at gcc dot gnu.org
2 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-02 1:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to fail| |7.5.0
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So we don't display the column any more:
In file included from t.c:2:
structdef.h:5:3: error: expected ‘:’, ‘,’, ‘;’, ‘}’ or ‘__attribute__’ before
‘unsigned’
5 | unsigned int b:5;
| ^~~~~~~~
Let me figure out when it happened.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug preprocessor/44652] Column numbers in error messages are wrong
[not found] <bug-44652-4@http.gcc.gnu.org/bugzilla/>
2021-09-02 1:48 ` [Bug preprocessor/44652] Column numbers in error messages are wrong pinskia at gcc dot gnu.org
@ 2021-09-02 1:52 ` pinskia at gcc dot gnu.org
2021-09-02 2:07 ` pinskia at gcc dot gnu.org
2 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-02 1:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |diagnostic
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
We removed the column of 0 by r11-2092.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug preprocessor/44652] Column numbers in error messages are wrong
[not found] <bug-44652-4@http.gcc.gnu.org/bugzilla/>
2021-09-02 1:48 ` [Bug preprocessor/44652] Column numbers in error messages are wrong pinskia at gcc dot gnu.org
2021-09-02 1:52 ` pinskia at gcc dot gnu.org
@ 2021-09-02 2:07 ` pinskia at gcc dot gnu.org
2 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-02 2:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
where = linemap_included_from (map);
map = linemap_included_from_linemap (line_table, map);
bool is_module = MAP_MODULE_P (map);
s.file = LINEMAP_FILE (map);
s.line = SOURCE_LINE (map, where);
int col = -1;
if (first && context->show_column)
{
s.column = SOURCE_COLUMN (map, where);
col = diagnostic_converted_column (context, s);
}
first is true so the column info must be missing from the preprocessor.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug preprocessor/44652] Column numbers in error messages are wrong
2010-06-24 8:29 [Bug preprocessor/44652] New: " hariharans at picochip dot com
` (2 preceding siblings ...)
2010-06-24 8:34 ` pinskia at gcc dot gnu dot org
@ 2010-06-24 12:03 ` manu at gcc dot gnu dot org
3 siblings, 0 replies; 7+ messages in thread
From: manu at gcc dot gnu dot org @ 2010-06-24 12:03 UTC (permalink / raw)
To: gcc-bugs
------- Comment #4 from manu at gcc dot gnu dot org 2010-06-24 12:03 -------
(In reply to comment #3)
> I think column 0 is correct for the start of all preprocessor directives.
But the #include does not start at column 0, so there is something wrong there.
We know that libcpp column information sucks in many places. Tom and I have
several patches but we never got around to finish them.
To not get column info just use -fno-show-column
--
manu at gcc dot gnu dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |manu at gcc dot gnu dot org
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
Last reconfirmed|0000-00-00 00:00:00 |2010-06-24 12:03:06
date| |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug preprocessor/44652] Column numbers in error messages are wrong
2010-06-24 8:29 [Bug preprocessor/44652] New: " hariharans at picochip dot com
2010-06-24 8:30 ` [Bug preprocessor/44652] " hariharans at picochip dot com
2010-06-24 8:31 ` hariharans at picochip dot com
@ 2010-06-24 8:34 ` pinskia at gcc dot gnu dot org
2010-06-24 12:03 ` manu at gcc dot gnu dot org
3 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2010-06-24 8:34 UTC (permalink / raw)
To: gcc-bugs
------- Comment #3 from pinskia at gcc dot gnu dot org 2010-06-24 08:34 -------
I think column 0 is correct for the start of all preprocessor directives.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug preprocessor/44652] Column numbers in error messages are wrong
2010-06-24 8:29 [Bug preprocessor/44652] New: " hariharans at picochip dot com
2010-06-24 8:30 ` [Bug preprocessor/44652] " hariharans at picochip dot com
@ 2010-06-24 8:31 ` hariharans at picochip dot com
2010-06-24 8:34 ` pinskia at gcc dot gnu dot org
2010-06-24 12:03 ` manu at gcc dot gnu dot org
3 siblings, 0 replies; 7+ messages in thread
From: hariharans at picochip dot com @ 2010-06-24 8:31 UTC (permalink / raw)
To: gcc-bugs
------- Comment #2 from hariharans at picochip dot com 2010-06-24 08:30 -------
Created an attachment (id=20992)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20992&action=view)
struct definition header file
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug preprocessor/44652] Column numbers in error messages are wrong
2010-06-24 8:29 [Bug preprocessor/44652] New: " hariharans at picochip dot com
@ 2010-06-24 8:30 ` hariharans at picochip dot com
2010-06-24 8:31 ` hariharans at picochip dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: hariharans at picochip dot com @ 2010-06-24 8:30 UTC (permalink / raw)
To: gcc-bugs
------- Comment #1 from hariharans at picochip dot com 2010-06-24 08:30 -------
Created an attachment (id=20991)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=20991&action=view)
c file
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44652
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-02 2:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <bug-44652-4@http.gcc.gnu.org/bugzilla/>
2021-09-02 1:48 ` [Bug preprocessor/44652] Column numbers in error messages are wrong pinskia at gcc dot gnu.org
2021-09-02 1:52 ` pinskia at gcc dot gnu.org
2021-09-02 2:07 ` pinskia at gcc dot gnu.org
2010-06-24 8:29 [Bug preprocessor/44652] New: " hariharans at picochip dot com
2010-06-24 8:30 ` [Bug preprocessor/44652] " hariharans at picochip dot com
2010-06-24 8:31 ` hariharans at picochip dot com
2010-06-24 8:34 ` pinskia at gcc dot gnu dot org
2010-06-24 12:03 ` manu at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).