[Bug fortran/48244] New: iso-c-binding support missing on NetBSD (with patch)

[Bug fortran/48244] New: iso-c-binding support missing on NetBSD (with patch)

[kuehro at gmx dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

           Summary: iso-c-binding support missing on NetBSD (with patch)
           Product: gcc
           Version: 4.5.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: kuehro@gmx.de


Created attachment 23752
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23752
add netbsd-stdint.h to config.gcc

The following patches add iso-c-binding support to gfortran on NetBSD (5.1
and current both i386 and amd64) by reusing the relevant parts from freebsd.

First one needs to copy gcc/config/freebsd-stdint.h to
gcc/config/netbsd-stdint.h
and then apply the attached patch against the gcc-4.5.2 release. This passes
all relevant tests without causing any regression. It also worked on a real
world code (xraylib-2.13.1). gfortran was built with:

gfortran -v:
Using built-in specs.
COLLECT_GCC=/usr/pkg/gcc45/bin/gfortran
COLLECT_LTO_WRAPPER=/usr/pkg/gcc45/libexec/gcc/x86_64-unknown-netbsd5.99.47/4.5.2/lto-wrapper
Target: x86_64-unknown-netbsd5.99.47
Configured with: /usr/pkgsrc/wip/gcc45/work/gcc-4.5.2/configure --enable-nls
--prefix=/usr/pkg/gcc45 --enable-languages='c c++ fortran objc'
--with-system-zlib --enable-shared --enable-__cxa_atexit --enable-long-long
--with-local-prefix=/usr/pkg/gcc45 --disable-libssp --enable-threads=posix
--with-gmp=/usr/pkg --with-mpfr=/usr/pkg --with-ld=/usr/pkg/bin/gnu-ld
--with-libelf=/usr/pkg
Thread model: posix
gcc version 4.5.2 (GCC) 


A patch for the cabs issue (as described in PR 39570) was also applied,
otherwise all fortran tests would fail due to a runtime warning. If someone
wants to test on NetBSD please use wip/gcc45 from pkgsrc-wip.sourceforge.net.

I can supply additional information if necessary. Thanks to everyone who
was involved to make this work on FreeBSD.

Kai-Uwe Eckhardt

Re: [Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[Krister Walfridsson]

> --- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Is there still maintainers/users of NetBSD?

There are still users.  But my paperwork is not in order since I
changed employer some years ago, so I am not allowed to commit
anything... :(

   /Krister

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[krister.walfridsson at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #2 from krister.walfridsson at gmail dot com ---
> --- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Is there still maintainers/users of NetBSD?

There are still users.  But my paperwork is not in order since I
changed employer some years ago, so I am not allowed to commit
anything... :(

   /Krister

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[kuehro at gmx dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

Kai-Uwe Eckhardt <kuehro at gmx dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23752|0                           |1
        is obsolete|                            |

--- Comment #3 from Kai-Uwe Eckhardt <kuehro at gmx dot de> ---
Created attachment 30452
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30452&action=edit
Add netbsd-stdint.h to config.gcc for gcc-4.9

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[kuehro at gmx dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #4 from Kai-Uwe Eckhardt <kuehro at gmx dot de> ---
I have updated the patch for snapshot 4.9-20130630. 
If Gerald Pfeifer agrees to create a copy of freebsd-stdint.h and to keep
the copyright line as is, then this could be done easily by someone with
commit right.

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Any progress?

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[kuehro at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #6 from Kai-Uwe Eckhardt <kuehro at gmx dot de> ---
> --- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Any progress?

Gerald Pfeifer offered to help, but somehow it slipped through. The
patch still works for the latest 5.0 snapshot 20141130:

> Hi Kai-Uwe, 
> On Thu, 4 Jul 2013, Kai-Uwe Eckhardt wrote: 
>
>> in order to fix gcc bug 48244, a copy of gcc/config/freebsd-stdint.h to 
>> gcc/config/netbsd-stdint.h is necessary. I am not sure about the legal 
>> aspects, but I would like to ask if you have any objections against 
>> doing a copy and keeping your name as the contributor. I guess you 
>> have commit rights ? If this is the case, it would be very kind if 
>> you could do the commit. 
>
> first of all sorry for the delay in getting back to this. It simply slipped
> through. Sorry! I'm have no objections whatsoever for you to reuse
> freebsd-stdint.h as gcc/config/netbsd-stdint.h and will be happy to commit
> a patch. I assume you'll also need to update config.gcc, similar to what I
> have done in 2009-06-01 Gerald Pfeifer * config/freebsd-stdint.h: New file.
> * config.gcc (*-*-freebsd): Set use_gcc_stdint=wrap. Add freebsd-stdint.h
> to tm_file. How about if you submit a patch for config.gcc and testresults
> (to gcc-testresults@gcc.gnu.org) before and after the desired changes to
> gcc-patches@gcc.gnu.org and copy me? Gerald 

I didn't send testresults to the list because without a dozen patches gcc
won't compile at all. Testresults and necessary patches can be found at 
http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/gcc50snapshot
and gfortran works quite well on NetBSD.

Would it help to send test_summary.log to the testresult mailing list ?

Kai-Uwe

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I didn't send testresults to the list because without a dozen patches gcc
> won't compile at all. 

Did someone opened PRs for these failures? Patches should be submitted to
gcc-patches@gcc.gnu.org (and to fortran@gcc.gnu.org for Fortran or
libstdc++@gcc.gnu.org for libstdc++-v3).

> Testresults and necessary patches can be found at 
> http://pkgsrc-wip.cvs.sourceforge.net/viewvc/pkgsrc-wip/wip/gcc50snapshot
> and gfortran works quite well on NetBSD.

> Would it help to send test_summary.log to the testresult mailing list ?

I am reluctant to post test results with a lot of patches. I think it is better
to post the results with the minimal set of patches to bootstrap, then results
with one or two specific patches you can refer to on the gcc lists.

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[kuehro at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #8 from Kai-Uwe Eckhardt <kuehro at gmx dot de> ---
I found out the minimal set of patches to bootstrap. I will
open a bug report after running the testsuite.

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[kuehro at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #9 from Kai-Uwe Eckhardt <kuehro at gmx dot de> ---
I have submitted the necessary patches and test_result.log as #64271

[Bug fortran/48244] iso-c-binding support missing on NetBSD (with patch)

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

--- Comment #10 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I have submitted the necessary patches and test_result.log as pr64271

Does this mean that this PR can be closed? If yes, with which resolution?

[Bug target/48244] iso-c-binding support missing on NetBSD (with patch)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48244

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |7.0

--- Comment #13 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
One part fof the patch in comment # 3 was committed as r7-4703, the other part
was committed in r7-4638.

So closing as fixed in GCC 7.