public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/51785] gets not anymore declared
Date: Tue, 10 Jan 2012 22:25:00 -0000	[thread overview]
Message-ID: <bug-51785-4-8LbeAjEeCC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51785-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51785

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org

--- Comment #2 from vries at gcc dot gnu.org 2012-01-10 22:24:10 UTC ---
(In reply to comment #1)
> I thought this was fixed in glibc:
> http://sourceware.org/bugzilla/show_bug.cgi?id=13566
> ?

AFAIU GLIBC BZ #13528 was fixed, but there is a new checkin from Ulrich which 
breaks libstdc++ build in a similar way:
...
$ git show c3a87236702cb73be1dada3438bbd3c3934e83f8
commit c3a87236702cb73be1dada3438bbd3c3934e83f8
Author: Ulrich Drepper <drepper@gmail.com>
Date:   Sat Jan 7 10:41:00 2012 -0500

    Do not declare gets in _GNU_SOURCE mode at all

diff --git a/ChangeLog b/ChangeLog
index 8f9558c..f089e19 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2012-01-07  Ulrich Drepper  <drepper@gmail.com>

+       * libio/stdio.h: Do not declare gets at all for _GNU_SOURCE.
+
        * elf/tst-unique3.cc: Add explicit declaration of gets.
        * elf/tst-unique3lib.cc: Likewise.
        * elf/tst-unique3lib2.cc: Likewise.
diff --git a/libio/stdio.h b/libio/stdio.h
index d9cb573..28c98e9 100644
--- a/libio/stdio.h
+++ b/libio/stdio.h
@@ -629,7 +629,7 @@ extern char *fgets (char *__restrict __s, int __n, FILE
*__restrict __stream)
      __wur;

 #if !defined __USE_ISOC11 \
-    || (defined __cplusplus && __cplusplus <= 201103L)
+    || (defined __cplusplus && __cplusplus <= 201103L && !defined __USE_GNU)
 /* Get a newline-terminated string from stdin, removing the newline.
    DO NOT USE THIS FUNCTION!!  There is no limit on how much it will read.
...


  parent reply	other threads:[~2012-01-10 22:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 15:31 [Bug c++/51785] New: " drepper.fsp at gmail dot com
2012-01-07 19:06 ` [Bug c++/51785] " marc.glisse at normalesup dot org
2012-01-10 22:25 ` vries at gcc dot gnu.org [this message]
2012-01-11 13:00 ` vries at gcc dot gnu.org
2012-01-11 13:26 ` [Bug libstdc++/51785] " redi at gcc dot gnu.org
2012-01-11 13:50 ` marc.glisse at normalesup dot org
2012-02-05 20:34 ` jakub at gcc dot gnu.org
2012-02-05 21:00 ` redi at gcc dot gnu.org
2012-02-05 21:27 ` redi at gcc dot gnu.org
2012-02-28 14:46 ` ramana at gcc dot gnu.org
2012-02-28 15:26 ` joseph at codesourcery dot com
2012-02-28 15:38 ` paolo.carlini at oracle dot com
2012-02-28 15:51 ` marc.glisse at normalesup dot org
2012-02-28 15:54 ` jakub at gcc dot gnu.org
2012-02-28 16:14 ` ramana at gcc dot gnu.org
2012-02-28 16:25 ` jakub at gcc dot gnu.org
2012-02-28 17:07 ` paolo.carlini at oracle dot com
2012-02-28 17:08 ` joseph at codesourcery dot com
2012-02-28 18:46 ` paolo.carlini at oracle dot com
2012-03-01  0:23 ` bkoz at gcc dot gnu.org
2012-03-01 13:31 ` jakub at gcc dot gnu.org
2012-03-01 13:45 ` rguenth at gcc dot gnu.org
2012-03-01 13:51 ` redi at gcc dot gnu.org
2012-03-02  6:32 ` bkoz at gcc dot gnu.org
2012-03-02  7:14 ` bkoz at gcc dot gnu.org
2012-03-02  7:30 ` jakub at gcc dot gnu.org
2012-03-09 22:15 ` jsm28 at gcc dot gnu.org
2012-03-09 23:49 ` paolo.carlini at oracle dot com
2021-07-18 18:40 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51785-4-8LbeAjEeCC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).