public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bkoz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/51785] gets not anymore declared
Date: Thu, 01 Mar 2012 00:23:00 -0000	[thread overview]
Message-ID: <bug-51785-4-QhF1i1iHxr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51785-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51785

--- Comment #19 from Benjamin Kosnik <bkoz at gcc dot gnu.org> 2012-03-01 00:21:11 UTC ---
Created attachment 26794
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26794
gets conditionally declared/used


Here's a way to deal with gets that is pretty simple. If it's around at
configure time, it's used. If not, it's dropped from <cstdio>. This uses the
same configure bits and approach used for math.

This should prevent any compile error at bootstrap time. That seems sufficient
for gcc-4.7 release. RMs?

Note, I'm on f17 and I'm not running into this during make/check of trunk gcc. 
If somebody can give me self-contained sources that fail on f17 it would be
appreciated.

Please don't put in GLIBC macros to cstdio. Boo.

Instead, if you need to layer on a glibc part to this, you should start with
this patch, and then conditionally define/undefine _GLIBCXX_HAVE_GETS in 

libstdc++-v3/config/os/gnu-linux/os_defines.h

based on the glibc prerequisites and version checks.

-benjamin


  parent reply	other threads:[~2012-03-01  0:23 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 15:31 [Bug c++/51785] New: " drepper.fsp at gmail dot com
2012-01-07 19:06 ` [Bug c++/51785] " marc.glisse at normalesup dot org
2012-01-10 22:25 ` vries at gcc dot gnu.org
2012-01-11 13:00 ` vries at gcc dot gnu.org
2012-01-11 13:26 ` [Bug libstdc++/51785] " redi at gcc dot gnu.org
2012-01-11 13:50 ` marc.glisse at normalesup dot org
2012-02-05 20:34 ` jakub at gcc dot gnu.org
2012-02-05 21:00 ` redi at gcc dot gnu.org
2012-02-05 21:27 ` redi at gcc dot gnu.org
2012-02-28 14:46 ` ramana at gcc dot gnu.org
2012-02-28 15:26 ` joseph at codesourcery dot com
2012-02-28 15:38 ` paolo.carlini at oracle dot com
2012-02-28 15:51 ` marc.glisse at normalesup dot org
2012-02-28 15:54 ` jakub at gcc dot gnu.org
2012-02-28 16:14 ` ramana at gcc dot gnu.org
2012-02-28 16:25 ` jakub at gcc dot gnu.org
2012-02-28 17:07 ` paolo.carlini at oracle dot com
2012-02-28 17:08 ` joseph at codesourcery dot com
2012-02-28 18:46 ` paolo.carlini at oracle dot com
2012-03-01  0:23 ` bkoz at gcc dot gnu.org [this message]
2012-03-01 13:31 ` jakub at gcc dot gnu.org
2012-03-01 13:45 ` rguenth at gcc dot gnu.org
2012-03-01 13:51 ` redi at gcc dot gnu.org
2012-03-02  6:32 ` bkoz at gcc dot gnu.org
2012-03-02  7:14 ` bkoz at gcc dot gnu.org
2012-03-02  7:30 ` jakub at gcc dot gnu.org
2012-03-09 22:15 ` jsm28 at gcc dot gnu.org
2012-03-09 23:49 ` paolo.carlini at oracle dot com
2021-07-18 18:40 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51785-4-QhF1i1iHxr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).