public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ramana at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/51785] gets not anymore declared
Date: Tue, 28 Feb 2012 16:14:00 -0000	[thread overview]
Message-ID: <bug-51785-4-GklMEREO3O@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51785-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51785

--- Comment #14 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2012-02-28 16:09:52 UTC ---
I can confirm that a build for arm-linux-gnueabi completes and do some
cross-testing on qemu if that's deemed to be enough.

Any other ideas for testing. 

Ramana

Here's a suggestion for the comments in this patch. 

diff --git a/libstdc++-v3/include/c_global/cstdio
b/libstdc++-v3/include/c_global/cstdio
index 049704d..76755ac 100644
--- a/libstdc++-v3/include/c_global/cstdio
+++ b/libstdc++-v3/include/c_global/cstdio
@@ -89,6 +89,17 @@
 #undef vprintf
 #undef vsprintf

+/* glibc 2.15 and later do not declare gets anymore for 
+   ISO C11 mode and if __GNU_SOURCE is defined. See 
+   http://gcc.gnu.org/PR51785 for more on this topic. If
+   this is being changed an equivalent change has to be made
+   in include/c_std/c_stdio.  */
+#if __GLIBC_PREREQ (2,15)
+extern "C" {
+  extern char *gets (char *__s) __attribute__((deprecated));
+}
+#endif
+
 namespace std
 {
   using ::FILE;
diff --git a/libstdc++-v3/include/c_std/cstdio
b/libstdc++-v3/include/c_std/cstdio
index 510f599..29142bb 100644
--- a/libstdc++-v3/include/c_std/cstdio
+++ b/libstdc++-v3/include/c_std/cstdio
@@ -88,6 +88,17 @@
 #undef vprintf
 #undef vsprintf

+/* glibc 2.15 and later do not declare gets anymore for
+   ISO C11 mode and if __GNU_SOURCE is defined. See 
+   http://gcc.gnu.org/PR51785 for more on this topic. If
+   this hunk below is being changed please also investigate
+   the change for include/c_global/cstdio.  */
+#if __GLIBC_PREREQ (2,15)
+extern "C" {
+  extern char *gets (char *__s) __attribute__((deprecated));
+}
+#endif
+
 namespace std
 {
   using ::FILE;


  parent reply	other threads:[~2012-02-28 16:14 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07 15:31 [Bug c++/51785] New: " drepper.fsp at gmail dot com
2012-01-07 19:06 ` [Bug c++/51785] " marc.glisse at normalesup dot org
2012-01-10 22:25 ` vries at gcc dot gnu.org
2012-01-11 13:00 ` vries at gcc dot gnu.org
2012-01-11 13:26 ` [Bug libstdc++/51785] " redi at gcc dot gnu.org
2012-01-11 13:50 ` marc.glisse at normalesup dot org
2012-02-05 20:34 ` jakub at gcc dot gnu.org
2012-02-05 21:00 ` redi at gcc dot gnu.org
2012-02-05 21:27 ` redi at gcc dot gnu.org
2012-02-28 14:46 ` ramana at gcc dot gnu.org
2012-02-28 15:26 ` joseph at codesourcery dot com
2012-02-28 15:38 ` paolo.carlini at oracle dot com
2012-02-28 15:51 ` marc.glisse at normalesup dot org
2012-02-28 15:54 ` jakub at gcc dot gnu.org
2012-02-28 16:14 ` ramana at gcc dot gnu.org [this message]
2012-02-28 16:25 ` jakub at gcc dot gnu.org
2012-02-28 17:07 ` paolo.carlini at oracle dot com
2012-02-28 17:08 ` joseph at codesourcery dot com
2012-02-28 18:46 ` paolo.carlini at oracle dot com
2012-03-01  0:23 ` bkoz at gcc dot gnu.org
2012-03-01 13:31 ` jakub at gcc dot gnu.org
2012-03-01 13:45 ` rguenth at gcc dot gnu.org
2012-03-01 13:51 ` redi at gcc dot gnu.org
2012-03-02  6:32 ` bkoz at gcc dot gnu.org
2012-03-02  7:14 ` bkoz at gcc dot gnu.org
2012-03-02  7:30 ` jakub at gcc dot gnu.org
2012-03-09 22:15 ` jsm28 at gcc dot gnu.org
2012-03-09 23:49 ` paolo.carlini at oracle dot com
2021-07-18 18:40 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51785-4-GklMEREO3O@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).