[Bug c/59006] New: internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[Bug c/59006] New: internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[regehr at cs dot utah.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

            Bug ID: 59006
           Summary: internal compiler error: in vect_transform_stmt, at
                    tree-vect-stmts.c:5963
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: regehr at cs dot utah.edu
                CC: chenyang at cs dot utah.edu

regehr@regehr-M51AC:~/z/reduce/r121$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/home/regehr/z/compiler-install/gcc-r204391-install/libexec/gcc/x86_64-unknown-linux-gnu/4.9.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /home/regehr/z/compiler-source/gcc/configure
--prefix=/home/regehr/z/compiler-install/gcc-r204391-install
--enable-languages=c,c++ --enable-multilib
Thread model: posix
gcc version 4.9.0 20131105 (experimental) (GCC) 
regehr@regehr-M51AC:~/z/reduce/r121$ cat small.c
int a[8], b;

void fn1(void) {
  int c;
  for (; b; b++) {
    int d = a[b];
    c = a[0] ? d : 0;
    a[b] = c;
  }
}
regehr@regehr-M51AC:~/z/reduce/r121$ gcc -O3 small.c -c
small.c: In function ‘fn1’:
small.c:3:6: internal compiler error: in vect_transform_stmt, at
tree-vect-stmts.c:5963
 void fn1(void) {
      ^
0xb333d7 vect_transform_stmt(gimple_statement_d*, gimple_stmt_iterator_d*,
bool*, _slp_tree*, _slp_instance*)
    /home/regehr/z/compiler-source/gcc/gcc/tree-vect-stmts.c:5963
0xb363d1 vect_transform_loop(_loop_vec_info*)
    /home/regehr/z/compiler-source/gcc/gcc/tree-vect-loop.c:5882
0xb5352f vectorize_loops()
    /home/regehr/z/compiler-source/gcc/gcc/tree-vectorizer.c:373
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-433578-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Nov 05 14:32:00 2013
Return-Path: <gcc-bugs-return-433578-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23265 invoked by alias); 5 Nov 2013 14:31:59 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 19707 invoked by uid 48); 5 Nov 2013 14:29:57 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/58532] [4.9 Regression] bootstrap failure with BOOT_CFLAGS="-g -O3"
Date: Tue, 05 Nov 2013 14:31:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-58532-4-bxZ363OCxc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-58532-4@http.gcc.gnu.org/bugzilla/>
References: <bug-58532-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg00355.txt.bz2
Content-length: 428

http://gcc.gnu.org/bugzilla/show_bug.cgi?idX532

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug c/59006] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[regehr at cs dot utah.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

--- Comment #1 from John Regehr <regehr at cs dot utah.edu> ---
Simpler test case:

$ cat small.c
int a[10], b;
int main() {
  for (; b <= 0; b++)
    a[b] = a[0] || b;
}

$ gcc -O3 small.c
small.c: In function ‘main’:
small.c:2:5: internal compiler error: in vect_transform_stmt, at
tree-vect-stmts.c:5963
 int main() {
     ^
0xb333d7 vect_transform_stmt(gimple_statement_d*, gimple_stmt_iterator_d*,
bool*, _slp_tree*, _slp_instance*)
    /home/regehr/z/compiler-source/gcc/gcc/tree-vect-stmts.c:5963
0xb363d1 vect_transform_loop(_loop_vec_info*)
    /home/regehr/z/compiler-source/gcc/gcc/tree-vect-loop.c:5882
0xb5352f vectorize_loops()
    /home/regehr/z/compiler-source/gcc/gcc/tree-vectorizer.c:373
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-433737-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Nov 06 16:47:12 2013
Return-Path: <gcc-bugs-return-433737-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 11074 invoked by alias); 6 Nov 2013 16:47:12 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 9126 invoked by uid 48); 6 Nov 2013 16:45:10 -0000
From: "kimwooyoung at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/59024] New: ICE: after printing certain error messages, the compiler seg faults.
Date: Wed, 06 Nov 2013 16:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 4.8.2
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: kimwooyoung at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-59024-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2013-11/txt/msg00514.txt.bz2
Content-length: 2549

http://gcc.gnu.org/bugzilla/show_bug.cgi?idY024

            Bug ID: 59024
           Summary: ICE: after printing certain error messages, the
                    compiler seg faults.
           Product: gcc
           Version: 4.8.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: kimwooyoung at gmail dot com

This reproducer causes the compiler to seg fault.
The compiler exits normally with the commented-out version.
The reproducer is not a legal fortran program, but the compiler should not die
with a seg fault.


MODULE mtc
  USE ISO_C_BINDING
  PRIVATE
  PUBLIC :: tc, not_present1, &

  TYPE tc
  END TYPE tc
  INTERFACE tc
    MODULE PROCEDURE tc_ctor
  END INTERFACE tc
CONTAINS
!  TYPE(tc) FUNCTION tc_ctor() result(t)
!  END FUNCTION tc_ctor
  FUNCTION tc_ctor() result(t)
    TYPE(tc) t
  END FUNCTION tc_ctor
END MODULE mtc



======================

gfortran -c gf_reprod.F90
gf_reprod.F90:6.6:

  TYPE tc
      1
Error: Syntax error in PUBLIC statement at (1)
gf_reprod.F90:7.5:

  END TYPE tc
     1
Error: Expecting END MODULE statement at (1)
gf_reprod.F90:15.12:

    TYPE(tc) t
            1
Error: Derived type 'tc' at (1) is being used before it is defined
f951: internal compiler error: Segmentation fault
0x869cbf crash_signal
        ../../gcc-4.8.2/gcc/toplev.c:332
0x50b3fb show_locus
        ../../gcc-4.8.2/gcc/fortran/error.c:310
0x50bc90 show_loci
        ../../gcc-4.8.2/gcc/fortran/error.c:434
0x50bc90 error_print
        ../../gcc-4.8.2/gcc/fortran/error.c:666
0x50c778 gfc_error(char const*, ...)
        ../../gcc-4.8.2/gcc/fortran/error.c:961
0x5144f7 check_interface0
        ../../gcc-4.8.2/gcc/fortran/interface.c:1477
0x516dd4 check_sym_interfaces
        ../../gcc-4.8.2/gcc/fortran/interface.c:1589
0x57e693 do_traverse_symtree
        ../../gcc-4.8.2/gcc/fortran/symbol.c:3575
0x516ebc gfc_check_interfaces(gfc_namespace*)
        ../../gcc-4.8.2/gcc/fortran/interface.c:1699
0x55d51e resolve_types
        ../../gcc-4.8.2/gcc/fortran/resolve.c:14989
0x55dda0 gfc_resolve
        ../../gcc-4.8.2/gcc/fortran/resolve.c:15073
0x552486 gfc_parse_file()
        ../../gcc-4.8.2/gcc/fortran/parse.c:4614
0x58e365 gfc_be_parse_file
        ../../gcc-4.8.2/gcc/fortran/f95-lang.c:189
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[mpolacek at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |4.8.2
   Last reconfirmed|                            |2013-11-06
          Component|c                           |tree-optimization
                 CC|                            |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1
            Summary|internal compiler error: in |[4.9 Regression] internal
                   |vect_transform_stmt, at     |compiler error: in
                   |tree-vect-stmts.c:5963      |vect_transform_stmt, at
                   |                            |tree-vect-stmts.c:5963
   Target Milestone|---                         |4.9.0
      Known to fail|                            |4.9.0

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Confirmed.

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |congh at gcc dot gnu.org

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
  if (!vect_is_simple_cond (cond_expr, stmt, loop_vinfo, bb_vinfo,
                            &comp_vectype)
      || !comp_vectype)
    return false;

fails during transform.  This is because we moved the invariant load
and thus the vect_def_type changed from vect_internal_def to vect_external_def.

Bah, I knew this is going to be a problem ... the invariant moving should
have been done when vectorizing the stmt, not upfront.  And the moving
should have only moved the vectorized variant.

I'm trying to fix it in another way that is on my TODO list for some time now.

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[congh at google dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

Cong Hou <congh at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |congh at google dot com

--- Comment #5 from Cong Hou <congh at google dot com> ---
Hoisting all vectorized statements may not be the best solution (some loads may
not be necessary outside of the loop), but I think it works and can solve the
current issues. Richard, are you working on this? If you'd like I could also
make a patch with this idea.


thanks,
Cong

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

--- Comment #6 from rguenther at suse dot de <rguenther at suse dot de> ---
On Wed, 20 Nov 2013, congh at google dot com wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006
> 
> Cong Hou <congh at google dot com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |congh at google dot com
> 
> --- Comment #5 from Cong Hou <congh at google dot com> ---
> Hoisting all vectorized statements may not be the best solution (some loads may
> not be necessary outside of the loop), but I think it works and can solve the
> current issues. Richard, are you working on this? If you'd like I could also
> make a patch with this idea.

No, I was trying to fix it in another way but that didn't work out.

Feel free to take the bug (and yes, applying the invariant motion
after the vectorization transform, on the vectorized stmts).

Thanks,
Richard.

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Jan 14 09:04:50 2014
New Revision: 206599

URL: http://gcc.gnu.org/viewcvs?rev=206599&root=gcc&view=rev
Log:
2014-01-14  Richard Biener  <rguenther@suse.de>

    PR tree-optimization/58921
    PR tree-optimization/59006
    * tree-vect-loop-manip.c (vect_loop_versioning): Remove code
    hoisting invariant stmts.
    * tree-vect-stmts.c (vectorizable_load): Insert the splat of
    invariant loads on the preheader edge if possible.

    * gcc.dg/torture/pr58921.c: New testcase.
    * gcc.dg/torture/pr59006.c: Likewise.
    * gcc.dg/vect/pr58508.c: XFAIL no longer handled cases.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr58921.c
    trunk/gcc/testsuite/gcc.dg/torture/pr59006.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/vect/pr58508.c
    trunk/gcc/tree-vect-loop-manip.c
    trunk/gcc/tree-vect-stmts.c

[Bug tree-optimization/59006] [4.9 Regression] internal compiler error: in vect_transform_stmt, at tree-vect-stmts.c:5963

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59006

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.