[Bug lto/59723] New: [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[Bug lto/59723] New: [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

            Bug ID: 59723
           Summary: [4.9 Regression] ICE: in lto_output_tree, at
                    lto-streamer-out.c:1390 when compiling some Fortran
                    tests with -flto
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
                CC: hubicka at gcc dot gnu.org, rguenth at gcc dot gnu.org

When compiling some Fortran tests with -flto one gets the following ICE:


[Book15] f90/bug% /opt/gcc/gcc4.9a-205798/bin/gfortran -flto
/opt/gcc/work/gcc/testsuite/gfortran.dg/namelist_64.f90
/opt/gcc/work/gcc/testsuite/gfortran.dg/namelist_64.f90: In function 'MAIN__':
/opt/gcc/work/gcc/testsuite/gfortran.dg/namelist_64.f90:27:0: internal compiler
error: in lto_output_tree, at lto-streamer-out.c:1390
 end program
 ^

/opt/gcc/work/gcc/testsuite/gfortran.dg/namelist_64.f90:27:0: internal compiler
error: Abort trap: 6
gfortran: internal compiler error: Abort trap: 6 (program f951)
Abort

r205305 (2013-11-23) compiles the tests, r205798 (2013-12-09) gives the ICE.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2014-01-08
   Target Milestone|---                         |4.9.0
     Ever confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Waiting for "some" testcase.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Waiting for "some" testcase.

gfortran.dg/namelist_64.f90

(see comment 0), but you can pick most of gfortran.dg/namelist_*.f90 it you
prefer:

FAIL: gfortran.dg/namelist_11.f  -O0  (internal compiler error)
FAIL: gfortran.dg/namelist_11.f  -O0  (test for excess errors)
FAIL: gfortran.dg/namelist_11.f  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_11.f  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_12.f  -O0  (internal compiler error)
FAIL: gfortran.dg/namelist_12.f  -O0  (test for excess errors)
FAIL: gfortran.dg/namelist_12.f  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_12.f  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_13.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/namelist_13.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/namelist_13.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_13.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_14.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/namelist_14.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/namelist_14.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_14.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_15.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/namelist_15.f90  -O0  (test for excess errors)
...
FAIL: gfortran.dg/pr12884.f  -O0  (internal compiler error)
FAIL: gfortran.dg/pr12884.f  -O0  (test for excess errors)
FAIL: gfortran.dg/pr12884.f  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr12884.f  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr17285.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/pr17285.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/pr17285.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr17285.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr17286.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/pr17286.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/pr17286.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr17286.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr17472.f  -O0  (internal compiler error)
FAIL: gfortran.dg/pr17472.f  -O0  (test for excess errors)
FAIL: gfortran.dg/pr17472.f  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr17472.f  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr18122.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/pr18122.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/pr18122.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr18122.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr18210.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/pr18210.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/pr18210.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr18210.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr18392.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/pr18392.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/pr18392.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr18392.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr19467.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/pr19467.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/pr19467.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr19467.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr19657.f  -O0  (internal compiler error)
FAIL: gfortran.dg/pr19657.f  -O0  (test for excess errors)
FAIL: gfortran.dg/pr19657.f  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/pr19657.f  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/private_type_3.f90  -O  (internal compiler error)
FAIL: gfortran.dg/private_type_3.f90  -O  (test for excess errors)

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
It could be due to r205679:

Author:    burnus
Date:    Wed Dec 4 19:59:42 2013 UTC (4 weeks, 6 days ago)
Changed paths:    10
Log Message:    
gcc/
2013-12-04  Tobias Burnus  <burnus@net-b.de>

        PR debug/37132
        * lto-streamer.h (LTO_tags): Add LTO_namelist_decl_ref.
        * tree.def (NAMELIST_DECL): Add.
        * tree.h (NAMELIST_DECL_ASSOCIATED_DECL): New macro.
        * tree.c (initialize_tree_contains_struct): Add asserts for it.
        * dwarf2out.c (gen_namelist_decl): New function.
        (gen_decl_die, dwarf2out_decl): Call it.
        (dwarf2out_imported_module_or_decl_1): Handle NAMELIST_DECL.
        * lto-streamer-in.c (lto_input_tree_ref): Handle NAMELIST_DECL.
        (lto_input_tree_ref, lto_input_tree_1): Update lto_tag_check_range
        call.
        * lto-streamer-out.c (lto_output_tree_ref): Handle
        * NAMELIST_DECL.

gcc/fortran
2013-12-04  Tobias Burnus  <burnus@net-b.de>

        PR debug/37132
        * trans-decl.c (generate_namelist_decl, create_module_nml_decl):
        New static functions.
        (gfc_generate_module_vars, generate_local_vars): Call them.
        (gfc_trans_use_stmts): Handle namelists for debug genertion.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #3)
> It could be due to r205679:
> 
> Author:	burnus
> Date:	Wed Dec 4 19:59:42 2013 UTC (4 weeks, 6 days ago)
> Changed paths:	10
> Log Message:	
> gcc/
> 2013-12-04  Tobias Burnus  <burnus@net-b.de>
> 
>         PR debug/37132
>         * lto-streamer.h (LTO_tags): Add LTO_namelist_decl_ref.
>         * tree.def (NAMELIST_DECL): Add.
>         * tree.h (NAMELIST_DECL_ASSOCIATED_DECL): New macro.
>         * tree.c (initialize_tree_contains_struct): Add asserts for it.
>         * dwarf2out.c (gen_namelist_decl): New function.
>         (gen_decl_die, dwarf2out_decl): Call it.
>         (dwarf2out_imported_module_or_decl_1): Handle NAMELIST_DECL.
>         * lto-streamer-in.c (lto_input_tree_ref): Handle NAMELIST_DECL.
>         (lto_input_tree_ref, lto_input_tree_1): Update lto_tag_check_range
>         call.
>         * lto-streamer-out.c (lto_output_tree_ref): Handle
>         * NAMELIST_DECL.
> 
> gcc/fortran
> 2013-12-04  Tobias Burnus  <burnus@net-b.de>
> 
>         PR debug/37132
>         * trans-decl.c (generate_namelist_decl, create_module_nml_decl):
>         New static functions.
>         (gfc_generate_module_vars, generate_local_vars): Call them.
>         (gfc_trans_use_stmts): Handle namelists for debug genertion.

Very likely.  This obviously wasn't tested at all and failed to update
the LTO machinery in all required places.

We ICE at

1390          /* Protect against recursion which means disconnect between
1391             what tree edges we walk in the DFS walk and what edges
1392             we stream out.  */
1393          gcc_assert (!in_dfs_walk);

I don't remember reviewing this LTO change nor approving it.  Well ...
>From gcc-bugs-return-439738-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Jan 09 10:16:12 2014
Return-Path: <gcc-bugs-return-439738-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 21666 invoked by alias); 9 Jan 2014 10:16:11 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21586 invoked by uid 48); 9 Jan 2014 10:16:04 -0000
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/56779] [4.8/4.9 Regression] libstdc++.so: undefined reference to `libintl_textdomain'
Date: Thu, 09 Jan 2014 10:16:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.3
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-56779-4-ZAQeDj3gKw@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56779-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56779-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-01/txt/msg00880.txt.bz2
Content-length: 341

http://gcc.gnu.org/bugzilla/show_bug.cgi?idV779

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Could the submitter and/or Daniel please provide the complete configure command
used to build GCC (e.g. from the output of 'gcc -v', this is supposed to be
part of any bug report, see http://gcc.gnu.org/bugs/ for details).

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I don't remember reviewing this LTO change nor approving it.  Well ...

It was approved by Cary Coutant for the DWARF part at
http://gcc.gnu.org/ml/gcc-patches/2013-12/msg00397.html and Jakub Jelinek for
the rest at http://gcc.gnu.org/ml/gcc-patches/2013-12/msg00401.html.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #4)
> (In reply to Dominique d'Humieres from comment #3)
> > It could be due to r205679:
> 
> Very likely.  This obviously wasn't tested at all

... which implies that the GCC testsuite needs to be improved with regards to
LTO testing as there was no new failure with the patch.


> I don't remember reviewing this LTO change nor approving it.  Well ...

Jakub did on 4 Dec 2013. However, given that the patch was initially posted on
24 Nov 2013 and the nearly unmodified initial version already on 9 Nov 2013,
you had plenty of time to look at the patch ...

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> ... which implies that the GCC testsuite needs to be improved with regards 
> to LTO testing as there was no new failure with the patch.

Not GCC, but gfortran. I stumbled on this pr with

make -k check-gfortran
RUNTESTFLAGS="--target_board=unix'{-m32/-flto,-m64/-flto}'"

One may consider to add something '-Ofast -flto' to the set of options in
gfortran.dg.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org

--- Comment #9 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Simplified testcase:

      program qwerty
      integer var
      namelist /some_namelist/ var
      var = 0
      end

Reproducible with:

      ./f951 foo.f90 -flto

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |aldyh at gcc dot gnu.org

--- Comment #10 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
I'll take a look.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #11 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Created attachment 31807
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=31807&action=edit
preliminary patch

I wonder why we can't do what we do for IMPORTED_DECL and avoid special casing
NAMELIST_DECL.  It looks like the constructor elements even get streamed
correctly this way.

This untested patch gets rid of the majority of the failures, although I still
see 2-3 errors in the dwarf code in tests like namelist_70.cf90:

FAIL: gfortran.dg/namelist_70.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_70.f90  -O3 -g  (test for excess errors)
Excess errors:
lto1: internal compiler error: in force_decl_die, at dwarf2out.c:20105
0x6b4319 force_decl_die
        /source/gcc/gcc/dwarf2out.c:20105
0x6b5b59 gen_namelist_decl
        /source/gcc/gcc/dwarf2out.c:20632
0x6b5379 gen_decl_die
        /source/gcc/gcc/dwarf2out.c:20435
0x6b391e process_scope_var
        /source/gcc/gcc/dwarf2out.c:19944
0x6b399a decls_for_scope
        /source/gcc/gcc/dwarf2out.c:19969
0x6ae9ac gen_subprogram_die
        /source/gcc/gcc/dwarf2out.c:18354
etc

I'll continue looking at this later, but comments welcome :).

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #12 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> This untested patch gets rid of the majority of the failures, although 
> I still see 2-3 errors in the dwarf code in tests like namelist_70.cf90:

Using

time make -k -j8 check-gfortran
RUNTESTFLAGS="--target_board=unix'{-m32/-flto,-m64/-flto}'"

I see the following (26) failures

FAIL: gfortran.dg/debug/pr35154-dwarf2.f -gdwarf-2  scan-assembler (DW_AT_name:
"label"|"label[^\n]*"[^\n]*DW_AT_name)
FAIL: gfortran.dg/debug/pr35154-dwarf2.f -gdwarf-2 -g3  scan-assembler
(DW_AT_name: "label"|"label[^\n]*"[^\n]*DW_AT_name)
FAIL: gfortran.dg/bind_c_array_params_2.f90  -O   scan-assembler-times myBindC
1
FAIL: gfortran.dg/bind_c_vars.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/bind_c_vars.f90  -O1  (test for excess errors)
FAIL: gfortran.dg/bind_c_vars.f90  -O2  (test for excess errors)
FAIL: gfortran.dg/bind_c_vars.f90  -O3 -fomit-frame-pointer  (test for excess
errors)
FAIL: gfortran.dg/bind_c_vars.f90  -O3 -fomit-frame-pointer -funroll-loops 
(test for excess errors)
FAIL: gfortran.dg/bind_c_vars.f90  -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  (test for excess errors)
FAIL: gfortran.dg/bind_c_vars.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/bind_c_vars.f90  -Os  (test for excess errors)
FAIL: gfortran.dg/data_namelist_conflict.f90  -O0  (internal compiler error)
FAIL: gfortran.dg/data_namelist_conflict.f90  -O0  (test for excess errors)
FAIL: gfortran.dg/data_namelist_conflict.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/data_namelist_conflict.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_14.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_14.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_51.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_69.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_69.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/namelist_70.f90  -O3 -g  (internal compiler error)
FAIL: gfortran.dg/namelist_70.f90  -O3 -g  (test for excess errors)
FAIL: gfortran.dg/pr48636-2.f90  -O   scan-ipa-dump cp "Creating a specialized
node of bar/[0-9]*\\."
FAIL: gfortran.dg/pr52835.f90  -O   scan-tree-dump optimized "bar "
FAIL: gfortran.dg/pr53787.f90  -O   scan-ipa-dump cp "Creating a specialized
node of init"
FAIL: gfortran.dg/pr53787.f90  -O   scan-ipa-dump-times cp "Aggregate
replacements" 2

The failures for gfortran.dg/bind_c_vars.f90 are PR54852.
The ICEs for gfortran.dg/namelist_(14|69|70).f90, triggered by -g, are at

        default:
          gcc_unreachable ();

(missing case NAMELIST_DECL: ?).

On darwin13, the excess error for gfortran.dg/namelist_51.f90 is

warning: invalid DWARF generated by the compiler: DIE 0x000001f0 has multiple 
AT_calling_convention attributes in
'/var/folders/8q/sh_swgz96r7f5vnn08f7fxr00000gn/T//ccD0Z3SE.ltrans0.ltrans.o'.

The ICE for gfortran.dg/data_namelist_conflict.f90 at -O or with -g is

lto1: internal compiler error: in lto_fixup_prevailing_decls, at lto/lto.c:2601

at

  gcc_checking_assert (code != CONSTRUCTOR && code != TREE_BINFO);

I have not looked at the scan issues nor at the debug capabilities with/without
the patch.

Concerning the time, the full regtesting of gfortran with -m32 and -m64 takes
~18' without -flto and ~35' with it. The full testing of all languages but go
is ~2h. Is the saving of 17' of CPU over 2h worth the missed testing and the
man power required to handle the problems?

Thanks for working on this PR.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #13 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> I see the following (26) failures

The same 26 failures for -m32 and -m64 (i.e., 52 total).

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #14 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #12)
> > This untested patch gets rid of the majority of the failures, although 
> > I still see 2-3 errors in the dwarf code in tests like namelist_70.cf90:
> 
> Using
> 
> time make -k -j8 check-gfortran
> RUNTESTFLAGS="--target_board=unix'{-m32/-flto,-m64/-flto}'"
> 
> I see the following (26) failures
> 

Yup, all those failures were there before.  I see a net decrease of 310
failures with my patch.  I will take a look at the dwarf ones.

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
Author: rguenth
Date: Tue Feb  4 14:53:24 2014
New Revision: 207471

URL: http://gcc.gnu.org/viewcvs?rev=207471&root=gcc&view=rev
Log:
2014-02-04  Richard Biener  <rguenther@suse.de>

    PR lto/59723
    * lto-streamer-out.c (tree_is_indexable): Force NAMELIST_DECLs
    in function context local.
    (lto_output_tree_ref): Do not write trees from lto_output_tree_ref.
    * lto-streamer-in.c (lto_input_tree_ref): Handle LTO_namelist_decl_ref
    similar to LTO_imported_decl_ref.

    lto/
    * lto.c (mentions_vars_p): Handle NAMELIST_DECL.
    (lto_fixup_prevailing_decls): Handle fixing up CONSTRUCTOR values.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/lto-streamer-in.c
    trunk/gcc/lto-streamer-out.c
    trunk/gcc/lto/ChangeLog
    trunk/gcc/lto/lto.c

[Bug lto/59723] [4.9 Regression] ICE: in lto_output_tree, at lto-streamer-out.c:1390 when compiling some Fortran tests with -flto

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59723

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.