[Bug plugins/61176] New: [4.9/4.10 Regression] plugin builds including gimple.h not building

[Bug plugins/61176] New: [4.9/4.10 Regression] plugin builds including gimple.h not building

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

            Bug ID: 61176
           Summary: [4.9/4.10 Regression] plugin builds including gimple.h
                    not building
           Product: gcc
           Version: 4.9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: plugins
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org

$ cat test.cpp
#include <gcc-plugin.h>
#include <tree.h>
#include <gimple.h>

int main(void) {
    return 0;
}
$ g++-4.9 test.cpp -o test  -I$(g++-4.9 -print-file-name=plugin)/include
...
/usr/lib/gcc/x86_64-linux-gnu/4.9/plugin/include/gimple.h:276:22: error:
field ‘call_used’ has incomplete type ‘pt_solution’ struct pt_solution
call_used;

including tree-ssa-alias.h works around it, but more headers are needed. 
Assuming that gimple.h is needed by plugins how do you find out about all the
required includes?
>From gcc-bugs-return-451471-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue May 13 14:03:18 2014
Return-Path: <gcc-bugs-return-451471-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3533 invoked by alias); 13 May 2014 14:03:17 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3437 invoked by uid 48); 13 May 2014 14:03:14 -0000
From: "paolo.carlini at oracle dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/60081] Internal compiler error: Error reporting routines re-entered.
Date: Tue, 13 May 2014 14:03:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 4.7.3
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: paolo.carlini at oracle dot com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: resolution
Message-ID: <bug-60081-4-u0m6PfEMl3@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-60081-4@http.gcc.gnu.org/bugzilla/>
References: <bug-60081-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-05/txt/msg01163.txt.bz2
Content-length: 438

https://gcc.gnu.org/bugzilla/show_bug.cgi?id`081

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |DUPLICATE

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> ---


*** This bug has been marked as a duplicate of bug 57086 ***

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.9.1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
There was never the promise that the plugin API were anything close to
"stable".

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #2 from Matthias Klose <doko at gcc dot gnu.org> ---
is this about stability? With trying, you find out that the following will
work:

#include <gcc-plugin.h>
#include <tree.h>
#include <function.h>
#include <basic-block.h>
#include <coretypes.h>
#include <is-a.h>
#include <predict.h>
#include <internal-fn.h>
#include <tree-ssa-alias.h>
#include <gimple-expr.h>
#include <gimple.h>

int main(void) {
        return 0;
}


is there any way to find out all the needed includes?  Telling plugin writers
to hard-code all of this doesn't seem like a viable solution.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
IMHO the header flattening is a serious mistake, but others think otherwise :(.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #4 from Andrew Macleod <amacleod at redhat dot com> ---
We have to flatten it before we can fix it... its a complete dependency mess.

you could create a plugin-includes.h which includes all the files from the
primary globbing files that were flattened (gimple.h and tree.h). Start by
copying all the original includes from those 2 files.      Then each plugin
doesn't have to figure out what it needs... at least until we get back to a
reasonable state.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #5 from Andrew Macleod <amacleod at redhat dot com> ---
btw, the long term plan is that #include "gimple.h" will get all the basic
prerequisites you need to manipulate gimple. And then you just #include any
extras your specific task requires.  We're just in a transition state this
release as we flatten to reconstruct a more sensible modular layout.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[doko at ubuntu dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #6 from Matthias Klose <doko at ubuntu dot com> ---
Am 14.05.2014 14:21, schrieb amacleod at redhat dot com:
> btw, the long term plan is that #include "gimple.h" will get all the basic
> prerequisites you need to manipulate gimple. And then you just #include any
> extras your specific task requires.  We're just in a transition state this
> release as we flatten to reconstruct a more sensible modular layout.

this is for 4.10, but what to do about 4.9? Maybe have gimple-plugin.h and
tree-plugin.h headers, which won't go away for 4.10 and then would just include
gimple.h and tree.h?  I would appreciate if you could name all the toplevel
headers.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #7 from Andrew Macleod <amacleod at redhat dot com> ---
Thats part of the fun.  There is little rhyme nor reason to what includes what
right now.. it was purely demand driven over many years.  For your current
purposes, gimple.h and tree.h were the primary accumulators we have already
flattened, but there are a lot of include files which include 4 or 5 or 7 or
more other files. Some where flattened, others haven't been tackled yet.

We're trying to move to the include what you use model... with .h files
containing just the exports for their .c file, and a few module headers which
do some aggregation of common/required headers.  Eventually including gimple.h
alone will compile and provide basic manipulation routines, but you may still
need to include other files depending on what you actually require. 

Plugins can either follow the same model, or could have one giant accumulator
which includes everything... It sounds like the latter may be better for the
interm, but I would encourage it to revert to the same model once the work is
complete.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[pageexec at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

PaX Team <pageexec at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pageexec at gmail dot com

--- Comment #8 from PaX Team <pageexec at gmail dot com> ---
I maintain a compatibility header for gcc plugins that also happens to include
all the headers that we needed so far:
https://www.grsecurity.net/~paxguy1/gcc-common.h (this copy may not always be
up-to-date, the latest version is inside the PaX patch). As for
include-what-you-use, I think it's not a viable model for plugins that want to
support a range of gcc versions...

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #9 from Andrew Macleod <amacleod at redhat dot com> ---
sooooo.  Include them all with an accumulator file as suggested?  Over a run of
multiple generations you have to expect some sort of flux in include structure,
especially since we don't guarantee much.  The only way I see you can have any
kind of stability is to have a standard file you include which can adjust and
include whatever is needed for any given release.

[Bug plugins/61176] [4.9/4.10 Regression] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.1                       |4.9.2

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.1 has been released.

[Bug plugins/61176] [4.9/5 Regression] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.2                       |4.9.3

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.2 has been released.

[Bug plugins/61176] plugin builds including gimple.h not building

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |---
            Summary|[4.9/5 Regression] plugin   |plugin builds including
                   |builds including gimple.h   |gimple.h not building
                   |not building                |
      Known to fail|4.10.0                      |5.0

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Surely not a "regression" in the classical sense but a plugin bug or a plugin
(stable-) API deficiency.

[Bug plugins/61176] plugin builds including gimple.h not building

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #13 from Andrew Macleod <amacleod at redhat dot com> ---
gcc-plugin.h has had a number of includes added to ease the pain of flattening
basic-block.h and cgraph.h this release.  If there are still issues with tree.h
or others, submit a patch which adds the required includes.

[Bug plugins/61176] plugin builds including gimple.h not building

[pageexec at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #14 from PaX Team <pageexec at gmail dot com> ---
it seems that gcc/builtins.h doesn't get installed for plugins.

[Bug plugins/61176] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #15 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
builtins.h has been already in 4.9, just contained far less info and thus has
been less important.
Quick check of new headers in toplevel directory that most likely aren't in
PLUGIN_HEADERS reveals also:
auto-profile.h
ccmp.h
collect-utils.h
dojump.h
explow.h
fibonacci_heap.h
gcse-common.h
generic-match.h
gimple-match.h
graphite-isl-ast-to-gimple.h
ifcvt.h
ipa-chkp.h
ipa-icf-gimple.h
ipa-icf.h
loop-unroll.h
lto-section-names.h
regcprop.h
rtl-chkp.h
rtlhash.h
rtl-iter.h
shrink-wrap.h
symbol-summary.h
tree-chkp.h

Supposedly we should include those in PLUGIN_HEADERS too.

[Bug plugins/61176] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
And comparing the right now installed headers with what is in gcc/*.h gcc/*.def
reveals also:
addresses.h
asan.h
bb-reorder.h
builtin-attrs.def
builtins.h
builtin-types.def
cilk.h
collect2-aix.h
collect2.h
conditions.h
convert.h
coverage.h
cppbuiltin.h
cselib.h
data-streamer.h
dbgcnt.def
dbgcnt.h
dbxout.h
dce.h
ddg.h
dfp.h
domwalk.h
dwarf2asm.h
dwarf2out.h
errors.h
et-forest.h
expmed.h
expr.h
file-find.h
gcc.h
gcov-counter.def
gcov-io.h
gcse.h
gengtype.h
gensupport.h
ggc-internal.h
gimple-streamer.h
glimits.h
graphds.h
graph.h
graphite-poly.h
graphite-scop-detection.h
graphite-sese-to-poly.h
gstab.h
gsyms.h
gsyslimits.h
hooks.h
hosthooks-def.h
hosthooks.h
hw-doloop.h
insn-addr.h
ipa-inline.h
ira.h
ira-int.h
langhooks-def.h
libfuncs.h
limitx.h
limity.h
lower-subreg.h
lra.h
lra-int.h
lto-compress.h
lto-streamer.h
machmode.def
omega.h
omp-low.h
optabs.def
optabs.h
opts-diagnostic.h
passes.def
profile.h
read-md.h
recog.h
regrename.h
regs.h
reload.h
rtl-error.h
rtlhooks-def.h
sched-int.h
sdbout.h
sel-sched-dump.h
sel-sched.h
sel-sched-ir.h
sese.h
sparseset.h
sreal.h
stab.def
streamer-hooks.h
target-def.h
target-globals.h
targhooks.h
trans-mem.h
tree-affine.h
tree-browser.def
tree-chrec.h
tree-data-ref.h
tree-diagnostic.h
tree-scalar-evolution.h
tree-ssa-live.h
tree-ssa-propagate.h
tree-stdarg.h
tree-streamer.h
tree-vectorizer.h
tsan.h
tsystem.h
typeclass.h
ubsan.h
valtrack.h
value-prof.h
vmsdbg.h
vtable-verify.h
xcoff.h
xcoffout.h

(already existing in 4.9).  So, how do we decide which of these headers are
interesting to plugin writers?

[Bug plugins/61176] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #17 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 35144
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35144&action=edit
gcc5-pr61176.patch

Patch to install all gcc/*.h and gcc/*.def headers, even when they aren't
listed in PLUGIN_HEADERS.

[Bug plugins/61176] plugin builds including gimple.h not building

[pageexec at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #18 from PaX Team <pageexec at gmail dot com> ---
(In reply to Jakub Jelinek from comment #17)
> Created attachment 35144 [details]
> gcc5-pr61176.patch
> 
> Patch to install all gcc/*.h and gcc/*.def headers, even when they aren't
> listed in PLUGIN_HEADERS.

thanks, this will be a big (future-proof) step towards writing plugins! on a
related note, there's PR61311 where (among other issues) i list a few more
missing headers needed for LTO. some would now be handled with the wildcard
match however there's still a few missing:

 gcc/lto/lto.h
 <build_dir>/gcc/gcov-iov.h

while lto/lto.h is probably easy to add, i'm not sure about the build-time
generated one...

[Bug plugins/61176] plugin builds including gimple.h not building

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

--- Comment #19 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Tue Mar 31 05:31:57 2015
New Revision: 221786

URL: https://gcc.gnu.org/viewcvs?rev=221786&root=gcc&view=rev
Log:
    PR plugins/61176
    * Makefile.in (install-plugin): Add all gcc/*.{h,def} files
    automatically to $headers.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/Makefile.in

[Bug plugins/61176] plugin builds including gimple.h not building

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61176

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Target Milestone|---                         |9.0
         Resolution|---                         |FIXED

--- Comment #22 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Definitely has been fixed for a while.