[Bug target/64149] New: -mno-lra bitrots, suggest to remove for GCC 5

[Bug target/64149] New: -mno-lra bitrots, suggest to remove for GCC 5

[rguenth at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 5108 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

            Bug ID: 64149
           Summary: -mno-lra bitrots, suggest to remove for GCC 5
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
            Target: aarch64

I suggest to remove -mno-lra support from AARCH64 for GCC 5.  When trying to
reproduce a 4.8/4.9 ICE on trunk I now run into an earlier ICE

/abuild/rguenther/obj-aarch64-g/gcc/cc1plus -quiet  wxe_funcs.i -O2 -fPIC -w -I
/abuild/rguenther/obj-aarch64-g/gcc/include -g -fstack-protector
-funwind-tables -fasynchronous-unwind-tables -fno-strict-aliasing
-fomit-frame-pointer -mno-lra
In file included from /usr/include/wx-3.0/wx/grid.h:14:0,
                 from gen/../wxe_return.h:37,
                 from gen/wxe_funcs.cpp:25:
/usr/include/wx-3.0/wx/generic/grid.h: In constructor ‘wxGrid::wxGrid()’:
/usr/include/wx-3.0/wx/generic/grid.h:935:24: internal compiler error: in
insert_save, at caller-save.c:1338
0x8826fd insert_save
        /space/rguenther/src/svn/trunk/gcc/caller-save.c:1337
0x8826fd save_call_clobbered_regs()
        /space/rguenther/src/svn/trunk/gcc/caller-save.c:875
0xc0bb41 reload(rtx_insn*, int)
        /space/rguenther/src/svn/trunk/gcc/reload1.c:1008
0xaf457d do_reload
        /space/rguenther/src/svn/trunk/gcc/ira.c:5403
0xaf457d execute
        /space/rguenther/src/svn/trunk/gcc/ira.c:5561
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

where I suppose the ports reload support simply bitrotted.
>From gcc-bugs-return-469194-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Dec 02 12:33:54 2014
Return-Path: <gcc-bugs-return-469194-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 3597 invoked by alias); 2 Dec 2014 12:33:54 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 3568 invoked by uid 48); 2 Dec 2014 12:33:50 -0000
From: "marc at kdab dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/64150] New: Missed optimisation opportunity with moved-from pimpl classes and a nullptr d-pointer
Date: Tue, 02 Dec 2014 12:33:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: unknown
X-Bugzilla-Keywords:
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: marc at kdab dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter attachments.created
Message-ID: <bug-64150-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg00201.txt.bz2
Content-length: 1400

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd150

            Bug ID: 64150
           Summary: Missed optimisation opportunity with moved-from pimpl
                    classes and a nullptr d-pointer
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marc at kdab dot com

Created attachment 34162
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id4162&actioníit
Sample program

When compiling attached sample program to assembler source, the compiler emits
two calls to destroy(), one for p1 and one for p2. However, it should be
statically clear that p1.d == nullptr, always, so dead code elimination should
remove the check for nullptr, the branch and the call to destroy().

$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/opt/gcc/trunk/libexec/gcc/x86_64-unknown-linux-gnu/5.0.0/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ../gcc/configure --prefix=/opt/gcc/trunk
--program-suffix=-trunk --enable-checking=release
--enable-languages=c,c++,go,fortran,objc,obj-c++ : (reconfigured)
../gcc/configure --prefix=/opt/gcc/trunk --enable-checking=release
--enable-languages=c,c++,go,fortran,objc,obj-c++
Thread model: posix
gcc version 5.0.0 20141015 (experimental) (GCC)

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[manu at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #0)
> where I suppose the ports reload support simply bitrotted.

Just out of curiosity, what remains to be done so that reload can be retired
and rest in peace?
>From gcc-bugs-return-469205-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Dec 02 13:29:52 2014
Return-Path: <gcc-bugs-return-469205-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 18943 invoked by alias); 2 Dec 2014 13:29:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 18911 invoked by uid 48); 2 Dec 2014 13:29:48 -0000
From: "dimhen at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/64129] [5.0 regression] ICE on invalid: in grokfndecl, at cp/decl.c:7658
Date: Tue, 02 Dec 2014 13:29:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dimhen at gmail dot com
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64129-4-9LetYxPR1O@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64129-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64129-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-12/txt/msg00212.txt.bz2
Content-length: 530

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd129

--- Comment #2 from Dmitry G. Dyachenko <dimhen at gmail dot com> ---
(In reply to Jonathan Wakely from comment #1)
> > Please submit a full bug report,
> > with preprocessed source if appropriate.
> > Please include the complete backtrace with any bug report.
> > See <http://gcc.gnu.org/bugs.html> for instructions.

Hmmm... testcase is in the beginning of the description...


$ cat x.ii
template <0> int __copy_streambufs_eof;
class {
    friend __copy_streambufs_eof <> (

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

--- Comment #2 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Sounds sensible to me.  

We switched to LRA quite late in gcc-4.9, so keeping a way to switch back in
case of problems was pragmatic.  But we've been running with the new code now
for a year and not encountered any major issues that couldn't be fixed pretty
quickly.

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[mshawcroft at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

mshawcroft at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mshawcroft at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |mshawcroft at gcc dot gnu.org

--- Comment #3 from mshawcroft at gcc dot gnu.org ---
Mine.

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[ramana at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-01-13
                 CC|                            |ramana at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #4 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
I think there are patches for this one.

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

--- Comment #5 from Jiong Wang <jiwang at gcc dot gnu.org> ---
Author: jiwang
Date: Fri Jan 16 13:11:53 2015
New Revision: 219734

URL: https://gcc.gnu.org/viewcvs?rev=219734&root=gcc&view=rev
Log:
[AArch64] Remove -mlra/-mno-lra option for Aarch64

2015-01-16  Matthew Wahab  <matthew.wahab@arm.com>

    gcc/
    PR target/64149
    * config/aarch64/aarch64.opt: Remove lra option and aarch64_lra_flag
    variable.
    * config/aarch64/aarch64.c (TARGET_LRA_P): Set to hook_bool_void_true.
    (aarch64_lra_p): Remove.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/aarch64/aarch64.c
    trunk/gcc/config/aarch64/aarch64.opt

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[jiwang at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

Jiong Wang <jiwang at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |jiwang at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #6 from Jiong Wang <jiwang at gcc dot gnu.org> ---
mark as fixed.

[Bug target/64149] -mno-lra bitrots, suggest to remove for GCC 5

[renlin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64149

--- Comment #7 from renlin at gcc dot gnu.org ---
Author: renlin
Date: Tue Jan 20 10:26:18 2015
New Revision: 219884

URL: https://gcc.gnu.org/viewcvs?rev=219884&root=gcc&view=rev
Log:
[ARM] PR 64149: Remove -mlra/-mno-lra option for ARM.

gcc/
2015-01-20  Matthew Wahab  <matthew.wahab@arm.com>

    PR target/64149
    * config/arm/arm.option: Remove lra option and arm_lra_flag variable.
    * config/arm/arm.h (MODE_BASE_REG_CLASS): Remove use of arm_lra_flag,
    replace the conditional with it's true branch.
    * config/arm/arm.c (TARGET_LRA_P): Set to hook_bool_void_true.
    (arm_lra_p): Remove.

gcc/testsuite/
2015-01-20  matthewhew Wahab  <matthew.wahab@arm.com>

    PR target/64149
    * gcc.target/arm/armthumb1-far-jump-3.c: Remove.


Removed:
    trunk/gcc/testsuite/gcc.target/arm/thumb1-far-jump-3.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/arm/arm.h
    trunk/gcc/config/arm/arm.opt
    trunk/gcc/testsuite/ChangeLog