public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/64662] New: [SH] QImode/HImode atomics should return sign extended SImode values
@ 2015-01-18 23:27 olegendo at gcc dot gnu.org
  2024-04-03  4:52 ` [Bug target/64662] " pinskia at gcc dot gnu.org
  0 siblings, 1 reply; 2+ messages in thread
From: olegendo at gcc dot gnu.org @ 2015-01-18 23:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64662

            Bug ID: 64662
           Summary: [SH] QImode/HImode atomics should return sign extended
                    SImode values
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: olegendo at gcc dot gnu.org
            Target: sh*-*-*

Currently, QImode/HImode atomic insns return the values as such, although the
memory loads actually do a sign extension.  They should return sign extended
SImode values instead, so that it's easier to eliminate redundant sign/zero
extensions around atomic insns.

Example:

int test4 (volatile char* mem)
{
  return __atomic_fetch_add (mem, 1, __ATOMIC_ACQ_REL);
}

compiled with -O2 -m4 -matomic-model=soft-gusa:

        mov     #1,r3

        mova    1f,r0  ! atomic_fetch_addqi_soft_gusa  [length = 18]
        .align 2
        mov     r15,r1
        mov     #(0f-1f),r15
0:      mov.b   @r4,r2        <<< sign extending load of previous value
        mov     r2,r7
        add     r3,r7
        mov.b   r7,@r4
1:      mov     r1,r15
        rts
        exts.b  r2,r0         <<< redundant sign extension


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Bug target/64662] [SH] QImode/HImode atomics should return sign extended SImode values
  2015-01-18 23:27 [Bug target/64662] New: [SH] QImode/HImode atomics should return sign extended SImode values olegendo at gcc dot gnu.org
@ 2024-04-03  4:52 ` pinskia at gcc dot gnu.org
  0 siblings, 0 replies; 2+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-04-03  4:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64662

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
           Keywords|                            |missed-optimization

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-03  4:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-18 23:27 [Bug target/64662] New: [SH] QImode/HImode atomics should return sign extended SImode values olegendo at gcc dot gnu.org
2024-04-03  4:52 ` [Bug target/64662] " pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).