public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "tschwinge at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/66005] libgomp make check time is excessive Date: Mon, 15 May 2023 14:22:37 +0000 [thread overview] Message-ID: <bug-66005-4-V9jv4iOfa8@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-66005-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66005 Thomas Schwinge <tschwinge at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #10 from Thomas Schwinge <tschwinge at gcc dot gnu.org> --- (In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #8) > > --- Comment #7 from Thomas Schwinge <tschwinge at gcc dot gnu.org> --- > > Resolved for GCC 14. Not planning on backporting to release branches (but > > could, if desired). > > Unfortunately not: flock is completely unportable. It's not in > POSIX.1/XPG7, and none of Solaris, macOS, or AIX have it. OK, indeed my approach depends on 'flock'. Otherwise, we still serialize 'check-target-libgomp', as before. (In reply to Jakub Jelinek from comment #9) > r5-3553 uses if {![catch {open $path {RDWR CREAT EXCL} 0600} fd]} { to > determine which make check invocation should be given a particular batch of > tests (in an initially empty directory), could you use that instead? We'd like something that blocks until the lock is available, and something that works on file descriptors and unlocks implicitly upon 'close'/process exit (to avoid stale locks). Using something like Jakub posted with spinning probably does waste too many parallel slots here? I'll try to experiment with that, though: at the long tail at the end of overall parallel testing (that is, when all parallel slots are otherwise unused), it's still better than no parallelism at all? Could we easily build a portable 'flock'-like using 'fcntl' locking primitives? (I've not yet looked.)
next prev parent reply other threads:[~2023-05-15 14:22 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-04 13:38 [Bug libgomp/66005] New: " ro at gcc dot gnu.org 2022-01-21 20:42 ` [Bug libgomp/66005] " belyshev at depni dot sinp.msu.ru 2022-02-08 14:15 ` tschwinge at gcc dot gnu.org 2022-05-29 5:05 ` egallager at gcc dot gnu.org 2023-05-04 15:29 ` tschwinge at gcc dot gnu.org 2023-05-05 9:05 ` tschwinge at gcc dot gnu.org 2023-05-15 10:11 ` cvs-commit at gcc dot gnu.org 2023-05-15 10:12 ` cvs-commit at gcc dot gnu.org 2023-05-15 10:31 ` [Bug testsuite/66005] " tschwinge at gcc dot gnu.org 2023-05-15 11:15 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-05-15 11:38 ` jakub at gcc dot gnu.org 2023-05-15 14:22 ` tschwinge at gcc dot gnu.org [this message] 2023-05-15 18:35 ` tschwinge at gcc dot gnu.org 2023-05-15 20:06 ` egallager at gcc dot gnu.org 2023-05-15 20:22 ` jakub at gcc dot gnu.org 2023-05-15 20:42 ` tschwinge at gcc dot gnu.org 2023-05-16 7:46 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-05-16 7:57 ` jakub at gcc dot gnu.org 2023-06-02 7:51 ` cvs-commit at gcc dot gnu.org 2023-06-02 10:07 ` tschwinge at gcc dot gnu.org 2023-06-02 10:16 ` iains at gcc dot gnu.org 2023-06-05 14:52 ` tschwinge at gcc dot gnu.org 2023-06-23 12:51 ` tschwinge at gcc dot gnu.org 2023-06-23 13:42 ` jakub at gcc dot gnu.org 2023-06-28 11:39 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:39 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:39 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:40 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:41 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:41 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:42 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:42 ` cvs-commit at gcc dot gnu.org 2023-06-28 11:42 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-66005-4-V9jv4iOfa8@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).