[Bug target/67126] New: [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[Bug target/67126] New: [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126

            Bug ID: 67126
           Summary: [6 Regression][SH] gcc.target/sh/pr51244-12.c failures
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: olegendo at gcc dot gnu.org
  Target Milestone: ---

There are two new failures:

FAIL: gcc.target/sh/pr51244-12.c scan-assembler-times negc 15
FAIL: gcc.target/sh/pr51244-12.c scan-assembler-times addc 3

which are triggered by the test case

int
test08 (char a)
{
  return ((a & 1) == 0) ? 0x7FFFFFFF : 0x80000000;
}

Before it compiled to:
        mov     r4,r0
        tst     #1,r0
        mov.l   .L69,r0
        rts     
        negc    r0,r0
.L70:
        .align 2
.L69:
        .long   -2147483648

now it compiles to:
        mov.l   .L69,r1
        shlr    r4
        mov     #0,r0
        rts     
        addc    r1,r0
.L70:
        .align 2
.L69:
        .long   2147483647

Using the tst insn in this case is a bit better.

Before combine would try this pattern

;; Use negc to store the T bit in a MSB of a reg in the following way:
;;      T = 0: 0x80000000 -> reg
;;      T = 1: 0x7FFFFFFF -> reg
;; This works because 0 - 0x80000000 = 0x80000000.
(define_insn_and_split "*mov_t_msb_neg"
  [(set (match_operand:SI 0 "arith_reg_dest")
        (minus:SI (const_int -2147483648)  ;; 0x80000000
                  (match_operand 1 "treg_set_expr")))
   (clobber (reg:SI T_REG))]

which now is matched as:

Successfully matched this instruction:
(parallel [
        (set (reg:SI 162 [ D.1897 ])
            (plus:SI (and:SI (reg:SI 4 r4 [ a+-3 ])
                    (const_int 1 [0x1]))
                (const_int 2147483647 [0x7fffffff])))
        (clobber (reg:SI 147 t))
    ])

This is the other *mov_t_msb_neg pattern variant.  The treg_set_expr is the
shlr insn in this case, which is non-negating and hence addc is used instead of
negc.  The (and (reg (const_int 1))) pattern above could be added as a special
case which would split into tst insn.

[Bug target/67126] [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |6.0
         Depends on|                            |67103
   Target Milestone|---                         |6.0

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Probably related to PR67103.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103
[Bug 67103] [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c
FAIL on x86

[Bug target/67126] [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126

--- Comment #2 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #1)
> Probably related to PR67103.

Yep, I've been following the discussion on the patches ML.  I was expecting
something to break for SH, too :)

[Bug target/67126] [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126
Bug 67126 depends on bug 67103, which changed state.

Bug 67103 Summary: [6 Regression]: gcc.target/i386/cmov2.c and gcc.target/i386/cmov3.c FAIL on x86
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67103

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

[Bug target/67126] [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-08-13
     Ever confirmed|0                           |1

--- Comment #3 from Oleg Endo <olegendo at gcc dot gnu.org> ---
I've checked this after the fix for PR 67103.  The issue is still there and the
SH patterns need to be adjusted.

[Bug target/67126] [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126

--- Comment #4 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Author: olegendo
Date: Mon Sep 21 00:17:22 2015
New Revision: 227957

URL: https://gcc.gnu.org/viewcvs?rev=227957&root=gcc&view=rev
Log:
gcc/
        PR target/67126
        * config/sh/sh.md (*reg_lsb_t): Emit bld insn on SH2A.
        (*mov_t_msb_neg): Rewrite negc pattern.

gcc/testsuite/
        PR target/67126
        * gcc.target/sh/pr51244-12.c: Adjust testcase.
        * gcc.target/sh/pr54236-2.c: Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/sh/sh.md
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/sh/pr51244-12.c
    trunk/gcc/testsuite/gcc.target/sh/pr54236-2.c

[Bug target/67126] [6 Regression][SH] gcc.target/sh/pr51244-12.c failures

[olegendo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67126

Oleg Endo <olegendo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Fixed.