public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
@ 2022-01-25 13:54 ` allan at archlinux dot org
  2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: allan at archlinux dot org @ 2022-01-25 13:54 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

Allan McRae <allan at archlinux dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |allan at archlinux dot org

--- Comment #25 from Allan McRae <allan at archlinux dot org> ---
Created attachment 52287
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52287&action=edit
Fix testsuite issues with --enable-default-pie

The following failure are seen in gcc-11.2 when building with
--enable-default-pie:

FAIL: gcc.target/i386/cet-sjlj-6a.c scan-assembler-times movq\\t.*buf\\\\+8 1
FAIL: gcc.target/i386/cet-sjlj-6a.c scan-assembler-times subq\\tbuf\\\\+8 1
FAIL: gcc.target/i386/cet-sjlj-6b.c scan-assembler-times movq\\t.*buf\\\\+16 1
FAIL: gcc.target/i386/cet-sjlj-6b.c scan-assembler-times subq\\tbuf\\\\+16 1
FAIL: gcc.target/i386/fentryname3.c scan-assembler 0x0f, 0x1f, 0x44, 0x00, 0x00
FAIL: gcc.target/i386/pr24414.c (test for excess errors)
FAIL: gcc.target/i386/pr93492-3.c scan-assembler
\\t.cfi_startproc\\n\\tendbr(32|64)\\n.*.LPFE1:\\n\\tnop\\n1:\\tcall\\t__fentry__\\n\\tret\\n
FAIL: gcc.target/i386/pr93492-5.c scan-assembler
\\t.cfi_startproc\\n.*.LPFE1:\\n\\tnop\\n1:\\tcall\\t__fentry__\\n\\tret\\n
FAIL: gcc.target/i386/pr98482-1.c scan-assembler movabsq\\t\\\\\$__fentry__,
%r10\\n\\tcall\\t\\\\*%r10

Adding -no-pie to dg-options only fixed pr24414.c.  For the rest I added a "{
target { ! pie_enabled } }" to the failing tests, which may or may not be the
proper solution...

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
  2022-01-25 13:54 ` [Bug testsuite/70150] Additonal test failures with --enable-default-pie allan at archlinux dot org
@ 2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
  2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-07  7:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #26 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:f30f04b1fbd4b4e13a7535fad8e698c7b24db9b8

commit r13-6516-gf30f04b1fbd4b4e13a7535fad8e698c7b24db9b8
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sat Sep 24 13:57:19 2022 +0800

    aarch64: testsuite: disable PIE for aapcs64 tests [PR70150]

    If GCC is built with --enable-default-pie, a lot of aapcs64 tests fail
    because relocation unsupported in PIE is used.

    gcc/testsuite/ChangeLog:

            PR testsuite/70150
            * gcc.target/aarch64/aapcs64/aapcs64.exp (additional_flags):
            Add -fno-pie -no-pie.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
  2022-01-25 13:54 ` [Bug testsuite/70150] Additonal test failures with --enable-default-pie allan at archlinux dot org
  2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
@ 2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
  2023-03-07  7:38 ` cvs-commit at gcc dot gnu.org
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-07  7:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #27 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:a1ccb4583dfaa267648110aa7da7275acc3000f8

commit r13-6517-ga1ccb4583dfaa267648110aa7da7275acc3000f8
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sat Sep 24 14:28:44 2022 +0800

    aarch64: testsuite: disable PIE for tests with large code model [PR70150]

    These tests set large code model with -mcmodel=large or target pragma for
    AArch64.  But if GCC is configured with --enable-default-pie, it triggers
    "sorry: unimplemented: code model large with -fpic".  Disable PIE to make
    avoid the issue.

    gcc/testsuite/ChangeLog:

            PR testsuite/70150
            * gcc.dg/tls/pr78796.c (dg-additional-options): Add -fno-pie
            -no-pie for aarch64-*-*.
            * gcc.target/aarch64/pr63304_1.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr70120-2.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr78733.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr79041-2.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr94530.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr94577.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/reload-valid-spoff.c (dg-options): Add
            -fno-pie.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
@ 2023-03-07  7:38 ` cvs-commit at gcc dot gnu.org
  2023-03-07  7:40 ` xry111 at gcc dot gnu.org
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-07  7:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #28 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:7e8a3dbbb26f66ce8ea60be48962022b5fb2ef55

commit r13-6518-g7e8a3dbbb26f66ce8ea60be48962022b5fb2ef55
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sat Sep 24 14:45:17 2022 +0800

    aarch64: testsuite: disable PIE for fuse_adrp_add_1.c [PR70150]

    In PIE, symbol "fixed_regs" is addressed via GOT.  It will break the
    scan-assembler pattern and cause test failure with --enable-default-pie.

    gcc/testsuite/ChangeLog:

            PR testsuite/70150
            * gcc.target/aarch64/fuse_adrp_add_1.c (dg-options): Add
            -fno-pie.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2023-03-07  7:38 ` cvs-commit at gcc dot gnu.org
@ 2023-03-07  7:40 ` xry111 at gcc dot gnu.org
  2023-06-12  8:53 ` dkm at gcc dot gnu.org
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: xry111 at gcc dot gnu.org @ 2023-03-07  7:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xry111 at gcc dot gnu.org

--- Comment #29 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to Allan McRae from comment #25)
> Created attachment 52287 [details]
> Fix testsuite issues with --enable-default-pie
> 
> The following failure are seen in gcc-11.2 when building with
> --enable-default-pie:
> 
> FAIL: gcc.target/i386/cet-sjlj-6a.c scan-assembler-times movq\\t.*buf\\\\+8 1
> FAIL: gcc.target/i386/cet-sjlj-6a.c scan-assembler-times subq\\tbuf\\\\+8 1
> FAIL: gcc.target/i386/cet-sjlj-6b.c scan-assembler-times movq\\t.*buf\\\\+16
> 1
> FAIL: gcc.target/i386/cet-sjlj-6b.c scan-assembler-times subq\\tbuf\\\\+16 1
> FAIL: gcc.target/i386/fentryname3.c scan-assembler 0x0f, 0x1f, 0x44, 0x00,
> 0x00
> FAIL: gcc.target/i386/pr24414.c (test for excess errors)
> FAIL: gcc.target/i386/pr93492-3.c scan-assembler
> \\t.cfi_startproc\\n\\tendbr(32|64)\\n.*.LPFE1:\\n\\tnop\\n1:
> \\tcall\\t__fentry__\\n\\tret\\n
> FAIL: gcc.target/i386/pr93492-5.c scan-assembler
> \\t.cfi_startproc\\n.*.LPFE1:\\n\\tnop\\n1:\\tcall\\t__fentry__\\n\\tret\\n
> FAIL: gcc.target/i386/pr98482-1.c scan-assembler movabsq\\t\\\\\$__fentry__,
> %r10\\n\\tcall\\t\\\\*%r10
> 
> Adding -no-pie to dg-options only fixed pr24414.c.  For the rest I added a
> "{ target { ! pie_enabled } }" to the failing tests, which may or may not be
> the proper solution...

You may want -fno-PIE.  -fno-PIE (with "f") affects code generation, but
"-no-pie" simply tells the linker not to link the executable as a PIE.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2023-03-07  7:40 ` xry111 at gcc dot gnu.org
@ 2023-06-12  8:53 ` dkm at gcc dot gnu.org
  2023-06-15  7:48 ` xry111 at gcc dot gnu.org
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: dkm at gcc dot gnu.org @ 2023-06-12  8:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

Marc Poulhiès <dkm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dkm at gcc dot gnu.org

--- Comment #30 from Marc Poulhiès <dkm at gcc dot gnu.org> ---
Hello  Xi Ruoyao,

Your 3 patches are also fixing the regressions in the gcc-12 branch. Do you
plan on back-porting them on this release branch?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2023-06-12  8:53 ` dkm at gcc dot gnu.org
@ 2023-06-15  7:48 ` xry111 at gcc dot gnu.org
  2023-06-15 10:17 ` rsandifo at gcc dot gnu.org
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: xry111 at gcc dot gnu.org @ 2023-06-15  7:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rsandifo at gcc dot gnu.org

--- Comment #31 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to Marc Poulhiès from comment #30)
> Hello  Xi Ruoyao,
> 
> Your 3 patches are also fixing the regressions in the gcc-12 branch. Do you
> plan on back-porting them on this release branch?

Richard: is it allowed to backport them (or the entire
https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613093.html series) for
gcc-12?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2023-06-15  7:48 ` xry111 at gcc dot gnu.org
@ 2023-06-15 10:17 ` rsandifo at gcc dot gnu.org
  2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 11+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2023-06-15 10:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #32 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Xi Ruoyao from comment #31)
> Richard: is it allowed to backport them (or the entire
> https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613093.html series) for
> gcc-12?
Yeah, backporting is OK with me, thanks.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2023-06-15 10:17 ` rsandifo at gcc dot gnu.org
@ 2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
  2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
  2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-06-15 10:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #33 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:e8ee5a0b00dc7a7c25dd3264e9007f440457a791

commit r12-9699-ge8ee5a0b00dc7a7c25dd3264e9007f440457a791
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sat Sep 24 13:57:19 2022 +0800

    aarch64: testsuite: disable PIE for aapcs64 tests [PR70150]

    If GCC is built with --enable-default-pie, a lot of aapcs64 tests fail
    because relocation unsupported in PIE is used.

    gcc/testsuite/ChangeLog:

            PR testsuite/70150
            * gcc.target/aarch64/aapcs64/aapcs64.exp (additional_flags):
            Add -fno-pie -no-pie.

    (cherry picked from commit f30f04b1fbd4b4e13a7535fad8e698c7b24db9b8)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (8 preceding siblings ...)
  2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
@ 2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
  2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-06-15 10:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #34 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:b2d29f2622c215201cb415565ab4f18b738ca35c

commit r12-9700-gb2d29f2622c215201cb415565ab4f18b738ca35c
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sat Sep 24 14:28:44 2022 +0800

    aarch64: testsuite: disable PIE for tests with large code model [PR70150]

    These tests set large code model with -mcmodel=large or target pragma for
    AArch64.  But if GCC is configured with --enable-default-pie, it triggers
    "sorry: unimplemented: code model large with -fpic".  Disable PIE to make
    avoid the issue.

    gcc/testsuite/ChangeLog:

            PR testsuite/70150
            * gcc.dg/tls/pr78796.c (dg-additional-options): Add -fno-pie
            -no-pie for aarch64-*-*.
            * gcc.target/aarch64/pr63304_1.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr70120-2.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr78733.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr79041-2.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr94530.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/pr94577.c (dg-options): Add -fno-pie.
            * gcc.target/aarch64/reload-valid-spoff.c (dg-options): Add
            -fno-pie.

    (cherry picked from commit a1ccb4583dfaa267648110aa7da7275acc3000f8)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [Bug testsuite/70150] Additonal test failures with --enable-default-pie
       [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
                   ` (9 preceding siblings ...)
  2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
@ 2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
  10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-06-15 10:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70150

--- Comment #35 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>:

https://gcc.gnu.org/g:5a21f78294624dd7166e1a25a57c805a759dc0d2

commit r12-9701-g5a21f78294624dd7166e1a25a57c805a759dc0d2
Author: Xi Ruoyao <xry111@xry111.site>
Date:   Sat Sep 24 14:45:17 2022 +0800

    aarch64: testsuite: disable PIE for fuse_adrp_add_1.c [PR70150]

    In PIE, symbol "fixed_regs" is addressed via GOT.  It will break the
    scan-assembler pattern and cause test failure with --enable-default-pie.

    gcc/testsuite/ChangeLog:

            PR testsuite/70150
            * gcc.target/aarch64/fuse_adrp_add_1.c (dg-options): Add
            -fno-pie.

    (cherry picked from commit 7e8a3dbbb26f66ce8ea60be48962022b5fb2ef55)

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-06-15 10:26 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-70150-4@http.gcc.gnu.org/bugzilla/>
2022-01-25 13:54 ` [Bug testsuite/70150] Additonal test failures with --enable-default-pie allan at archlinux dot org
2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
2023-03-07  7:37 ` cvs-commit at gcc dot gnu.org
2023-03-07  7:38 ` cvs-commit at gcc dot gnu.org
2023-03-07  7:40 ` xry111 at gcc dot gnu.org
2023-06-12  8:53 ` dkm at gcc dot gnu.org
2023-06-15  7:48 ` xry111 at gcc dot gnu.org
2023-06-15 10:17 ` rsandifo at gcc dot gnu.org
2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org
2023-06-15 10:26 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).