[Bug fortran/89925] [9/10 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[Bug fortran/89925] [9/10 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.3                         |9.4

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 9.3.0 has been released, adjusting target milestone.

[Bug fortran/89925] [9/10/11/12 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug fortran/89925] [10/11/12/13 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug fortran/89925] [10/11/12/13 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/89925] [10/11/12/13 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[vladimir.fuka at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

Vladimir Fuka <vladimir.fuka at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vladimir.fuka at gmail dot com

--- Comment #9 from Vladimir Fuka <vladimir.fuka at gmail dot com> ---
Was this bug fixed? It seems to work correctly in 12.2.1 but incorrectly in 
11.3.0 (OpenSUSE builds).

It is a major problem and the fix would very much be worth backporting to
maintained versions.

[Bug fortran/89925] [10/11/12/13 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

--- Comment #10 from Tobias Burnus <burnus at gcc dot gnu.org> ---
I think that could be the commit
r12-5767-g6262e3a22b3d86afc116480bc59a7bb30b0cfd40
"fortran: Fix setting of array lower bound for named arrays"

but I have not checked more deeply.

[Bug fortran/89925] [10/11/12/13 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #11 from kargl at gcc dot gnu.org ---
(In reply to Tobias Burnus from comment #10)
> I think that could be the commit
> r12-5767-g6262e3a22b3d86afc116480bc59a7bb30b0cfd40
> "fortran: Fix setting of array lower bound for named arrays"
> 
> but I have not checked more deeply.

I can confirm that your patch in r12-5767-yada-yada
fixed this bug.  Your patch included two testcases.
Do you think that Neil's code should be converted to
a new testcase or do your testcases cover this issue.

Neil, sorry it took so long to get a fix.

[Bug fortran/89925] [11/12/13/14 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug fortran/89925] [11/12/13/14 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |12.3.0, 13.2.1, 14.0
      Known to fail|                            |10.5.0, 11.4.1
             Status|NEW                         |WAITING

--- Comment #13 from anlauf at gcc dot gnu.org ---
Original testcase is fixed for allocate with mold as well as for allocate
with source, and some test coverage is in r12-5767.

There are remaining issues for allocatable character arrays, but these
are tracked elsewhere, e.g. pr113793.

I suggest to close this one with target milestone 12.x

[Bug fortran/89925] [11/12/13/14 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[kargls at comcast dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

--- Comment #14 from kargls at comcast dot net ---
(In reply to anlauf from comment #13)
> Original testcase is fixed for allocate with mold as well as for allocate
> with source, and some test coverage is in r12-5767.
> 
> There are remaining issues for allocatable character arrays, but these
> are tracked elsewhere, e.g. pr113793.
> 
> I suggest to close this one with target milestone 12.x

Seems like a good idea.  Do you believe that original
testcase should be converted to a testcase and committed?

[Bug fortran/89925] [11/12/13/14 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #15 from anlauf at gcc dot gnu.org ---
(In reply to kargls from comment #14)
> (In reply to anlauf from comment #13)
> > Original testcase is fixed for allocate with mold as well as for allocate
> > with source, and some test coverage is in r12-5767.
> > 
> > There are remaining issues for allocatable character arrays, but these
> > are tracked elsewhere, e.g. pr113793.
> > 
> > I suggest to close this one with target milestone 12.x
> 
> Seems like a good idea.  Do you believe that original
> testcase should be converted to a testcase and committed?

Only if something reasonable is tested *beyond* those added/modified
in r12-5767:

gcc/testsuite/gfortran.dg/allocate_with_source_26.f90
gcc/testsuite/gfortran.dg/allocate_with_mold_4.f90

So what is missing here?

[Bug fortran/89925] [11 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

--- Comment #16 from anlauf at gcc dot gnu.org ---
BTW: r12-5767 backports cleanly to 11-branch and regtests cleanly.

I could push it if there are no objections, so that we can finally close
this one.

[Bug fortran/89925] [11 Regression] Wrong array bounds from ALLOCATE with SOURCE or MOLD

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89925

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #17 from anlauf at gcc dot gnu.org ---
Backported as r11-11310-gb755a7af1f2ef1:

commit b755a7af1f2ef1f5348d04db20f751e898abcd9d
Author: Chung-Lin Tang <cltang@codesourcery.com>
Date:   Fri Dec 3 17:27:17 2021 +0800

    fortran: Fix setting of array lower bound for named arrays

    This patch fixes a case of setting array low-bounds, found for particular
uses
    of SOURCE=/MOLD=. This adjusts the relevant part in gfc_trans_allocate() to
    set e3_has_nodescriptor only for non-named arrays.

    2021-12-03  Tobias Burnus  <tobias@codesourcery.com>

    gcc/fortran/ChangeLog:

            * trans-stmt.c (gfc_trans_allocate): Set e3_has_nodescriptor to
true
            only for non-named arrays.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/allocate_with_source_26.f90: Adjust testcase.
            * gfortran.dg/allocate_with_mold_4.f90: New testcase.

    (cherry picked from commit 6262e3a22b3d86afc116480bc59a7bb30b0cfd40)


Closing.