public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
@ 2021-12-20  3:40 ` pinskia at gcc dot gnu.org
  2021-12-20  3:40 ` pinskia at gcc dot gnu.org
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-20  3:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|attribute name and argument |[10/11/12 Regression]
                   |mixed up in an error        |attribute name and argument
                   |message                     |mixed up in an error
                   |                            |message
   Last reconfirmed|2019-05-17 00:00:00         |2021-12-19
      Known to work|                            |9.4.0
   Target Milestone|---                         |10.4
      Known to fail|                            |10.1.0
            Version|9.0                         |10.0

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Before GCC 10, GCC would produce:
<source>:2:1: error: attribute(target("foobar")) is unknown
    2 | __attribute__ ((target ("foobar"))) void foo () { }
      | ^~~~~~~~~~~~~

Which I think is reasonable.
So this is a regression from GCC 9.4.0.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
  2021-12-20  3:40 ` [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message pinskia at gcc dot gnu.org
@ 2021-12-20  3:40 ` pinskia at gcc dot gnu.org
  2021-12-20  3:42 ` pinskia at gcc dot gnu.org
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-20  3:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-linux-gnu

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
aarch64 error message is good:
<source>:2:1: error: pragma or attribute 'target("foobar")' is not valid
    2 | __attribute__ ((target ("foobar"))) void foo () { }
      | ^~~~~~~~~~~~~

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
  2021-12-20  3:40 ` [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message pinskia at gcc dot gnu.org
  2021-12-20  3:40 ` pinskia at gcc dot gnu.org
@ 2021-12-20  3:42 ` pinskia at gcc dot gnu.org
  2022-01-21 13:45 ` rguenth at gcc dot gnu.org
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-12-20  3:42 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #3)
> aarch64 error message is good:
> <source>:2:1: error: pragma or attribute 'target("foobar")' is not valid
>     2 | __attribute__ ((target ("foobar"))) void foo () { }
>       | ^~~~~~~~~~~~~

arm is decent too:
<source>:2:1: error: unknown target attribute or pragma 'foobar'
    2 | __attribute__ ((target ("foobar"))) void foo () { }
      | ^~~~~~~~~~~~~


Though I do think these diagnostic should be uniform rather than have formats.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2021-12-20  3:42 ` pinskia at gcc dot gnu.org
@ 2022-01-21 13:45 ` rguenth at gcc dot gnu.org
  2022-02-03 17:24 ` [Bug target/90524] [10/11 " msebor at gcc dot gnu.org
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-21 13:45 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2022-01-21 13:45 ` rguenth at gcc dot gnu.org
@ 2022-02-03 17:24 ` msebor at gcc dot gnu.org
  2022-04-07  9:33 ` rguenth at gcc dot gnu.org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 8+ messages in thread
From: msebor at gcc dot gnu.org @ 2022-02-03 17:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
            Summary|[10/11/12 Regression]       |[10/11 Regression]
                   |attribute name and argument |attribute name and argument
                   |mixed up in an error        |mixed up in an error
                   |message                     |message
           Assignee|msebor at gcc dot gnu.org          |unassigned at gcc dot gnu.org

--- Comment #5 from Martin Sebor <msebor at gcc dot gnu.org> ---
Fixed by Martin Liska in r12-7014.  I'll leave that to others to backport.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2022-02-03 17:24 ` [Bug target/90524] [10/11 " msebor at gcc dot gnu.org
@ 2022-04-07  9:33 ` rguenth at gcc dot gnu.org
  2022-04-07 10:41 ` marxin at gcc dot gnu.org
  2022-04-07 10:44 ` jakub at gcc dot gnu.org
  7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-04-07  9:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
You fixed this appearantly, maybe you want to backport it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2022-04-07  9:33 ` rguenth at gcc dot gnu.org
@ 2022-04-07 10:41 ` marxin at gcc dot gnu.org
  2022-04-07 10:44 ` jakub at gcc dot gnu.org
  7 siblings, 0 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-04-07 10:41 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
No, I don't want to backport it, it's not so important.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/90524] [10/11 Regression] attribute name and argument mixed up in an error message
       [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2022-04-07 10:41 ` marxin at gcc dot gnu.org
@ 2022-04-07 10:44 ` jakub at gcc dot gnu.org
  7 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-04-07 10:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90524

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |12.0
      Known to work|                            |12.0
                 CC|                            |jakub at gcc dot gnu.org

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-04-07 10:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-90524-4@http.gcc.gnu.org/bugzilla/>
2021-12-20  3:40 ` [Bug target/90524] [10/11/12 Regression] attribute name and argument mixed up in an error message pinskia at gcc dot gnu.org
2021-12-20  3:40 ` pinskia at gcc dot gnu.org
2021-12-20  3:42 ` pinskia at gcc dot gnu.org
2022-01-21 13:45 ` rguenth at gcc dot gnu.org
2022-02-03 17:24 ` [Bug target/90524] [10/11 " msebor at gcc dot gnu.org
2022-04-07  9:33 ` rguenth at gcc dot gnu.org
2022-04-07 10:41 ` marxin at gcc dot gnu.org
2022-04-07 10:44 ` jakub at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).