public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
@ 2021-03-02 19:09 ` pinskia at gcc dot gnu.org
  2021-03-02 20:21 ` ktkachov at gcc dot gnu.org
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-03-02 19:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |spop at gcc dot gnu.org

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 99346 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
  2021-03-02 19:09 ` [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct pinskia at gcc dot gnu.org
@ 2021-03-02 20:21 ` ktkachov at gcc dot gnu.org
  2021-03-03 18:32 ` jakub at gcc dot gnu.org
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: ktkachov at gcc dot gnu.org @ 2021-03-02 20:21 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktkachov at gcc dot gnu.org

--- Comment #6 from ktkachov at gcc dot gnu.org ---
Created attachment 50290
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50290&action=edit
reduced file from PR 99346

Attaching reduced reproducer from PR 99346 that ICEs with GCC 8, 9, 10, 11 at
-O3

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
  2021-03-02 19:09 ` [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct pinskia at gcc dot gnu.org
  2021-03-02 20:21 ` ktkachov at gcc dot gnu.org
@ 2021-03-03 18:32 ` jakub at gcc dot gnu.org
  2021-03-04 18:39 ` cvs-commit at gcc dot gnu.org
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-03-03 18:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 50294
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50294&action=edit
gcc11-pr93235.patch

Untested fix.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
                   ` (2 preceding siblings ...)
  2021-03-03 18:32 ` jakub at gcc dot gnu.org
@ 2021-03-04 18:39 ` cvs-commit at gcc dot gnu.org
  2021-03-19 23:30 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-04 18:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0ad6de3883a1641f7ec0bd9cf56d41fa5b313dae

commit r11-7515-g0ad6de3883a1641f7ec0bd9cf56d41fa5b313dae
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 4 19:38:08 2021 +0100

    expand: Fix ICE in store_bit_field_using_insv [PR93235]

    The following testcase ICEs on aarch64.  The problem is that
    op0 is (subreg:HI (reg:HF ...) 0) and because we can't create a SUBREG of a
    SUBREG and aarch64 doesn't have HImode insv, only SImode insv,
    store_bit_field_using_insv tries to create (subreg:SI (reg:HF ...) 0)
    which is not valid for the target and so gen_rtx_SUBREG ICEs.

    The following patch fixes it by punting if the to be created SUBREG
    doesn't validate, callers of store_bit_field_using_insv can handle
    the fallback.

    2021-03-04  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/93235
            * expmed.c (store_bit_field_using_insv): Return false of xop0 is a
            SUBREG and a SUBREG to op_mode can't be created.

            * gcc.target/aarch64/pr93235.c: New test.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
                   ` (3 preceding siblings ...)
  2021-03-04 18:39 ` cvs-commit at gcc dot gnu.org
@ 2021-03-19 23:30 ` cvs-commit at gcc dot gnu.org
  2021-04-20 23:33 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-19 23:30 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:510ff5def87c70836fdbf832228661ae28e524b6

commit r10-9482-g510ff5def87c70836fdbf832228661ae28e524b6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 4 19:38:08 2021 +0100

    expand: Fix ICE in store_bit_field_using_insv [PR93235]

    The following testcase ICEs on aarch64.  The problem is that
    op0 is (subreg:HI (reg:HF ...) 0) and because we can't create a SUBREG of a
    SUBREG and aarch64 doesn't have HImode insv, only SImode insv,
    store_bit_field_using_insv tries to create (subreg:SI (reg:HF ...) 0)
    which is not valid for the target and so gen_rtx_SUBREG ICEs.

    The following patch fixes it by punting if the to be created SUBREG
    doesn't validate, callers of store_bit_field_using_insv can handle
    the fallback.

    2021-03-04  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/93235
            * expmed.c (store_bit_field_using_insv): Return false of xop0 is a
            SUBREG and a SUBREG to op_mode can't be created.

            * gcc.target/aarch64/pr93235.c: New test.

    (cherry picked from commit 0ad6de3883a1641f7ec0bd9cf56d41fa5b313dae)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
                   ` (4 preceding siblings ...)
  2021-03-19 23:30 ` cvs-commit at gcc dot gnu.org
@ 2021-04-20 23:33 ` cvs-commit at gcc dot gnu.org
  2021-04-22 16:51 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-20 23:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:5d47377411652b67e258d81fb9e29a603556fd16

commit r9-9430-g5d47377411652b67e258d81fb9e29a603556fd16
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 4 19:38:08 2021 +0100

    expand: Fix ICE in store_bit_field_using_insv [PR93235]

    The following testcase ICEs on aarch64.  The problem is that
    op0 is (subreg:HI (reg:HF ...) 0) and because we can't create a SUBREG of a
    SUBREG and aarch64 doesn't have HImode insv, only SImode insv,
    store_bit_field_using_insv tries to create (subreg:SI (reg:HF ...) 0)
    which is not valid for the target and so gen_rtx_SUBREG ICEs.

    The following patch fixes it by punting if the to be created SUBREG
    doesn't validate, callers of store_bit_field_using_insv can handle
    the fallback.

    2021-03-04  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/93235
            * expmed.c (store_bit_field_using_insv): Return false of xop0 is a
            SUBREG and a SUBREG to op_mode can't be created.

            * gcc.target/aarch64/pr93235.c: New test.

    (cherry picked from commit 510ff5def87c70836fdbf832228661ae28e524b6)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
                   ` (5 preceding siblings ...)
  2021-04-20 23:33 ` cvs-commit at gcc dot gnu.org
@ 2021-04-22 16:51 ` cvs-commit at gcc dot gnu.org
  2021-04-22 17:06 ` jakub at gcc dot gnu.org
  2021-09-11 14:29 ` pinskia at gcc dot gnu.org
  8 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-22 16:51 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:35936ba22c8e51c93c87e47114e194a84f9c9ba9

commit r8-10895-g35936ba22c8e51c93c87e47114e194a84f9c9ba9
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 4 19:38:08 2021 +0100

    expand: Fix ICE in store_bit_field_using_insv [PR93235]

    The following testcase ICEs on aarch64.  The problem is that
    op0 is (subreg:HI (reg:HF ...) 0) and because we can't create a SUBREG of a
    SUBREG and aarch64 doesn't have HImode insv, only SImode insv,
    store_bit_field_using_insv tries to create (subreg:SI (reg:HF ...) 0)
    which is not valid for the target and so gen_rtx_SUBREG ICEs.

    The following patch fixes it by punting if the to be created SUBREG
    doesn't validate, callers of store_bit_field_using_insv can handle
    the fallback.

    2021-03-04  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/93235
            * expmed.c (store_bit_field_using_insv): Return false of xop0 is a
            SUBREG and a SUBREG to op_mode can't be created.

            * gcc.target/aarch64/pr93235.c: New test.

    (cherry picked from commit 510ff5def87c70836fdbf832228661ae28e524b6)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
                   ` (6 preceding siblings ...)
  2021-04-22 16:51 ` cvs-commit at gcc dot gnu.org
@ 2021-04-22 17:06 ` jakub at gcc dot gnu.org
  2021-09-11 14:29 ` pinskia at gcc dot gnu.org
  8 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2021-04-22 17:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct
       [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
                   ` (7 preceding siblings ...)
  2021-04-22 17:06 ` jakub at gcc dot gnu.org
@ 2021-09-11 14:29 ` pinskia at gcc dot gnu.org
  8 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-11 14:29 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93235

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |8.5

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-09-11 14:29 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <bug-93235-4@http.gcc.gnu.org/bugzilla/>
2021-03-02 19:09 ` [Bug middle-end/93235] [AArch64] ICE with __fp16 in a struct pinskia at gcc dot gnu.org
2021-03-02 20:21 ` ktkachov at gcc dot gnu.org
2021-03-03 18:32 ` jakub at gcc dot gnu.org
2021-03-04 18:39 ` cvs-commit at gcc dot gnu.org
2021-03-19 23:30 ` cvs-commit at gcc dot gnu.org
2021-04-20 23:33 ` cvs-commit at gcc dot gnu.org
2021-04-22 16:51 ` cvs-commit at gcc dot gnu.org
2021-04-22 17:06 ` jakub at gcc dot gnu.org
2021-09-11 14:29 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).