[Bug other/94826] New: [10 regression] ICE in gcc.dg/pr94780.c after r10-7999

[Bug other/94826] New: [10 regression] ICE in gcc.dg/pr94780.c after r10-7999

[seurer at linux dot vnet.ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

            Bug ID: 94826
           Summary: [10 regression] ICE in gcc.dg/pr94780.c after r10-7999
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at linux dot vnet.ibm.com
  Target Milestone: ---

g:9b8e9006bb35641865358e2df4f6b3ae185b239a, r10-7999

spawn -ignore SIGHUP /home3/seurer/gcc/git/build/gcc-test/gcc/xgcc
-B/home3/seurer/gcc/git/build/gcc-test/gcc/
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/pr94780.c
-fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers
-fdiagnostics-color=never -fdiagnostics-urls=never -O2 -S -o pr94780.s
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/pr94780.c: In function
'foo':
/home/seurer/gcc/git/gcc-test/gcc/testsuite/gcc.dg/pr94780.c:8:1: internal
compiler error: Segmentation fault
0x10b33a33 crash_signal
        /home/seurer/gcc/git/gcc-test/gcc/toplev.c:328
0x10c32f14 tree_check(tree_node*, char const*, int, char const*, tree_code)
        /home/seurer/gcc/git/gcc-test/gcc/tree.h:3286
0x10c32f14 convert_nonlocal_reference_op
        /home/seurer/gcc/git/gcc-test/gcc/tree-nested.c:1064
0x10f5449b walk_tree_1(tree_node**, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set<tree_node*, false, default_hash_traits<tree_node*> >*,
tree_node* (*)(tree_node**, int*, tree_node* (*)(tree_node**, int*, void*),
void*, hash_set<tree_node*, false, default_hash_traits<tree_node*> >*))
        /home/seurer/gcc/git/gcc-test/gcc/tree.c:12000
0x1070d9ab walk_gimple_op(gimple*, tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple-walk.c:268
0x1070dd8f walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple-walk.c:596
0x1070e147 walk_gimple_seq_mod(gimple**, tree_node* (*)(gimple_stmt_iterator*,
bool*, walk_stmt_info*), tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple-walk.c:51
0x1070dfe3 walk_gimple_stmt(gimple_stmt_iterator*, tree_node*
(*)(gimple_stmt_iterator*, bool*, walk_stmt_info*), tree_node* (*)(tree_node**,
int*, void*), walk_stmt_info*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple-walk.c:605
0x1070e147 walk_gimple_seq_mod(gimple**, tree_node* (*)(gimple_stmt_iterator*,
bool*, walk_stmt_info*), tree_node* (*)(tree_node**, int*, void*),
walk_stmt_info*)
        /home/seurer/gcc/git/gcc-test/gcc/gimple-walk.c:51
0x10c2a0c3 walk_body
        /home/seurer/gcc/git/gcc-test/gcc/tree-nested.c:713
0x10c2a173 walk_function
        /home/seurer/gcc/git/gcc-test/gcc/tree-nested.c:724
0x10c2a173 walk_all_functions
        /home/seurer/gcc/git/gcc-test/gcc/tree-nested.c:789
0x10c369b3 lower_nested_functions(tree_node*)
        /home/seurer/gcc/git/gcc-test/gcc/tree-nested.c:3551
0x104bbfb3 cgraph_node::analyze()
        /home/seurer/gcc/git/gcc-test/gcc/cgraphunit.c:676
0x104c0b2b analyze_functions
        /home/seurer/gcc/git/gcc-test/gcc/cgraphunit.c:1227
0x104c2217 symbol_table::finalize_compilation_unit()
        /home/seurer/gcc/git/gcc-test/gcc/cgraphunit.c:2974

[Bug target/94826] [10 regression] ICE in gcc.dg/pr94780.c after r10-7999

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|other                       |target
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |ice-on-valid-code
   Last reconfirmed|                            |2020-04-28
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Similar fix to the powerpc back-end to what was done to the x86 backend needs
to happen.

[Bug target/94826] [8/9/10 regression] ICE in gcc.dg/pr94780.c after r10-7999

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10 regression] ICE in      |[8/9/10 regression] ICE in
                   |gcc.dg/pr94780.c after      |gcc.dg/pr94780.c after
                   |r10-7999                    |r10-7999
   Target Milestone|---                         |8.5

[Bug target/94826] [8/9/10 regression] ICE in gcc.dg/pr94780.c after r10-7999

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 48403
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=48403&action=edit
gcc10-pr94826.patch

Untested fix.

[Bug target/94826] [8/9/10 regression] ICE in gcc.dg/pr94780.c after r10-7999

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c7137fcc7cbc1f1f14f9fed75adcc6bd8f1d418c

commit r10-8051-gc7137fcc7cbc1f1f14f9fed75adcc6bd8f1d418c
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 29 15:55:39 2020 +0200

    rs6000: Fix rs6000_atomic_assign_expand_fenv [PR94826]

    This is the rs6000 version of the earlier committed x86, aarch64 and arm
    fixes, as create_tmp_var_raw is used because the C FE can call this outside
    of function context, we need to make sure the first references to those
    VAR_DECLs are through a TARGET_EXPR, so that it gets gimple_add_tmp_var
    marked in whatever function it gets expanded in.  Without that DECL_CONTEXT
    is NULL and the vars aren't added as local decls of the containing
function.

    2020-04-29  Jakub Jelinek  <jakub@redhat.com>

            PR target/94826
            * config/rs6000/rs6000.c (rs6000_atomic_assign_expand_fenv): Use
            TARGET_EXPR instead of MODIFY_EXPR for first assignment to
            fenv_var, fenv_clear and old_fenv variables.  For fenv_addr
            take address of TARGET_EXPR of fenv_var with void_node initializer.
            Formatting fixes.

[Bug target/94826] [8/9 regression] ICE in gcc.dg/pr94780.c after r10-7999

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[8/9/10 regression] ICE in  |[8/9 regression] ICE in
                   |gcc.dg/pr94780.c after      |gcc.dg/pr94780.c after
                   |r10-7999                    |r10-7999

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 10+ so far.

[Bug target/94826] [8/9 regression] ICE in gcc.dg/pr94780.c after r10-7999

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bergner at gcc dot gnu.org

--- Comment #5 from Peter Bergner <bergner at gcc dot gnu.org> ---
Is this something we want in GCC 8 & 9?  If so, is it just a lack of time to
proper regtesting?  If so, I can find someone on our team to do the backport
and testing.  Or is the backport not so straightforward?

[Bug target/94826] [8/9 regression] ICE in gcc.dg/pr94780.c after r10-7999

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:540e1de23a70360fe9b626df8420be704d02e3a7

commit r9-8890-g540e1de23a70360fe9b626df8420be704d02e3a7
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Apr 29 15:55:39 2020 +0200

    rs6000: Fix rs6000_atomic_assign_expand_fenv [PR94826]

    This is the rs6000 version of the earlier committed x86, aarch64 and arm
    fixes, as create_tmp_var_raw is used because the C FE can call this outside
    of function context, we need to make sure the first references to those
    VAR_DECLs are through a TARGET_EXPR, so that it gets gimple_add_tmp_var
    marked in whatever function it gets expanded in.  Without that DECL_CONTEXT
    is NULL and the vars aren't added as local decls of the containing
function.

    2020-04-29  Jakub Jelinek  <jakub@redhat.com>

            PR target/94826
            * config/rs6000/rs6000.c (rs6000_atomic_assign_expand_fenv): Use
            TARGET_EXPR instead of MODIFY_EXPR for first assignment to
            fenv_var, fenv_clear and old_fenv variables.  For fenv_addr
            take address of TARGET_EXPR of fenv_var with void_node initializer.
            Formatting fixes.

    (cherry picked from commit c7137fcc7cbc1f1f14f9fed75adcc6bd8f1d418c)

[Bug target/94826] [8/9 regression] ICE in gcc.dg/pr94780.c after r10-7999

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94826

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 8.5 in r8-10496-ge031d8024aa22d31ceb85180a6607b3d6bb01481 and by the
above commit for 9.4+ too.