[Bug libgomp/96661] New: configure:16984: error: unsupported system, cannot find Fortran int kind=16

[Bug libgomp/96661] New: configure:16984: error: unsupported system, cannot find Fortran int kind=16

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

            Bug ID: 96661
           Summary: configure:16984: error: unsupported system, cannot
                    find Fortran int kind=16
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
                CC: burnus at gcc dot gnu.org, jakub at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa64-hp-hpux11.11
            Target: hppa64-hp-hpux11.11
             Build: hppa64-hp-hpux11.11

Whiling configuring libgomp, the following error occurs:

configure:16984: error: unsupported system, cannot find Fortran int kind=16,
nee
ded for omp_depend_kind

## ---------------- ##
## Cache variables. ##
## ---------------- ##

ac_cv_build=hppa64-hp-hpux11.11
ac_cv_c_compiler_gnu=yes

Looks like this was introduced by:

2020-07-23  Tobias Burnus  <tobias@codesourcery.com>

        * configure.ac: Add OMP_DEPEND_KIND and OMP_INT128_SIZE.
        * libgomp_f.h.in (omp_check_defines): Check whether
        sizeof of determined Fortran kind and C typedef match.
        * omp_lib.f90.in: Add omp_depened_kind.
        * omp_lib.h.in: Likewise; fix omp_alloctrait_key_kind.
        * configure: Regenerate.
        * Makefile.in: Regenerate.
        * testsuite/Makefile.in: Regenerate.

Guess this is because target doesn't support int128.

For the most part, libgomp used to work on this target.

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #0)
> Guess this is because target doesn't support int128.

For "omp depend", the OpenMP spec requires that an integer type is used – and
the libgomp implementation uses two pointer [= 2*sizeof(void*)] for this.

If (as I assume) hppa64-hp-hpux11.11 uses 64bit pointers, this indeed means
that in128 is needed.

In principle, OpenMP should have used some opaque data type (user-defined
derived type). But as they didn't think of this when specifying the data type
and the best choice for the implementation in GCC was to have storage for two
pointers, I now have this problem.

I do not see an easy way out; we had the same issue before with GCN and there
the solution was to add support for int128, cf. PR 96306.

> For the most part, libgomp used to work on this target.

Probably still the case when ignoring the 'depend' feature in Fortran...

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #2 from dave.anglin at bell dot net ---
On 2020-08-17 2:10 p.m., burnus at gcc dot gnu.org wrote:
> I do not see an easy way out; we had the same issue before with GCN and there
> the solution was to add support for int128, cf. PR 96306.
While this probably is possible, there is no library support for __int128.  I
guess as long
as the "long long" type still maps to a 64-bit int this might be okay.

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 102246 has been marked as a duplicate of this bug. ***

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:1f0a57bd54aed558e0167016dd980177f88f8480

commit r12-3927-g1f0a57bd54aed558e0167016dd980177f88f8480
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Sep 28 15:15:47 2021 +0200

    libgomp: Only check for 2*sizeof(void*) int type with Fortran [PR96661]

    The depend type is a struct with two pointer members for C/C++ - but for
    Fortran OpenMP requires an integer type with kind = omp_depend_kind. Thus,
    libgomp's configure checks that an integer type/kind with size
2*sizeof(void*)
    is available. However, this integer type/kind is not needed when building
without
    Fortran support. Thus, only check this when Fortran is enabled.

    libgomp/
            PR libgomp/96661
            * configure.ac: Only check for int-type = 2*size_t support when
            building with Fortran support.
            * configure: Regenerate.

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Note the commit in comment 4 does not solve the problem that
  the hppa64-hp-hpux11.11 target in does not support TImode alias __int128
(yet)

However, when building libgomp without Fortran support, it now should build
again.

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Tobias Burnus
<burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:8e7da0da76fc6c2ef19635bc5dd507789965da33

commit r11-9036-g8e7da0da76fc6c2ef19635bc5dd507789965da33
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Sep 28 15:15:47 2021 +0200

    libgomp: Only check for 2*sizeof(void*) int type with Fortran [PR96661]

    The depend type is a struct with two pointer members for C/C++ - but for
    Fortran OpenMP requires an integer type with kind = omp_depend_kind. Thus,
    libgomp's configure checks that an integer type/kind with size
2*sizeof(void*)
    is available. However, this integer type/kind is not needed when building
without
    Fortran support. Thus, only check this when Fortran is enabled.

    libgomp/
            PR libgomp/96661
            * configure.ac: Only check for int-type = 2*size_t support when
            building with Fortran support.
            * configure: Regenerate.

    (cherry picked from commit 1f0a57bd54aed558e0167016dd980177f88f8480)

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by John David Anglin <danglin@gcc.gnu.org>:

https://gcc.gnu.org/g:db89d474ad812e57895cb8866ebaeedad0cc3e3f

commit r12-4945-gdb89d474ad812e57895cb8866ebaeedad0cc3e3f
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Fri Nov 5 16:07:35 2021 +0000

    Support TI mode and soft float on PA64

    This change implements TI mode on PA64.  Various new patterns are
    added to pa.md.  The libgcc build needed modification to build both
    DI and TI routines.  We also need various softfp routines to
    convert to and from TImode.

    I added full softfp for the -msoft-float option.  At the moment,
    this doesn't completely eliminate all use of the floating-point
    co-processor.  For this, libgcc needs to be built with -msoft-mult.
    The floating-point exception support also needs a soft option.

    2021-11-05  John David Anglin  <danglin@gcc.gnu.org>

            PR libgomp/96661

    gcc/ChangeLog:

            * config/pa/pa-modes.def: Add OImode integer type.
            * config/pa/pa.c (pa_scalar_mode_supported_p): Allow TImode
            for TARGET_64BIT.
            * config/pa/pa.h (MIN_UNITS_PER_WORD) Define to MIN_UNITS_PER_WORD
            to UNITS_PER_WORD if IN_LIBGCC2.
            * config/pa/pa.md (addti3, addvti3, subti3, subvti3, negti2,
            negvti2, ashlti3, shrpd_internal): New patterns.
            Change some multi instruction types to multi.

    libgcc/ChangeLog:

            * config.host (hppa*64*-*-linux*): Revise tmake_file.
            (hppa*64*-*-hpux11*): Likewise.
            * config/pa/sfp-exceptions.c: New.
            * config/pa/sfp-machine.h: New.
            * config/pa/t-dimode: New.
            * config/pa/t-softfp-sfdftf: New.

[Bug libgomp/96661] configure:16984: error: unsupported system, cannot find Fortran int kind=16

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96661

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by John David Anglin
<danglin@gcc.gnu.org>:

https://gcc.gnu.org/g:ad5aa4937edcb97d9c7a59223bd3de01bdff4e0c

commit r11-9210-gad5aa4937edcb97d9c7a59223bd3de01bdff4e0c
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Fri Nov 5 16:09:08 2021 +0000

    Support TI mode and soft float on PA64

    This change implements TI mode on PA64.  Various new patterns are
    added to pa.md.  The libgcc build needed modification to build both
    DI and TI routines.  We also need various softfp routines to
    convert to and from TImode.

    I added full softfp for the -msoft-float option.  At the moment,
    this doesn't completely eliminate all use of the floating-point
    co-processor.  For this, libgcc needs to be built with -msoft-mult.
    The floating-point exception support also needs a soft option.

    2021-11-05  John David Anglin  <danglin@gcc.gnu.org>

            PR libgomp/96661

    gcc/ChangeLog:

            * config/pa/pa-modes.def: Add OImode integer type.
            * config/pa/pa.c (pa_scalar_mode_supported_p): Allow TImode
            for TARGET_64BIT.
            * config/pa/pa.h (MIN_UNITS_PER_WORD) Define to MIN_UNITS_PER_WORD
            to UNITS_PER_WORD if IN_LIBGCC2.
            * config/pa/pa.md (addti3, addvti3, subti3, subvti3, negti2,
            negvti2, ashlti3, shrpd_internal): New patterns.
            Change some multi instruction types to multi.

    libgcc/ChangeLog:

            * config.host (hppa*64*-*-linux*): Revise tmake_file.
            (hppa*64*-*-hpux11*): Likewise.
            * config/pa/sfp-exceptions.c: New.
            * config/pa/sfp-machine.h: New.
            * config/pa/t-dimode: New.
            * config/pa/t-softfp-sfdftf: New.