* [Bug target/98136] [aarch64] Internal compiler error with large classes and virtual methods
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
@ 2020-12-04 9:50 ` marxin at gcc dot gnu.org
2020-12-04 9:52 ` [Bug target/98136] [8/9/10/11 Regression] " pinskia at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-12-04 9:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
CC| |marxin at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Last reconfirmed| |2020-12-04
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, apparently, GCC 7 is fine.
I'm bisecting that right now.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
2020-12-04 9:50 ` [Bug target/98136] " marxin at gcc dot gnu.org
@ 2020-12-04 9:52 ` pinskia at gcc dot gnu.org
2020-12-04 11:45 ` [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0 marxin at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2020-12-04 9:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |8.5
Summary|[aarch64] Internal compiler |[8/9/10/11 Regression]
|error with large classes |[aarch64] Internal compiler
|and virtual methods |error with large classes
| |and virtual methods
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
2020-12-04 9:50 ` [Bug target/98136] " marxin at gcc dot gnu.org
2020-12-04 9:52 ` [Bug target/98136] [8/9/10/11 Regression] " pinskia at gcc dot gnu.org
@ 2020-12-04 11:45 ` marxin at gcc dot gnu.org
2020-12-04 11:51 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: marxin at gcc dot gnu.org @ 2020-12-04 11:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[8/9/10/11 Regression] |[8/9/10/11 Regression]
|[aarch64] Internal compiler |[aarch64] Internal compiler
|error with large classes |error with large classes
|and virtual methods |and virtual methods since
| |r8-5967-gf5470a77425a54efeb
| |fe1732488c40f05ef176d0
CC| |alan.hayward at arm dot com,
| |david.sherwood at arm dot com,
| |rsandifo at gcc dot gnu.org
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (2 preceding siblings ...)
2020-12-04 11:45 ` [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0 marxin at gcc dot gnu.org
@ 2020-12-04 11:51 ` rguenth at gcc dot gnu.org
2021-01-05 11:35 ` rsandifo at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2020-12-04 11:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (3 preceding siblings ...)
2020-12-04 11:51 ` rguenth at gcc dot gnu.org
@ 2021-01-05 11:35 ` rsandifo at gcc dot gnu.org
2021-03-30 10:43 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2021-01-05 11:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |rsandifo at gcc dot gnu.org
--- Comment #3 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Mine.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10/11 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (4 preceding siblings ...)
2021-01-05 11:35 ` rsandifo at gcc dot gnu.org
@ 2021-03-30 10:43 ` cvs-commit at gcc dot gnu.org
2021-03-30 10:49 ` [Bug target/98136] [8/9/10 " rsandifo at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-03-30 10:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:
https://gcc.gnu.org/g:48c79f054bf435051c95ee093c45a0f8c9de5b4e
commit r11-7905-g48c79f054bf435051c95ee093c45a0f8c9de5b4e
Author: Richard Sandiford <richard.sandiford@arm.com>
Date: Tue Mar 30 11:42:50 2021 +0100
aarch64: Tweak post-RA handling of CONST_INT moves [PR98136]
This PR is a regression caused by r8-5967, where we replaced
a call to aarch64_internal_mov_immediate in aarch64_add_offset
with a call to aarch64_force_temporary, which in turn uses the
normal emit_move_insn{,_1} routines.
The problem is that aarch64_add_offset can be called while
outputting a thunk, where we require all instructions to be
valid without splitting. However, the move expanders were
not splitting CONST_INT moves themselves.
I think the right fix is to make the move expanders work
even in this scenario, rather than require callers to handle
it as a special case.
gcc/
PR target/98136
* config/aarch64/aarch64.md (mov<mode>): Pass multi-instruction
CONST_INTs to aarch64_expand_mov_immediate when called after RA.
gcc/testsuite/
PR target/98136
* g++.dg/pr98136.C: New test.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (5 preceding siblings ...)
2021-03-30 10:43 ` cvs-commit at gcc dot gnu.org
@ 2021-03-30 10:49 ` rsandifo at gcc dot gnu.org
2021-04-23 9:10 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2021-03-30 10:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[8/9/10/11 Regression] |[8/9/10 Regression]
|[aarch64] Internal compiler |[aarch64] Internal compiler
|error with large classes |error with large classes
|and virtual methods since |and virtual methods since
|r8-5967-gf5470a77425a54efeb |r8-5967-gf5470a77425a54efeb
|fe1732488c40f05ef176d0 |fe1732488c40f05ef176d0
--- Comment #5 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Fixed on trunk so far.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9/10 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (6 preceding siblings ...)
2021-03-30 10:49 ` [Bug target/98136] [8/9/10 " rsandifo at gcc dot gnu.org
@ 2021-04-23 9:10 ` cvs-commit at gcc dot gnu.org
2021-04-25 13:51 ` [Bug target/98136] [8/9 " cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-23 9:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:
https://gcc.gnu.org/g:63da018de828b4792e95d1431118fd10efef87d1
commit r10-9751-g63da018de828b4792e95d1431118fd10efef87d1
Author: Richard Sandiford <richard.sandiford@arm.com>
Date: Fri Apr 23 10:09:40 2021 +0100
aarch64: Tweak post-RA handling of CONST_INT moves [PR98136]
This PR is a regression caused by r8-5967, where we replaced
a call to aarch64_internal_mov_immediate in aarch64_add_offset
with a call to aarch64_force_temporary, which in turn uses the
normal emit_move_insn{,_1} routines.
The problem is that aarch64_add_offset can be called while
outputting a thunk, where we require all instructions to be
valid without splitting. However, the move expanders were
not splitting CONST_INT moves themselves.
I think the right fix is to make the move expanders work
even in this scenario, rather than require callers to handle
it as a special case.
gcc/
PR target/98136
* config/aarch64/aarch64.md (mov<mode>): Pass multi-instruction
CONST_INTs to aarch64_expand_mov_immediate when called after RA.
gcc/testsuite/
PR target/98136
* g++.dg/pr98136.C: New test.
(cherry picked from commit 48c79f054bf435051c95ee093c45a0f8c9de5b4e)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8/9 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (7 preceding siblings ...)
2021-04-23 9:10 ` cvs-commit at gcc dot gnu.org
@ 2021-04-25 13:51 ` cvs-commit at gcc dot gnu.org
2021-04-26 8:37 ` [Bug target/98136] [8 " cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-25 13:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:
https://gcc.gnu.org/g:04aaa315db27726e090ca7c3ca3aed9dd5895701
commit r9-9464-g04aaa315db27726e090ca7c3ca3aed9dd5895701
Author: Richard Sandiford <richard.sandiford@arm.com>
Date: Sun Apr 25 14:51:15 2021 +0100
aarch64: Tweak post-RA handling of CONST_INT moves [PR98136]
This PR is a regression caused by r8-5967, where we replaced
a call to aarch64_internal_mov_immediate in aarch64_add_offset
with a call to aarch64_force_temporary, which in turn uses the
normal emit_move_insn{,_1} routines.
The problem is that aarch64_add_offset can be called while
outputting a thunk, where we require all instructions to be
valid without splitting. However, the move expanders were
not splitting CONST_INT moves themselves.
I think the right fix is to make the move expanders work
even in this scenario, rather than require callers to handle
it as a special case.
gcc/
PR target/98136
* config/aarch64/aarch64.md (mov<mode>): Pass multi-instruction
CONST_INTs to aarch64_expand_mov_immediate when called after RA.
gcc/testsuite/
PR target/98136
* g++.dg/pr98136.C: New test.
(cherry picked from commit 48c79f054bf435051c95ee093c45a0f8c9de5b4e)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (8 preceding siblings ...)
2021-04-25 13:51 ` [Bug target/98136] [8/9 " cvs-commit at gcc dot gnu.org
@ 2021-04-26 8:37 ` cvs-commit at gcc dot gnu.org
2021-04-26 8:38 ` rsandifo at gcc dot gnu.org
2023-04-26 2:22 ` pinskia at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-04-26 8:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:
https://gcc.gnu.org/g:5ced791a38484705f9d2a009c76674d8e7f0ca57
commit r8-10918-g5ced791a38484705f9d2a009c76674d8e7f0ca57
Author: Richard Sandiford <richard.sandiford@arm.com>
Date: Mon Apr 26 09:36:47 2021 +0100
aarch64: Tweak post-RA handling of CONST_INT moves [PR98136]
This PR is a regression caused by r8-5967, where we replaced
a call to aarch64_internal_mov_immediate in aarch64_add_offset
with a call to aarch64_force_temporary, which in turn uses the
normal emit_move_insn{,_1} routines.
The problem is that aarch64_add_offset can be called while
outputting a thunk, where we require all instructions to be
valid without splitting. However, the move expanders were
not splitting CONST_INT moves themselves.
I think the right fix is to make the move expanders work
even in this scenario, rather than require callers to handle
it as a special case.
gcc/
PR target/98136
* config/aarch64/aarch64.md (mov<mode>): Pass multi-instruction
CONST_INTs to aarch64_expand_mov_immediate when called after RA.
gcc/testsuite/
PR target/98136
* g++.dg/pr98136.C: New test.
(cherry picked from commit 48c79f054bf435051c95ee093c45a0f8c9de5b4e)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (9 preceding siblings ...)
2021-04-26 8:37 ` [Bug target/98136] [8 " cvs-commit at gcc dot gnu.org
@ 2021-04-26 8:38 ` rsandifo at gcc dot gnu.org
2023-04-26 2:22 ` pinskia at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: rsandifo at gcc dot gnu.org @ 2021-04-26 8:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #9 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
Fixed for GCC 8 and above. Thanks for the bug report.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug target/98136] [8 Regression] [aarch64] Internal compiler error with large classes and virtual methods since r8-5967-gf5470a77425a54efebfe1732488c40f05ef176d0
2020-12-04 9:33 [Bug c++/98136] New: [aarch64] Internal compiler error with large classes and virtual methods dark141 at gmail dot com
` (10 preceding siblings ...)
2021-04-26 8:38 ` rsandifo at gcc dot gnu.org
@ 2023-04-26 2:22 ` pinskia at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-04-26 2:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98136
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |linus.zhu at mavenir dot com
--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 109629 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 13+ messages in thread