public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ppalka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/98384] [11 Regression] new test case 20_util/to_chars/long_double.cc in r11-6249 fails on powerpc64 BE
Date: Wed, 24 Feb 2021 15:14:19 +0000	[thread overview]
Message-ID: <bug-98384-4-7SAnG4AbSj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98384-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98384

--- Comment #13 from Patrick Palka <ppalka at gcc dot gnu.org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #12)
> > --- Comment #11 from Patrick Palka <ppalka at gcc dot gnu.org> ---
> > I posted a patch at
> > https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565726.html that does
> > this, but also salvages the verification via printf by first checking if the
> > leading hex digit of the printf output agrees with that of to_chars. 
> > Conveniently, the patch sidesteps the question of choosing a consistent
> > representation vs shortest representation :)
> 
> I've just tested the patch on both i386-pc-solaris2.11 and
> sparc-sun-solaris2.11 (32 and 64-bit each): as before, the 32-bit test
> XFAILs while the 64-bit test continues to FAIL:
> 
> before:
> 
> /vol/gcc/src/hg/master/local/libstdc++-v3/testsuite/20_util/to_chars/
> long_double.cc:104: void test01(): Assertion '!strcmp(to_chars_buffer,
> printf_buffer+strlen("0x"))' failed.
> 
> now:
> 
> /vol/gcc/src/hg/master/local/libstdc++-v3/testsuite/20_util/to_chars/
> long_double.cc:192: void test02(): Assertion '!memcmp(printf_buffer,
> to_chars_buffer, output_length)' failed.

Thanks for testing.  I was able to reproduce the 64-bit execution FAIL on
sparc-sun-solaris2.11 (using the gcc211 compile farm machine).

Digging deeper, it seems the test is failing ultimately due to pecularities
with the system printf implementation.  For example, when I compile+run the
following

#include <cstdio>

int main() {
  printf("%La\n", 1.0L);
  printf("%L.1000f\n", 1.0L);
  printf("%Lf\n", 0x1.13492ffd6ec7341068e0176a737dp+3384L);
}

the output I get is

0x1.0000000000000000000000000000p+0
1.0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000e+00 
5.212539e+1018

So:

1. The hex-form conversion specifier doesn't trim trailing zeroes.
2. The fixed-form conversion specifier sometimes outputs the
scientific-notation suffix "e+00".
3. The fixed-form conversion specifier sometimes outputs the scientific form.

Each of the to_chars/printf mismatches I've looked at seem to be caused by one
of these three issues.  Should we just XFAIL the test on Solaris?

  parent reply	other threads:[~2021-02-24 15:14 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 21:39 [Bug libstdc++/98384] New: " seurer at gcc dot gnu.org
2020-12-21 20:28 ` [Bug libstdc++/98384] " ppalka at gcc dot gnu.org
2020-12-22  9:23 ` ro at gcc dot gnu.org
2021-01-05  9:10 ` [Bug libstdc++/98384] [11 Regression] " rguenth at gcc dot gnu.org
2021-01-07 13:04 ` iains at gcc dot gnu.org
2021-01-07 15:42 ` ppalka at gcc dot gnu.org
2021-01-07 16:41 ` iains at gcc dot gnu.org
2021-01-07 17:42 ` cvs-commit at gcc dot gnu.org
2021-01-07 17:55 ` ppalka at gcc dot gnu.org
2021-01-08  9:30 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-01-12 16:35 ` ppalka at gcc dot gnu.org
2021-01-14 11:13 ` rguenth at gcc dot gnu.org
2021-02-12 15:02 ` jakub at gcc dot gnu.org
2021-02-23  2:49 ` cvs-commit at gcc dot gnu.org
2021-02-23 16:55 ` ppalka at gcc dot gnu.org
2021-02-24  9:58 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-02-24 15:14 ` ppalka at gcc dot gnu.org [this message]
2021-02-24 15:42 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-02-24 15:48 ` jakub at gcc dot gnu.org
2021-02-24 16:16 ` ppalka at gcc dot gnu.org
2021-02-24 16:26 ` iains at gcc dot gnu.org
2021-02-24 16:45 ` ppalka at gcc dot gnu.org
2021-02-24 17:26 ` cvs-commit at gcc dot gnu.org
2021-02-27 16:17 ` iains at gcc dot gnu.org
2021-02-27 16:49 ` dje at gcc dot gnu.org
2021-03-03 14:28 ` ppalka at gcc dot gnu.org
2021-03-05  2:37 ` dje at gcc dot gnu.org
2021-03-08 17:42 ` ppalka at gcc dot gnu.org
2021-03-08 17:53 ` schwab@linux-m68k.org
2021-03-08 19:27 ` dje at gcc dot gnu.org
2021-03-08 21:09 ` iains at gcc dot gnu.org
2021-03-08 21:24 ` iains at gcc dot gnu.org
2021-03-09  9:55 ` iains at gcc dot gnu.org
2021-03-10 14:28 ` ppalka at gcc dot gnu.org
2021-03-10 14:51 ` ppalka at gcc dot gnu.org
2021-04-08 15:11 ` cvs-commit at gcc dot gnu.org
2021-04-08 15:22 ` [Bug libstdc++/98384] new test case 20_util/to_chars/long_double.cc in r11-6249 fails ppalka at gcc dot gnu.org
2021-04-08 16:22 ` redi at gcc dot gnu.org
2021-04-27 11:39 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:03 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98384-4-7SAnG4AbSj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).