public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ppalka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/98384] [11 Regression] new test case 20_util/to_chars/long_double.cc in r11-6249 fails on powerpc64 BE
Date: Tue, 12 Jan 2021 16:35:22 +0000	[thread overview]
Message-ID: <bug-98384-4-XrdLkD6c9Q@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98384-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98384

--- Comment #8 from Patrick Palka <ppalka at gcc dot gnu.org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #7)
> > --- Comment #6 from Patrick Palka <ppalka at gcc dot gnu.org> ---
> [...]
> > Thanks for testing!  Hmm, that execute failure is surprising.  I wonder just
> > how much we're diverging from the output of printf here.  If possible, could
> > you let me know the value of the locals 'to_chars_buffer', 'printf_buffer',
> > 'precision' and 'testcase' (ideally in hex form) at the point of the assertion
> > failure?
> 
> I'm seeing exactly the same failure mode on Solaris, both sparc and x86:
> 32-bit compilation PASSes, execution XFAILed, 64-bit compilation PASSes,
> too, but execution FAILs with the same assertion failure.
> 
> Here's what gdb prints for those variables (with the test compiled with
> -g3 -O0 where the assertion still fails):
> 
> (gdb) p to_chars_buffer
> $1 = "f.", 'f' <repeats 14 times>, "ep+5380", '\000' <repeats 1000 times>
> (gdb) p printf_buffer
> $2 = "0x1.", 'f' <repeats 15 times>, "cp+5383", '\000' <repeats 997 times>
> (gdb) p precision
> No symbol "precision" in current context.
> (gdb) p testcase
> $3 = 5.56540347525605847154e+1620
> (gdb) p/x testcase
> $5 = 0x7fffffffffffffff

Thanks for this helpful info. 

>From what I can tell, the difference in output here is basically harmless.  The
two hexadecimal forms (in to_chars_buffer and printf_buffer) are equivalent,
though ours is one digit shorter.  Both hexadecimal forms are also valid
results of printf's %La specifier for this value.

Since the standard underspecifies the result of printf's %a specifier, and
since there's apparent implementation divergence, we shouldn't be verifying the
hex output of std::to_chars by comparing it with that of printf.  Instead we
should compare with the known correct value, or perhaps verify that applying
std::from_chars on the output yields the original value.

  parent reply	other threads:[~2021-01-12 16:35 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 21:39 [Bug libstdc++/98384] New: " seurer at gcc dot gnu.org
2020-12-21 20:28 ` [Bug libstdc++/98384] " ppalka at gcc dot gnu.org
2020-12-22  9:23 ` ro at gcc dot gnu.org
2021-01-05  9:10 ` [Bug libstdc++/98384] [11 Regression] " rguenth at gcc dot gnu.org
2021-01-07 13:04 ` iains at gcc dot gnu.org
2021-01-07 15:42 ` ppalka at gcc dot gnu.org
2021-01-07 16:41 ` iains at gcc dot gnu.org
2021-01-07 17:42 ` cvs-commit at gcc dot gnu.org
2021-01-07 17:55 ` ppalka at gcc dot gnu.org
2021-01-08  9:30 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-01-12 16:35 ` ppalka at gcc dot gnu.org [this message]
2021-01-14 11:13 ` rguenth at gcc dot gnu.org
2021-02-12 15:02 ` jakub at gcc dot gnu.org
2021-02-23  2:49 ` cvs-commit at gcc dot gnu.org
2021-02-23 16:55 ` ppalka at gcc dot gnu.org
2021-02-24  9:58 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-02-24 15:14 ` ppalka at gcc dot gnu.org
2021-02-24 15:42 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-02-24 15:48 ` jakub at gcc dot gnu.org
2021-02-24 16:16 ` ppalka at gcc dot gnu.org
2021-02-24 16:26 ` iains at gcc dot gnu.org
2021-02-24 16:45 ` ppalka at gcc dot gnu.org
2021-02-24 17:26 ` cvs-commit at gcc dot gnu.org
2021-02-27 16:17 ` iains at gcc dot gnu.org
2021-02-27 16:49 ` dje at gcc dot gnu.org
2021-03-03 14:28 ` ppalka at gcc dot gnu.org
2021-03-05  2:37 ` dje at gcc dot gnu.org
2021-03-08 17:42 ` ppalka at gcc dot gnu.org
2021-03-08 17:53 ` schwab@linux-m68k.org
2021-03-08 19:27 ` dje at gcc dot gnu.org
2021-03-08 21:09 ` iains at gcc dot gnu.org
2021-03-08 21:24 ` iains at gcc dot gnu.org
2021-03-09  9:55 ` iains at gcc dot gnu.org
2021-03-10 14:28 ` ppalka at gcc dot gnu.org
2021-03-10 14:51 ` ppalka at gcc dot gnu.org
2021-04-08 15:11 ` cvs-commit at gcc dot gnu.org
2021-04-08 15:22 ` [Bug libstdc++/98384] new test case 20_util/to_chars/long_double.cc in r11-6249 fails ppalka at gcc dot gnu.org
2021-04-08 16:22 ` redi at gcc dot gnu.org
2021-04-27 11:39 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:03 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98384-4-XrdLkD6c9Q@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).