public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/98738] task-detach-6.f90 hangs intermittently
Date: Thu, 21 Jan 2021 13:12:29 +0000	[thread overview]
Message-ID: <bug-98738-4-Pif3RcwZEf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98738-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98738

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I've been wondering whether it wouldn't be best to pass through
omp_eventhandle_t  the pointer to the gomp_task rather than some particular
semaphore and in omp_fulfill_event then decide based on that task, one case
would be if it is the included task, then it should post a semaphore and be
done with it, otherwise (not included task), it should find the corresponding
team (which might not be necessary the omp_fulfill_event's task), lock the
task_lock and figure out in which of the many cases the task is in, if not yet
finished, perhaps just clear detach bool and be done with it, if in the state
after that, figure out what is waiting for that task and deal with that.
Not sure if a per-task semaphore is what we want in that case, e.g. we could
have a taskwait, taskgroup end or barrier waiting for multiple tasks with
detach clause and if that is the only thing they might be waiting on, then
those should be sleeping on taskwait_sem, taskgroup_sem or on the barrier, so
depending on what they are sleeping on that should be awaken.

  parent reply	other threads:[~2021-01-21 13:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 21:42 [Bug libgomp/98738] New: " iii at linux dot ibm.com
2021-01-18 21:50 ` [Bug libgomp/98738] " iii at linux dot ibm.com
2021-01-19  3:03 ` hjl.tools at gmail dot com
2021-01-19  8:51 ` dominiq at lps dot ens.fr
2021-01-19 10:35 ` ro at gcc dot gnu.org
2021-01-19 13:22 ` jakub at gcc dot gnu.org
2021-01-19 15:13 ` kcy at codesourcery dot com
2021-01-20 15:53 ` jakub at gcc dot gnu.org
2021-01-20 16:06 ` jakub at gcc dot gnu.org
2021-01-21 13:00 ` kcy at codesourcery dot com
2021-01-21 13:12 ` jakub at gcc dot gnu.org [this message]
2021-01-24 16:52 ` dominiq at lps dot ens.fr
2021-02-25 22:48 ` cvs-commit at gcc dot gnu.org
2021-03-11 13:58 ` tschwinge at gcc dot gnu.org
2021-03-11 14:03 ` jakub at gcc dot gnu.org
2021-03-11 14:05 ` kcy at codesourcery dot com
2021-03-11 14:30 ` tschwinge at gcc dot gnu.org
2021-03-11 16:37 ` tschwinge at gcc dot gnu.org
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:04 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98738-4-Pif3RcwZEf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).