public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/98738] task-detach-6.f90 hangs intermittently
Date: Wed, 20 Jan 2021 16:06:06 +0000	[thread overview]
Message-ID: <bug-98738-4-mfB12pUH6o@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-98738-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98738

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think omp_fullfill_event needs to do much more than it does.
Just look e.g. at what gomp_target_task_completion does.  The function needs to
find out in what state the task is (I'm afraid it needs to take the
team->task_lock around that checking (if any)), if the task hasn't finished
yet, it shouldn't need anything but sem_post but if it has already finished and
it is just waiting for the completion event, it needs to handle taskwait,
depend wait, taskgroup waits and barrier waits.
Sorry for not catching that during patch review.

  parent reply	other threads:[~2021-01-20 16:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18 21:42 [Bug libgomp/98738] New: " iii at linux dot ibm.com
2021-01-18 21:50 ` [Bug libgomp/98738] " iii at linux dot ibm.com
2021-01-19  3:03 ` hjl.tools at gmail dot com
2021-01-19  8:51 ` dominiq at lps dot ens.fr
2021-01-19 10:35 ` ro at gcc dot gnu.org
2021-01-19 13:22 ` jakub at gcc dot gnu.org
2021-01-19 15:13 ` kcy at codesourcery dot com
2021-01-20 15:53 ` jakub at gcc dot gnu.org
2021-01-20 16:06 ` jakub at gcc dot gnu.org [this message]
2021-01-21 13:00 ` kcy at codesourcery dot com
2021-01-21 13:12 ` jakub at gcc dot gnu.org
2021-01-24 16:52 ` dominiq at lps dot ens.fr
2021-02-25 22:48 ` cvs-commit at gcc dot gnu.org
2021-03-11 13:58 ` tschwinge at gcc dot gnu.org
2021-03-11 14:03 ` jakub at gcc dot gnu.org
2021-03-11 14:05 ` kcy at codesourcery dot com
2021-03-11 14:30 ` tschwinge at gcc dot gnu.org
2021-03-11 16:37 ` tschwinge at gcc dot gnu.org
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:04 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-98738-4-mfB12pUH6o@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).