[Bug fortran/99036] New: [11 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[Bug fortran/99036] New: [11 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

            Bug ID: 99036
           Summary: [11 Regression] ICE in gfc_current_interface_head, at
                    fortran/interface.c:4699
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20210117 and 20210124 :


$ cat z1.f90
module m
contains
   module procedure s
   end
end


$ gfortran-11-20210117 -c z1.f90
z1.f90:3:20:

    3 |    module procedure s
      |                    1
Error: MODULE PROCEDURE at (1) must be in a generic module interface


$ gfortran-11-20210207 -c z1.f90
f951: internal compiler error: in gfc_current_interface_head, at
fortran/interface.c:4699
0x69b474 gfc_current_interface_head()
        ../../gcc/fortran/interface.c:4699
0x6777e5 gfc_match_modproc()
        ../../gcc/fortran/decl.c:9883
0x6db9c1 match_word
        ../../gcc/fortran/parse.c:65
0x6dfe30 decode_statement
        ../../gcc/fortran/parse.c:522
0x6e097c next_free
        ../../gcc/fortran/parse.c:1316
0x6e097c next_statement
        ../../gcc/fortran/parse.c:1548
0x6e511c parse_contained
        ../../gcc/fortran/parse.c:5743
0x6e5fd7 parse_module
        ../../gcc/fortran/parse.c:6170
0x6e6307 gfc_parse_file()
        ../../gcc/fortran/parse.c:6473
0x732e7f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/99036] [11 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-02-10
                 CC|                            |kargl at gcc dot gnu.org
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from kargl at gcc dot gnu.org ---
Possible patch.  Tested against Gerhard's example.  Not regression tested.

diff --git a/gcc/fortran/decl.c b/gcc/fortran/decl.c
index 723915822f3..8cdfdf8f03a 100644
--- a/gcc/fortran/decl.c
+++ b/gcc/fortran/decl.c
@@ -9881,6 +9879,12 @@ gfc_match_modproc (void)
   /* Store the current state of the interface. We will need it if we
      end up with a syntax error and need to recover.  */
   old_interface_head = gfc_current_interface_head ();
+  if (!old_interface_head)
+    {
+      gfc_error ("MODULE PROCEDURE at %C must be in a generic module "
+                "interface");
+      return MATCH_ERROR;
+    }

   /* Check if the F2008 optional double colon appears.  */
   gfc_gobble_whitespace ();
diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c
index 87fe14280e6..aec5536d7c6 100644
--- a/gcc/fortran/interface.c
+++ b/gcc/fortran/interface.c
@@ -4696,7 +4696,7 @@ gfc_current_interface_head (void)
        return current_interface.uop->op;

       default:
-       gcc_unreachable ();
+       return NULL;
     }
 }

[Bug fortran/99036] [11 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0

[Bug fortran/99036] [11 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |pault at gcc dot gnu.org

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Just for the record, started with r11-6832-geaf883710c0039ec.

[Bug fortran/99036] [11/12 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.0                        |11.2

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 11.1 has been released, retargeting bugs to GCC 11.2.

[Bug fortran/99036] [11/12 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.2                        |11.3

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.2 is being released, retargeting bugs to GCC 11.3

[Bug fortran/99036] [11/12 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

--- Comment #5 from G. Steinmetz <gscfq@t-online.de> ---

Another try with a case that is probably/hopefully related.
The following example with a module and submodule in different files
is valid for e.g. -std=f2008, but invalid for -std=f2003 or -std=f95 :


$ cat z2.f90
module m
   interface
      module logical function f(x)
         character(*), intent(in) :: x
      end
   end interface
end


$ cat z3.f90
submodule(m) m2
contains
   module procedure f
      inquire (file=x, exist=f)
   end procedure
end


$ gfortran-12-20211107 -c z2.f90 z3.f90
$
$ gfortran-12-20211107 -c z2.f90 z3.f90 -std=f2003
z2.f90:3:14:

    3 |       module logical function f(x)
      |              1
Error: Fortran 2008: MODULE prefix at (1)
z2.f90:4:38:

    4 |          character(*), intent(in) :: x
      |                                      1
Error: Unexpected data declaration statement in INTERFACE block at (1)
z2.f90:5:9:

    5 |       end
      |         1
Error: END INTERFACE statement expected at (1)
z3.f90:1:10:

    1 | submodule(m) m2
      |          1
Error: Fortran 2008: SUBMODULE declaration at (1)
f951: internal compiler error: in gfc_current_interface_head, at
fortran/interface.c:4842
0x7e9464 gfc_current_interface_head()
        ../../gcc/fortran/interface.c:4842
0x7c4385 gfc_match_modproc()
        ../../gcc/fortran/decl.c:9978
0x82d421 match_word
        ../../gcc/fortran/parse.c:67
0x832630 decode_statement
        ../../gcc/fortran/parse.c:524
0x83317a next_free
        ../../gcc/fortran/parse.c:1388
0x83317a next_statement
        ../../gcc/fortran/parse.c:1620
0x837f6c parse_contained
        ../../gcc/fortran/parse.c:6017
0x837e96 parse_progunit
        ../../gcc/fortran/parse.c:6242
0x838c4c gfc_parse_file()
        ../../gcc/fortran/parse.c:6763
0x886d7f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:216

[Bug fortran/99036] [11/12 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

--- Comment #6 from kargl at gcc dot gnu.org ---
(In reply to G. Steinmetz from comment #5)
> Another try with a case that is probably/hopefully related.
> The following example with a module and submodule in different files
> is valid for e.g. -std=f2008, but invalid for -std=f2003 or -std=f95 :
> 

Patch posted in comment #1 allows this case to compile.

[Bug fortran/99036] [11/12 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.3                        |11.4

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11.3 is being released, retargeting bugs to GCC 11.4.

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker.weissmann at gmx dot de

--- Comment #8 from anlauf at gcc dot gnu.org ---
*** Bug 109211 has been marked as a duplicate of this bug. ***

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #9 from anlauf at gcc dot gnu.org ---
Even simpler tentative patch:

diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc
index c8f0bb83c2c..b29f491fe1f 100644
--- a/gcc/fortran/decl.cc
+++ b/gcc/fortran/decl.cc
@@ -9998,6 +9998,7 @@ gfc_match_modproc (void)
   if ((gfc_state_stack->state != COMP_INTERFACE
        && gfc_state_stack->state != COMP_CONTAINS)
       || gfc_state_stack->previous == NULL
+      || !current_interface.type
       || current_interface.type == INTERFACE_NAMELESS
       || current_interface.type == INTERFACE_ABSTRACT)
     {

This keeps the original error message without effort and regtests ok.

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #10 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-March/059104.html

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:dd282b16bfd3c6e218dffb7798a375365b10ae22

commit r13-6790-gdd282b16bfd3c6e218dffb7798a375365b10ae22
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Mar 21 19:58:31 2023 +0100

    Fortran: reject MODULE PROCEDURE outside generic module interface [PR99036]

    gcc/fortran/ChangeLog:

            PR fortran/99036
            * decl.cc (gfc_match_modproc): Reject MODULE PROCEDURE if not in a
            generic module interface.

    gcc/testsuite/ChangeLog:

            PR fortran/99036
            * gfortran.dg/pr99036.f90: New test.

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:7eb94c5adfd85c38e4ed7a7fff74b59087ddb813

commit r12-9311-g7eb94c5adfd85c38e4ed7a7fff74b59087ddb813
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Mar 21 19:58:31 2023 +0100

    Fortran: reject MODULE PROCEDURE outside generic module interface [PR99036]

    gcc/fortran/ChangeLog:

            PR fortran/99036
            * decl.cc (gfc_match_modproc): Reject MODULE PROCEDURE if not in a
            generic module interface.

    gcc/testsuite/ChangeLog:

            PR fortran/99036
            * gfortran.dg/pr99036.f90: New test.

    (cherry picked from commit dd282b16bfd3c6e218dffb7798a375365b10ae22)

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:2055702e8d492be6e978fa93a7bfefd358d5d9e3

commit r11-10596-g2055702e8d492be6e978fa93a7bfefd358d5d9e3
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Mar 21 19:58:31 2023 +0100

    Fortran: reject MODULE PROCEDURE outside generic module interface [PR99036]

    gcc/fortran/ChangeLog:

            PR fortran/99036
            * decl.c (gfc_match_modproc): Reject MODULE PROCEDURE if not in a
            generic module interface.

    gcc/testsuite/ChangeLog:

            PR fortran/99036
            * gfortran.dg/pr99036.f90: New test.

    (cherry picked from commit dd282b16bfd3c6e218dffb7798a375365b10ae22)

[Bug fortran/99036] [11/12/13 Regression] ICE in gfc_current_interface_head, at fortran/interface.c:4699

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99036

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #14 from anlauf at gcc dot gnu.org ---
Fixed on all affected branches.  Closing.

Thanks for the report!