public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99083] Big run-time regressions of 519.lbm_r with LTO
Date: Thu, 25 Feb 2021 09:50:18 +0000 [thread overview]
Message-ID: <bug-99083-4-lbpVeLBvht@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99083-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99083
Uroš Bizjak <ubizjak at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Keywords| |patch
Assignee|unassigned at gcc dot gnu.org |ubizjak at gmail dot com
Resolution|FIXED |---
--- Comment #13 from Uroš Bizjak <ubizjak at gmail dot com> ---
(In reply to Martin Jambor from comment #12)
> For the record, I have benchmarked the patches from comment #4 and comment
> #10 on top of commit 6b1633378b7 (for which I already have unpatched
> benchmark results) and the regression of 519.lbm_r compiled with -O2 LTO
> dropped from 62% to 8%.
>
> The -Ofast -march=native -flto vs. non-LTO regression also dropped from 8%
> to about 5% (GCC 10 also has non-LTO 2.5% faster than LTO, but at least both
> times improved vs. GCC 10).
>
> The only notable regression brought about the patch was 538.imagick_r when
> compiled at -Ofast -march=native without LTO, which was 6% slower with the
> patch.
>
> All of the measurements were done on a Zen2 machine.
>
> Thank you for reverting the patch, now we need to look for LNT to pick up
> the changes.
The complete patch that presumably corrects HONOR_REG_ALLOC_ORDER usage is at
[1],
but IIUC the above measurements, there is still a regression of 8% vs unpatched
compiler. With the complete patch [1], ira_better_spill_reload_regno_p change
should be a NO-OP, but the new default also disables the internal calculations
in assign_hard_reg, please see [2] for reasoning.
Based on the above benchmarks, it looks that disabling the internal
calculations in assign_hard_reg is harmful even for HONOR_REG_ALLOC_ORDER
targets, at least patched x86 compiler shows this effect. Maybe Vlad could
comment this part.
Let's reopen this PR to keep the discussions in one place.
[1] https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565640.html
[2] https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565699.html
next prev parent reply other threads:[~2021-02-25 9:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 23:32 [Bug target/99083] New: " jamborm at gcc dot gnu.org
2021-02-13 8:53 ` [Bug target/99083] " ubizjak at gmail dot com
2021-02-15 8:20 ` marxin at gcc dot gnu.org
2021-02-15 8:22 ` rguenth at gcc dot gnu.org
2021-02-15 9:57 ` ubizjak at gmail dot com
2021-02-15 12:00 ` ubizjak at gmail dot com
2021-02-15 12:03 ` ubizjak at gmail dot com
2021-02-15 12:08 ` ubizjak at gmail dot com
2021-02-15 12:47 ` rguenth at gcc dot gnu.org
2021-02-15 13:08 ` ubizjak at gmail dot com
2021-02-15 13:11 ` jamborm at gcc dot gnu.org
2021-02-15 13:31 ` ubizjak at gmail dot com
2021-02-21 17:45 ` ubizjak at gmail dot com
2021-02-21 17:45 ` ubizjak at gmail dot com
2021-02-23 17:59 ` jamborm at gcc dot gnu.org
2021-02-25 9:50 ` ubizjak at gmail dot com [this message]
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-07-28 7:05 ` rguenth at gcc dot gnu.org
2022-04-21 7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:04 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99083-4-lbpVeLBvht@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).