public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99083] Big run-time regressions of 519.lbm_r with LTO
Date: Mon, 15 Feb 2021 08:22:11 +0000	[thread overview]
Message-ID: <bug-99083-4-xMiNkhILXJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99083-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99083

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
The following ira-color.c piece has heuristics that get triggered differently:

/* Return TRUE if spilling pseudo-registers whose numbers are in array
   REGNOS is better than spilling pseudo-registers with numbers in
   OTHER_REGNOS for reload with given IN and OUT for INSN.  The
   function used by the reload pass to make better register spilling
   decisions.  */
bool
ira_better_spill_reload_regno_p (int *regnos, int *other_regnos,
                                 rtx in, rtx out, rtx_insn *insn)
{
..
#ifdef REG_ALLOC_ORDER
  if (hard_regno >= 0 && other_hard_regno >= 0)
    return (inv_reg_alloc_order[hard_regno]
            < inv_reg_alloc_order[other_hard_regno]);
#else
  if (call_used_count != other_call_used_count)
    return call_used_count > other_call_used_count;
#endif
  return false;
}

it somehow reads to me as if that should have tested HONOR_REG_ALLOC_ORDER
instead?  Not sure how likely it is that we run into this (last) condition.

Interestingly x86 defines ADJUST_REG_ALLOC_ORDER.

  parent reply	other threads:[~2021-02-15  8:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 23:32 [Bug target/99083] New: " jamborm at gcc dot gnu.org
2021-02-13  8:53 ` [Bug target/99083] " ubizjak at gmail dot com
2021-02-15  8:20 ` marxin at gcc dot gnu.org
2021-02-15  8:22 ` rguenth at gcc dot gnu.org [this message]
2021-02-15  9:57 ` ubizjak at gmail dot com
2021-02-15 12:00 ` ubizjak at gmail dot com
2021-02-15 12:03 ` ubizjak at gmail dot com
2021-02-15 12:08 ` ubizjak at gmail dot com
2021-02-15 12:47 ` rguenth at gcc dot gnu.org
2021-02-15 13:08 ` ubizjak at gmail dot com
2021-02-15 13:11 ` jamborm at gcc dot gnu.org
2021-02-15 13:31 ` ubizjak at gmail dot com
2021-02-21 17:45 ` ubizjak at gmail dot com
2021-02-21 17:45 ` ubizjak at gmail dot com
2021-02-23 17:59 ` jamborm at gcc dot gnu.org
2021-02-25  9:50 ` ubizjak at gmail dot com
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:04 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99083-4-xMiNkhILXJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).