public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ubizjak at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99083] Big run-time regressions of 519.lbm_r with LTO
Date: Sat, 13 Feb 2021 08:53:46 +0000	[thread overview]
Message-ID: <bug-99083-4-wZ90FLRP6B@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99083-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99083

--- Comment #1 from Uroš Bizjak <ubizjak at gmail dot com> ---
This should be a no-op. According to the documentation:

--q--
Macro: REG_ALLOC_ORDER

    If defined, an initializer for a vector of integers, containing the numbers
of hard registers in the order in which GCC should prefer to use them (from
most preferred to least).

    If this macro is not defined, registers are used lowest numbered first (all
else being equal).

    One use of this macro is on machines where the highest numbered registers
must always be saved and the save-multiple-registers instruction supports only
sequences of consecutive registers. On such machines, define REG_ALLOC_ORDER to
be an initializer that lists the highest numbered allocable register first. 
--/q--

and the patch removed:

-#define REG_ALLOC_ORDER                                                       
\
-{ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15,                       
\
-  16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31,      \
-  32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,      \
-  48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63,      \
-  64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75 }

It is trivial to revert the offending commit, but I think that this PR warrants
some more analysis of the underlying problem, presumably in the generic code.

  reply	other threads:[~2021-02-13  8:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 23:32 [Bug target/99083] New: " jamborm at gcc dot gnu.org
2021-02-13  8:53 ` ubizjak at gmail dot com [this message]
2021-02-15  8:20 ` [Bug target/99083] " marxin at gcc dot gnu.org
2021-02-15  8:22 ` rguenth at gcc dot gnu.org
2021-02-15  9:57 ` ubizjak at gmail dot com
2021-02-15 12:00 ` ubizjak at gmail dot com
2021-02-15 12:03 ` ubizjak at gmail dot com
2021-02-15 12:08 ` ubizjak at gmail dot com
2021-02-15 12:47 ` rguenth at gcc dot gnu.org
2021-02-15 13:08 ` ubizjak at gmail dot com
2021-02-15 13:11 ` jamborm at gcc dot gnu.org
2021-02-15 13:31 ` ubizjak at gmail dot com
2021-02-21 17:45 ` ubizjak at gmail dot com
2021-02-21 17:45 ` ubizjak at gmail dot com
2021-02-23 17:59 ` jamborm at gcc dot gnu.org
2021-02-25  9:50 ` ubizjak at gmail dot com
2021-04-27 11:40 ` jakub at gcc dot gnu.org
2021-07-28  7:05 ` rguenth at gcc dot gnu.org
2022-04-21  7:48 ` rguenth at gcc dot gnu.org
2023-05-29 10:04 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99083-4-wZ90FLRP6B@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).