[Bug ada/99264] New: Ada doesn't build against latest glibc

[Bug ada/99264] New: Ada doesn't build against latest glibc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

            Bug ID: 99264
           Summary: Ada doesn't build against latest glibc
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

In file included from /usr/include/signal.h:315,
                 from /usr/include/sys/param.h:28,
                 from ../../gcc/system.h:305,
                 from ../../gcc/ada/init.c:71:
../../gcc/ada/init.c:584:18: error: missing binary operator before token "("
  584 | # if 16 * 1024 < MINSIGSTKSZ
      |                  ^~~~~~~~~~~

Apparently the latest glibc defines it as
sysconf (_SC_SIGSTKSZ)
and so it isn't usable in preprocessor.

[Bug ada/99264] Ada doesn't build against latest glibc

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.0
                 CC|                            |ebotcazou at gcc dot gnu.org,
                   |                            |fw at gcc dot gnu.org

[Bug ada/99264] Ada doesn't build against latest glibc

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Works for me with glibc 2.33 and g:9e0d8a375bae07486c839228a520eaed9004a4f3

[Bug ada/99264] Ada doesn't build against latest glibc

[fw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

Florian Weimer <fw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #2 from Florian Weimer <fw at gcc dot gnu.org> ---
The reason for this change in glibc 2.34 is that the size of the context
information pushed by the kernel has increased by about an order of magnitude
over the last decade.

Missing size check in sigaltstack 
https://bugzilla.kernel.org/show_bug.cgi?id=153531

x86: MINSIGSTKSZ too small for AVX-512F support 
https://sourceware.org/bugzilla/show_bug.cgi?id=20305

Small signal stacks needed to be allocated at run time, using the
kernel-supplied size plus the extra part that the application needs.

[Bug ada/99264] Ada doesn't build against latest glibc

[fw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

--- Comment #3 from Florian Weimer <fw at gcc dot gnu.org> ---
As a stop-gap measure, it might be possible to replace the preprocessor check
with a run-time check during initialization.

[Bug ada/99264] Ada doesn't build against latest glibc

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-02-25
     Ever confirmed|0                           |1

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
This looks like a serious compatibility breakage on the glibc side though.

[Bug ada/99264] Ada doesn't build against latest glibc

[fw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

--- Comment #5 from Florian Weimer <fw at gcc dot gnu.org> ---
(In reply to Eric Botcazou from comment #4)
> This looks like a serious compatibility breakage on the glibc side though.

POSIX does not require that the constant is usable in preprocessor macros, so
the code has always been invalid (technically speaking).

However, there is little that we can do. The hardware requirements have changed
under us, so even the kernel does not have much choice here. Applications
really have to adapt to the massively increased size of the register file,
there really is no way around that.

[Bug ada/99264] latest glibc release breaks Ada buildr on Linux

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ebotcazou at gcc dot gnu.org
                 CC|ebotcazou at gcc dot gnu.org       |
             Status|NEW                         |ASSIGNED
             Target|                            |*-*-linux-gnu
            Summary|Ada doesn't build against   |latest glibc release breaks
                   |latest glibc                |Ada buildr on Linux

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> However, there is little that we can do. The hardware requirements have
> changed under us, so even the kernel does not have much choice here.
> Applications really have to adapt to the massively increased size of the
> register file, there really is no way around that.

Providing a new constant minimal default would have been better IMO, even if it
would have been significantly larger than the current one, than breaking a long
established practice.

[Bug ada/99264] latest glibc release breaks Ada build on Linux

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:331763de7d4850702a0f67298f36017c73cdb103

commit r11-7523-g331763de7d4850702a0f67298f36017c73cdb103
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Fri Mar 5 12:45:41 2021 +0100

    Fix build breakage with latest glibc release

    gcc/ada/
            PR ada/99264
            * init.c (__gnat_alternate_sta) [Linux]: Remove preprocessor test
on
            MINSIGSTKSZ and bump size to 32KB.
            * libgnarl/s-osinte__linux.ads (Alternate_Stack_Size): Bump to
32KB.

[Bug ada/99264] latest glibc release breaks Ada build on Linux

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Eric Botcazou
<ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:c85c24099b28f7af907466af2c1b73da9455368c

commit r10-9417-gc85c24099b28f7af907466af2c1b73da9455368c
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Fri Mar 5 12:45:41 2021 +0100

    Fix build breakage with latest glibc release

    gcc/ada/
            PR ada/99264
            * init.c (__gnat_alternate_sta) [Linux]: Remove preprocessor test
on
            MINSIGSTKSZ and bump size to 32KB.
            * libgnarl/s-osinte__linux.ads (Alternate_Stack_Size): Bump to
32KB.

[Bug ada/99264] latest glibc release breaks Ada build on Linux

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Eric Botcazou
<ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:a5a7cdcaa0c29ee547c41d24f495e9694a6fe7f1

commit r9-9267-ga5a7cdcaa0c29ee547c41d24f495e9694a6fe7f1
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Fri Mar 5 12:45:41 2021 +0100

    Fix build breakage with latest glibc release

    gcc/ada/
            PR ada/99264
            * init.c (__gnat_alternate_sta) [Linux]: Remove preprocessor test
on
            MINSIGSTKSZ and bump size to 32KB.
            * libgnarl/s-osinte__linux.ads (Alternate_Stack_Size): Bump to
32KB.

[Bug ada/99264] latest glibc release breaks Ada build on Linux

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99264

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|11.0                        |9.4

--- Comment #10 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixed on mainline, 10 and 9 branches.